Build your own AI office with Univer Office SDK. Bring editing, calculation, collaboration, and file processing into your product for people and AI agents. Built on an extensible open-source core.
TypeScript boardcollaborationdocdocxexceloffce365officepdfpptpptxpresentationsdksheetslidesspreadsheetuniverwordwordprocessorworkspacexlsx
fix: use Singleton Pattern of Hyphen (#2242)
Ran Luoba853df98f8a
diff --git a/packages/engine-render/src/components/docs/layout/doc-skeleton.ts b/packages/engine-render/src/components/docs/layout/doc-skeleton.tsindex 1a77906cb6..446f115bbf 100644--- a/packages/engine-render/src/components/docs/layout/doc-skeleton.ts+++ b/packages/engine-render/src/components/docs/layout/doc-skeleton.ts@@ -65,9 +65,9 @@ export class DocumentSkeleton extends Skeleton {private _findLiquid: Liquid = new Liquid();// Use for hyphenation.- private _hyphen = new Hyphen();+ private _hyphen = Hyphen.getInstance();- private _languageDetector = new LanguageDetector();+ private _languageDetector = LanguageDetector.getInstance();private _iteratorCount = 0;diff --git a/packages/engine-render/src/components/docs/layout/hyphenation/hyphen.ts b/packages/engine-render/src/components/docs/layout/hyphenation/hyphen.tsindex 10700922af..528fbdbf74 100644--- a/packages/engine-render/src/components/docs/layout/hyphenation/hyphen.ts+++ b/packages/engine-render/src/components/docs/layout/hyphenation/hyphen.ts@@ -15,6 +15,7 @@*/import type { IDisposable } from '@wendellhu/redi';+import type { Nullable } from '@univerjs/core';import { Lang } from './lang';import { EnUs } from './patterns/en-us';import type { IHyphenPattern, RawHyphenPattern } from './tools';@@ -24,6 +25,16 @@ export class Hyphen implements IDisposable {private _patterns: Map<Lang, IHyphenPattern> = new Map();private _hyphenCache: Map<Lang, Map<string, string[]>> = new Map();+ private static _instance: Nullable<Hyphen> = null;++ static getInstance(): Hyphen {+ if (this._instance == null) {+ this._instance = new Hyphen();+ }++ return this._instance;+ }+constructor() {this._preloadPatterns();this.loadPattern(Lang.EnGb);diff --git a/packages/engine-render/src/components/docs/layout/hyphenation/language-detector.ts b/packages/engine-render/src/components/docs/layout/hyphenation/language-detector.tsindex fccee9dc90..d43b1e299b 100644--- a/packages/engine-render/src/components/docs/layout/hyphenation/language-detector.ts+++ b/packages/engine-render/src/components/docs/layout/hyphenation/language-detector.ts@@ -16,6 +16,7 @@import type { IDisposable } from '@wendellhu/redi';import { franc } from 'franc-min';+import type { Nullable } from '@univerjs/core';import { Lang } from './lang';const LANG_MAP_TO_HYPHEN_LANG: Record<string, Lang> = {@@ -108,6 +109,16 @@ export class LanguageDetector implements IDisposable {// language cache for special text.private _detectCache = new Map<string, Lang>();+ private static _instance: Nullable<LanguageDetector> = null;++ static getInstance(): LanguageDetector {+ if (this._instance == null) {+ this._instance = new LanguageDetector();+ }++ return this._instance;+ }+detect(text: string): Lang {let lang = this._detectCache.get(text);