Build your own AI office with Univer Office SDK. Bring editing, calculation, collaboration, and file processing into your product for people and AI agents. Built on an extensible open-source core.
TypeScript boardcollaborationdocdocxexceloffce365officepdfpptpptxpresentationsdksheetslidesspreadsheetuniverwordwordprocessorworkspacexlsx
fix(docs-ui): error display doc-toolbar on sheet (#4751)
zhangwbc3c3345a8a7
diff --git a/e2e/memory/memory.spec.ts b/e2e/memory/memory.spec.tsindex 6b6574c0e4..0cd6ca8be8 100644--- a/e2e/memory/memory.spec.ts+++ b/e2e/memory/memory.spec.ts@@ -28,7 +28,7 @@ const MAX_UNIT_MEMORY_OVERFLOW = 1_000_000; // 1MBconst MAX_UNIVER_MEMORY_OVERFLOW = 6_000_000; // TODO@wzhudev: temporarily added 300KB// there is a memory leak in the univer object, so we need to make sure that-const MAX_SECOND_INSTANCE_OVERFLOW = 100_000; // Only 100 KB+const MAX_SECOND_INSTANCE_OVERFLOW = 110_000; // Only 100 KBinterface HeapSnapshotChunk {chunk: string;diff --git a/packages/docs-ui/src/controllers/doc-ui.controller.ts b/packages/docs-ui/src/controllers/doc-ui.controller.tsindex d5d96e4f59..a491fd6b93 100644--- a/packages/docs-ui/src/controllers/doc-ui.controller.ts+++ b/packages/docs-ui/src/controllers/doc-ui.controller.ts@@ -88,11 +88,9 @@ export class DocUIController extends Disposable {this.disposeWithMe(componentManager.register('TodoList', TodoList));}- // TODO: @zhangwei, why add workbook to docs-ui?private _initUiParts() {- const workbook = this._univerInstanceService.getCurrentUnitForType(UniverInstanceType.UNIVER_SHEET);const config = this._configService.getConfig<IUniverDocsUIConfig>(DOCS_UI_PLUGIN_CONFIG_KEY);- if (config?.layout?.docContainerConfig?.footer && !workbook) {+ if (config?.layout?.docContainerConfig?.footer) {this.disposeWithMe(this._uiPartsService.registerComponent(BuiltInUIPart.FOOTER, () => connectInjector(DocFooter, this._injector)));}}diff --git a/packages/docs-ui/src/views/doc-footer/DocFooter.tsx b/packages/docs-ui/src/views/doc-footer/DocFooter.tsxindex c63b7d475e..349899e6ac 100644--- a/packages/docs-ui/src/views/doc-footer/DocFooter.tsx+++ b/packages/docs-ui/src/views/doc-footer/DocFooter.tsx@@ -14,12 +14,16 @@* limitations under the License.*/-import React from 'react';import { CountBar } from '../count-bar';import styles from './index.module.less';+import { useDependency, useObservable } from '@univerjs/ui';+import { IUniverInstanceService, UniverInstanceType, type Workbook } from '@univerjs/core';export const DocFooter = () => {- return (+ const univerInstanceService = useDependency(IUniverInstanceService);+ const workbook = useObservable(() => univerInstanceService.getCurrentTypeOfUnit$<Workbook>(UniverInstanceType.UNIVER_SHEET), undefined, undefined, []);++ return workbook ? null : (<div className={styles.docFooterContainer}><div /><CountBar />