Skip to content

Build your own AI office with Univer Office SDK. Bring editing, calculation, collaboration, and file processing into your product for people and AI agents. Built on an extensible open-source core.

fix(docs-quick-insert-ui): hide empty heading and quck-insert menu filter (#5078)

ZhangWeic36814703c29
diff --git a/packages/design/src/components/menu/Menu.tsx b/packages/design/src/components/menu/Menu.tsx
index c637814021..46426db705 100644
--- a/packages/design/src/components/menu/Menu.tsx
+++ b/packages/design/src/components/menu/Menu.tsx
@@ -25,13 +25,14 @@ import styles from './index.module.less';
/** @deprecated */
export const Menu = React.forwardRef<MenuRef, MenuProps & { wrapperClass?: string }>((props, ref) => {
const { mountContainer } = useContext(ConfigContext);
+ const { wrapperClass, ...rest } = props;
return mountContainer && (
<RcMenu
ref={ref}
prefixCls={clsx(styles.menu, props.className)}
getPopupContainer={() => mountContainer}
- {...props}
- className={props.wrapperClass}
+ {...rest}
+ className={wrapperClass}
/>
);
});
diff --git a/packages/docs-quick-insert-ui/src/views/QuickInsertPlaceholder.tsx b/packages/docs-quick-insert-ui/src/views/QuickInsertPlaceholder.tsx
index c8277f2ab8..e40141080b 100644
--- a/packages/docs-quick-insert-ui/src/views/QuickInsertPlaceholder.tsx
+++ b/packages/docs-quick-insert-ui/src/views/QuickInsertPlaceholder.tsx
@@ -25,7 +25,7 @@ export const QuickInsertPlaceholder = () => {
<div
className={`
univer-flex univer-h-full univer-items-center univer-justify-center univer-rounded-lg univer-bg-white
- univer-px-12 univer-py-6 univer-text-gray-400
+ univer-px-12 univer-py-6 univer-text-gray-400 univer-shadow-lg
`}
>
<span>{localeService.t('docQuickInsert.placeholder')}</span>
diff --git a/packages/docs-quick-insert-ui/src/views/menu/index.tsx b/packages/docs-quick-insert-ui/src/views/menu/index.tsx
index 595ff502f9..8a96f2ba46 100644
--- a/packages/docs-quick-insert-ui/src/views/menu/index.tsx
+++ b/packages/docs-quick-insert-ui/src/views/menu/index.tsx
@@ -62,6 +62,7 @@ export const QuickInsertButton = ({ className = '' }: IQuickInsertButtonProps) =
startOffset: p.startIndex,
endOffset: p.startIndex,
}]);
+ docQuickInsertPopupService.setInputOffset({ start: p.startIndex - 1, end: p.startIndex - 1 });
docQuickInsertPopupService.showPopup({
popup,
index: p.startIndex - 1,
diff --git a/packages/docs-ui/src/views/side-menu/index.tsx b/packages/docs-ui/src/views/side-menu/index.tsx
index 31a5e0ce17..dffebe4086 100644
--- a/packages/docs-ui/src/views/side-menu/index.tsx
+++ b/packages/docs-ui/src/views/side-menu/index.tsx
@@ -137,7 +137,7 @@ function DocSideMenuContent() {
isTitle: p.paragraphStyle?.namedStyleType === NamedStyleType.TITLE,
};
})
- .filter(Boolean) as ISideMenuItem[];
+ .filter((item) => item?.text) as ISideMenuItem[];
const handleScroll = useEvent((params) => {
const scrollTop = params.viewportScrollY;