Skip to content

Build your own AI office with Univer Office SDK. Bring editing, calculation, collaboration, and file processing into your product for people and AI agents. Built on an extensible open-source core.

fix(formula): clear ast cache (#4439)

Dushusirc504fcb1b066
diff --git a/packages/engine-formula/src/engine/dependency/formula-dependency.ts b/packages/engine-formula/src/engine/dependency/formula-dependency.ts
index e82ff12a0b..583d0053e0 100644
--- a/packages/engine-formula/src/engine/dependency/formula-dependency.ts
+++ b/packages/engine-formula/src/engine/dependency/formula-dependency.ts
@@ -38,7 +38,7 @@ import { Lexer } from '../analysis/lexer';
import { AstTreeBuilder } from '../analysis/parser';
import { NodeType } from '../ast-node/node-type';
import { Interpreter } from '../interpreter/interpreter';
-import { generateAstNode, includeDefinedName } from '../utils/generate-ast-node';
+import { FORMULA_AST_CACHE, generateAstNode, includeDefinedName } from '../utils/generate-ast-node';
import { FormulaDependencyTree, FormulaDependencyTreeType, FormulaDependencyTreeVirtual } from './dependency-tree';
const FORMULA_CACHE_LRU_COUNT = 5000;
@@ -82,6 +82,7 @@ export class FormulaDependencyGenerator extends Disposable {
override dispose(): void {
this._updateRangeFlattenCache.clear();
this._dependencyRTreeCacheForAddressFunction.clear();
+ FORMULA_AST_CACHE.clear();
}
async generate() {
diff --git a/packages/engine-formula/src/engine/utils/generate-ast-node.ts b/packages/engine-formula/src/engine/utils/generate-ast-node.ts
index 32d83117e0..252030952c 100644
--- a/packages/engine-formula/src/engine/utils/generate-ast-node.ts
+++ b/packages/engine-formula/src/engine/utils/generate-ast-node.ts
@@ -28,7 +28,7 @@ import { type BaseAstNode, ErrorNode } from '../ast-node/base-ast-node';
const FORMULA_CACHE_LRU_COUNT = 5000;
-const FORMULA_AST_CACHE = new FormulaAstLRU<AstRootNode>(FORMULA_CACHE_LRU_COUNT);
+export const FORMULA_AST_CACHE = new FormulaAstLRU<AstRootNode>(FORMULA_CACHE_LRU_COUNT);
export function generateAstNode(unitId: string, formulaString: string, lexer: Lexer, astTreeBuilder: AstTreeBuilder, currentConfigService: IFormulaCurrentConfigService): AstRootNode {
// refOffsetX and refOffsetY are separated by -, otherwise x:1 y:10 will be repeated with x:11 y:0