Build your own AI office with Univer Office SDK. Bring editing, calculation, collaboration, and file processing into your product for people and AI agents. Built on an extensible open-source core.
TypeScript boardcollaborationdocdocxexceloffce365officepdfpptpptxpresentationsdksheetslidesspreadsheetuniverwordwordprocessorworkspacexlsx
fix: change config hide statistic to show statistic (#4755)
lumixd2fc935bdd2e
diff --git a/packages/sheets-ui/src/controllers/config.schema.ts b/packages/sheets-ui/src/controllers/config.schema.tsindex 488a1a274a..7d0dd47c42 100644--- a/packages/sheets-ui/src/controllers/config.schema.ts+++ b/packages/sheets-ui/src/controllers/config.schema.ts@@ -21,7 +21,6 @@ export const SHEETS_UI_PLUGIN_CONFIG_KEY = 'sheets-ui.config';export const configSymbol = Symbol(SHEETS_UI_PLUGIN_CONFIG_KEY);-export const HIDE_STATUS_BAR_STATISTIC = Symbol('HIDE_STATUS_BAR_STATISTIC');export interface IUniverSheetsUIConfig {menu?: MenuConfig;disableAutoFocus?: true;@@ -38,14 +37,16 @@ export interface IUniverSheetsUIConfig {*/formulaBar?: boolean;+ statusBarStatistic?: boolean;+clipboardConfig?: {hidePasteOptions?: boolean;};- hideStatusBarStatistic?: boolean;}export const defaultPluginConfig: IUniverSheetsUIConfig = {formulaBar: true,+ statusBarStatistic: true,maxAutoHeightCount: 1000,};diff --git a/packages/sheets-ui/src/plugin.ts b/packages/sheets-ui/src/plugin.tsindex db428a7b03..77c12276d1 100644--- a/packages/sheets-ui/src/plugin.ts+++ b/packages/sheets-ui/src/plugin.ts@@ -30,7 +30,7 @@ import { CellAlertRenderController } from './controllers/cell-alert.controller';import { CellCustomRenderController } from './controllers/cell-custom-render.controller';import { SheetCheckboxController } from './controllers/checkbox.controller';import { SheetClipboardController } from './controllers/clipboard/clipboard.controller';-import { defaultPluginConfig, HIDE_STATUS_BAR_STATISTIC, SHEETS_UI_PLUGIN_CONFIG_KEY } from './controllers/config.schema';+import { defaultPluginConfig, SHEETS_UI_PLUGIN_CONFIG_KEY } from './controllers/config.schema';import { SheetsDefinedNameController } from './controllers/defined-name/defined-name.controller';import { DragRenderController } from './controllers/drag-render.controller';import { EditorDataSyncController } from './controllers/editor/data-sync.controller';@@ -117,9 +117,6 @@ export class UniverSheetsUIPlugin extends Plugin {this._configService.setConfig('menu', menu, { merge: true });}- if (this._config?.hideStatusBarStatistic) {- this._configService.setConfig(HIDE_STATUS_BAR_STATISTIC, true);- }this._configService.setConfig(SHEETS_UI_PLUGIN_CONFIG_KEY, rest);}diff --git a/packages/sheets-ui/src/views/status-bar/StatusBar.tsx b/packages/sheets-ui/src/views/status-bar/StatusBar.tsxindex 2d9be7840f..8a622d48bf 100644--- a/packages/sheets-ui/src/views/status-bar/StatusBar.tsx+++ b/packages/sheets-ui/src/views/status-bar/StatusBar.tsx@@ -15,13 +15,14 @@*/import type { Nullable } from '@univerjs/core';+import type { IUniverSheetsUIConfig } from '../../controllers/config.schema';import type { IStatusBarServiceStatus, StatusBarService } from '../../services/status-bar.service';import type { IStatisticItem } from './CopyableStatisticItem';import { debounce, IConfigService } from '@univerjs/core';import { clsx } from '@univerjs/design';import { useDependency } from '@univerjs/ui';import React, { useCallback, useEffect, useMemo, useState } from 'react';-import { HIDE_STATUS_BAR_STATISTIC } from '../../controllers/config.schema';+import { SHEETS_UI_PLUGIN_CONFIG_KEY } from '../../controllers/config.schema';import { IStatusBarService } from '../../services/status-bar.service';import { CopyableStatisticItem } from './CopyableStatisticItem';import styles from './index.module.less';@@ -31,7 +32,7 @@ const ROW_COUNT_THRESHOLD = 3;export const StatusBar = () => {const configService = useDependency(IConfigService);- const hideStatistic = configService.getConfig<boolean>(HIDE_STATUS_BAR_STATISTIC) || false;+ const showStatistic = configService.getConfig<IUniverSheetsUIConfig>(SHEETS_UI_PLUGIN_CONFIG_KEY)?.statusBarStatistic ?? true;const [isSingle, setIsSingle] = useState(window.innerWidth < SINGLE_MODE_WIDTH);@@ -49,7 +50,7 @@ export const StatusBar = () => {initialItems: IStatisticItem[],statusBarService: StatusBarService,isSingle: boolean,- hideStatistic: boolean+ showStatistic: boolean) => {const [statistics, setStatistics] = useState<IStatisticItem[]>(initialItems);const [show, setShow] = useState(true);@@ -88,12 +89,12 @@ export const StatusBar = () => {}, []);useEffect(() => {- if (hideStatistic) return;+ if (!showStatistic) return;const subscription = statusBarService.state$.subscribe(updateStatistics);return () => subscription.unsubscribe();- }, [hideStatistic, statusBarService, updateStatistics]);+ }, [showStatistic, statusBarService, updateStatistics]);return {statistics,@@ -106,7 +107,7 @@ export const StatusBar = () => {items,statusBarService,isSingle,- hideStatistic+ showStatistic);const handleResize = debounce(() => {const newSingleState = window.innerWidth < SINGLE_MODE_WIDTH;@@ -128,7 +129,7 @@ export const StatusBar = () => {rowCountThreshold: number,CopyableStatisticItem: React.ComponentType<IStatisticItem>) => {- if (hideStatistic) return null;+ if (!showStatistic) return null;const renderContent = React.useMemo(() => {if (showList.length > rowCountThreshold) {const doubleLineList = showList.reduce<IStatisticItem[][]>((acc, _, index) => {