Skip to content

Build your own AI office with Univer Office SDK. Bring editing, calculation, collaboration, and file processing into your product for people and AI agents. Built on an extensible open-source core.

fix(design): prevent popup flicker before initial position is calculated (#6726)

白熱de505b5156a1
diff --git a/packages/design/src/components/popup/Popup.tsx b/packages/design/src/components/popup/Popup.tsx
index 98a0fb4b19..1c0d66f5b8 100644
--- a/packages/design/src/components/popup/Popup.tsx
+++ b/packages/design/src/components/popup/Popup.tsx
@@ -15,13 +15,14 @@
*/
import type { ReactElement } from 'react';
-import { useContext, useEffect, useRef, useState } from 'react';
+import { useContext, useEffect, useLayoutEffect, useRef, useState } from 'react';
import { createPortal } from 'react-dom';
import { CSSTransition } from 'react-transition-group';
import { ConfigContext } from '../config-provider/ConfigProvider';
import './index.css';
const POPUP_POINTER_OFFSET = 2;
+const HIDDEN_POPUP_OFFSET: [number, number] = [-9999, -9999];
export interface IPopupProps {
children: ReactElement;
@@ -56,7 +57,7 @@ export function Popup(props: IPopupProps) {
const nodeRef = useRef(null);
- const [realOffset, setRealOffset] = useState<[number, number]>(offset);
+ const [realOffset, setRealOffset] = useState<[number, number]>(HIDDEN_POPUP_OFFSET);
const { mountContainer } = useContext(ConfigContext);
@@ -80,9 +81,9 @@ export function Popup(props: IPopupProps) {
return [x, y];
};
- useEffect(() => {
+ useLayoutEffect(() => {
if (!visible) {
- setRealOffset([-9999, -9999]);
+ setRealOffset(HIDDEN_POPUP_OFFSET);
return;
}