Skip to content

Build your own AI office with Univer Office SDK. Bring editing, calculation, collaboration, and file processing into your product for people and AI agents. Built on an extensible open-source core.

chore: remove useless parameter

Wenzhao Huecb6e677f6c4
diff --git a/packages/core/src/services/plugin/plugin-holder.ts b/packages/core/src/services/plugin/plugin-holder.ts
index 18e7375ccc..d72faaad2b 100644
--- a/packages/core/src/services/plugin/plugin-holder.ts
+++ b/packages/core/src/services/plugin/plugin-holder.ts
@@ -33,7 +33,6 @@ export class PluginHolder extends Disposable {
protected readonly _pluginRegistry = new PluginRegistry();
constructor(
- private readonly _immediateStart: boolean,
@ILogService protected readonly _logService: ILogService,
@Inject(Injector) protected readonly _injector: Injector,
@Inject(LifecycleService) protected readonly _lifecycleService: LifecycleService,
@@ -48,6 +47,7 @@ export class PluginHolder extends Disposable {
this._pluginStore.forEachPlugin((plugin) => plugin.dispose());
this._pluginStore.removePlugins();
this._pluginRegistry.removePlugins();
+ this._pluginRegistered.clear();
}
registerPlugin<T extends PluginCtor<Plugin>>(pluginCtor: T, config?: ConstructorParameters<T>[0]): void {
diff --git a/packages/core/src/services/plugin/plugin.service.ts b/packages/core/src/services/plugin/plugin.service.ts
index e5ead8d626..e64c3d4b3b 100644
--- a/packages/core/src/services/plugin/plugin.service.ts
+++ b/packages/core/src/services/plugin/plugin.service.ts
@@ -33,7 +33,7 @@ export class PluginService implements IDisposable {
constructor(
@Inject(Injector) private readonly _injector: Injector
) {
- this._pluginHolderForUniver = this._injector.createInstance(PluginHolder, true);
+ this._pluginHolderForUniver = this._injector.createInstance(PluginHolder);
this._pluginHolderForUniver.start();
}
@@ -71,7 +71,7 @@ export class PluginService implements IDisposable {
_ensurePluginHolderForType(type: UnitType): PluginHolder {
if (!this._pluginHoldersForTypes.has(type)) {
- const pluginHolder = this._injector.createInstance(PluginHolder, false);
+ const pluginHolder = this._injector.createInstance(PluginHolder);
this._pluginHoldersForTypes.set(type, pluginHolder);
return pluginHolder;
}