Skip to content

Local UI to run and train LLMs and diffusion models. Supports GGUF, MLX, Qwen3.8, DeepSeek-V4.1, MiniMax-H3, Gemma 4, FLUX and more.

Studio: warn that a Web share link from a remote Studio exposes its address (#12413)

Daniel Han1422bfc36e59
diff --git a/studio/frontend/src/features/model-picker/sharing/share-dialog.tsx b/studio/frontend/src/features/model-picker/sharing/share-dialog.tsx
index 7c3b77601e4..db678b8a9ae 100644
--- a/studio/frontend/src/features/model-picker/sharing/share-dialog.tsx
+++ b/studio/frontend/src/features/model-picker/sharing/share-dialog.tsx
@@ -115,10 +115,10 @@ export function ShareRunConfigDialog({
const [includeVariant, setIncludeVariant] = useState(
shareableModel && Boolean(target.ggufVariant),
);
- const [destination, setDestination] = useState(() =>
- !isTauri && loopbackHostname.test(window.location.hostname)
- ? "browser"
- : "desktop",
+ const remoteAddress =
+ !isTauri && !loopbackHostname.test(window.location.hostname);
+ const [destination, setDestination] = useState(
+ isTauri || remoteAddress ? "desktop" : "browser",
);
const [selected, setSelected] = useState<Set<SharedConfigKey>>(
() =>
@@ -295,10 +295,18 @@ export function ShareRunConfigDialog({
</>
)}
</div>
- <p className="text-ui-12 leading-snug text-muted-foreground">
- {destination === "browser"
- ? "This link contains your Unsloth Web address. Recipients need access to that address. A localhost address opens Unsloth Web on their own computer."
- : "The recipient needs Unsloth Desktop installed."}
+ <p
+ className={
+ destination === "browser" && remoteAddress
+ ? "text-ui-12 leading-snug text-amber-600 dark:text-amber-500"
+ : "text-ui-12 leading-snug text-muted-foreground"
+ }
+ >
+ {destination !== "browser"
+ ? "The recipient needs Unsloth Desktop installed."
+ : remoteAddress
+ ? "This link contains this Studio's network address. Anyone with it and your password can sign in and control this computer. Share it only with people who should use this Studio; otherwise share a Desktop link."
+ : "This link contains your Unsloth Web address. Recipients need access to that address. A localhost address opens Unsloth Web on their own computer."}
</p>
</div>
<div className="space-y-1.5">
diff --git a/studio/frontend/tests/share-run-configs.editor.test.ts b/studio/frontend/tests/share-run-configs.editor.test.ts
index 3b347851c89..3179dfe3c98 100644
--- a/studio/frontend/tests/share-run-configs.editor.test.ts
+++ b/studio/frontend/tests/share-run-configs.editor.test.ts
@@ -360,6 +360,10 @@ test("local sharing keeps the recipient's quant unless the sender includes it",
test("share dialog defaults to Web only on loopback addresses", () => {
const previous = window.location;
try {
+ for (const address of ["http://localhost:8888", "http://192.168.1.20:8888"]) {
+ Object.assign(window, { location: new URL(`${address}/chat`) });
+ assert.equal(new URL(shareDialog(D)().link).protocol, "unsloth:", address);
+ }
for (const [address, destination] of [
["http://localhost:8888", "browser"],
["http://127.10.20.30:8888", "browser"],
@@ -378,6 +382,12 @@ test("share dialog defaults to Web only on loopback addresses", () => {
const explicit = new URL(render().link);
assert.equal(explicit.origin, new URL(address).origin);
assert.equal(explicit.search, "?run=1");
+ const note = text(render().tree);
+ assert.equal(
+ note.includes("Anyone with it and your password can sign in"),
+ destination === "desktop",
+ address,
+ );
}
} finally {
Object.assign(window, { location: previous });