Skip to content

Local UI to run and train LLMs and diffusion models. Supports GGUF, MLX, Qwen3.8, DeepSeek-V4.1, MiniMax-H3, Gemma 4, FLUX and more.

Installer differential: ignore winget's partly filled download bars (#13172)

Daniel Han143bc759602e
diff --git a/.github/scripts/compare_installer_evidence.py b/.github/scripts/compare_installer_evidence.py
index 72ccef5604d..d7265259501 100644
--- a/.github/scripts/compare_installer_evidence.py
+++ b/.github/scripts/compare_installer_evidence.py
@@ -211,12 +211,22 @@ def _apply_value_normalisers(line: str) -> str:
# reads, and a line with any other text on it (" - Packages") still compares.
_SPINNER_FRAMES = frozenset("-\\|/")
+# winget's download bar, the same way: it redraws a partly filled bar ("█████▒▒▒▒▒ 42%" or
+# "<size> / <size>") as the bytes arrive, and how many partial frames land in the log depends on the
+# network. Only a partial frame (one with a "▒" left) is dropped; the full bar a finished download
+# ends on still compares, as does any line with other text on it.
+_PARTIAL_PROGRESS_FRAME = re.compile(r"[█▒]*▒[█▒]*\s+(?:<percent>|<size> / <size>)")
+
def normalise_transcript(text: str) -> list[str]:
lines = []
for raw in text.splitlines():
line = normalise_line(raw)
- if not line.strip() or line.strip() in _SPINNER_FRAMES:
+ if (
+ not line.strip()
+ or line.strip() in _SPINNER_FRAMES
+ or _PARTIAL_PROGRESS_FRAME.fullmatch(line.strip())
+ ):
continue
# Runner-injected noise, and ONLY what the runner injects. These carry the workflow's own
# group names and the side's SHA, so they differ between sides for nothing to do with the
diff --git a/tests/python/test_installer_differential_comparer.py b/tests/python/test_installer_differential_comparer.py
index 86bd47a0c0f..bd3664d1a5f 100644
--- a/tests/python/test_installer_differential_comparer.py
+++ b/tests/python/test_installer_differential_comparer.py
@@ -220,6 +220,31 @@ def test_winget_spinner_frames_do_not_fail(tmp_path: Path) -> None:
assert result.returncode == 0, f"spinner frames failed the lane: {result.stdout}"
+def test_winget_partial_progress_frames_do_not_fail(tmp_path: Path) -> None:
+ """How many partly filled download bars winget leaves in the log depends on the network."""
+ full = " ██████████████████████████████ 17.2 MB / 17.2 MB"
+ lines = BASELINE.split("\n")
+ base_bars = [" █████████▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒ 5.1 MB / 17.2 MB", full]
+ head_bars = [
+ " ██████▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒ 3.0 MB / 17.2 MB",
+ " █████████████████████▒▒▒▒▒▒▒▒▒ 70%",
+ full,
+ ]
+ base = _write(tmp_path / "base", transcript = "\n".join(lines[:1] + base_bars + lines[1:]))
+ head = _write(tmp_path / "head", transcript = "\n".join(lines[:1] + head_bars + lines[1:]))
+ result = _run(base, head)
+ assert result.returncode == 0, f"partial progress frames failed the lane: {result.stdout}"
+
+
+def test_a_download_that_never_finishes_still_compares(tmp_path: Path) -> None:
+ """The full bar a finished download ends on is kept, so losing it is reported."""
+ lines = BASELINE.split("\n")
+ full = " ██████████████████████████████ 17.2 MB / 17.2 MB"
+ base = _write(tmp_path / "base", transcript = "\n".join(lines[:1] + [full] + lines[1:]))
+ head = _write(tmp_path / "head", transcript = "\n".join(lines[:1] + lines[1:]))
+ assert _run(base, head).returncode == 2
+
+
def test_a_dash_line_with_text_still_compares(tmp_path: Path) -> None:
"""Only a bare frame is dropped: winget's own " - Packages" list is output the user reads."""
base = _write(tmp_path / "base", transcript = BASELINE + "\n - Packages")