Skip to content

Local UI to run and train LLMs and diffusion models. Supports GGUF, MLX, Qwen3.8, DeepSeek-V4.1, MiniMax-H3, Gemma 4, FLUX and more.

Studio: launch full-access tool processes with start_new_session instead of a setsid pre-exec (#15595)

Daniel Han1b0698430ef1
diff --git a/studio/backend/core/inference/tools.py b/studio/backend/core/inference/tools.py
index bc59dbb6ec8..c1f549c11e0 100644
--- a/studio/backend/core/inference/tools.py
+++ b/studio/backend/core/inference/tools.py
@@ -9095,7 +9095,12 @@ def _apply_prepared_launch(prepared, popen_kwargs: dict) -> dict:
popen_kwargs["cwd"] = prepared.workdir
popen_kwargs["env"] = prepared.env
if sys.platform != "win32":
- popen_kwargs["preexec_fn"] = prepared.preexec_fn
+ if prepared.preexec_fn is _bypass_preexec:
+ # setsid in C: a Python pre-exec forks the whole server instead of vfork.
+ popen_kwargs.pop("preexec_fn", None)
+ popen_kwargs["start_new_session"] = True
+ else:
+ popen_kwargs["preexec_fn"] = prepared.preexec_fn
popen_kwargs["close_fds"] = prepared.close_fds
if prepared.pass_fds:
# Empty for every fallback, so Windows never sees a kwarg it rejects.
diff --git a/studio/backend/tests/test_bypass_permissions.py b/studio/backend/tests/test_bypass_permissions.py
index 4eebca14e36..7738979e7fa 100644
--- a/studio/backend/tests/test_bypass_permissions.py
+++ b/studio/backend/tests/test_bypass_permissions.py
@@ -100,8 +100,9 @@ def captured_popen(monkeypatch):
cap = {}
def fake_popen(cmd, **kwargs):
- cap["cmd"] = cmd
- cap["kwargs"] = kwargs
+ # First call only: on macOS a later `ps` Popen would replace the tool launch.
+ cap.setdefault("cmd", cmd)
+ cap.setdefault("kwargs", kwargs)
return _FakeProc()
monkeypatch.setattr(tools.subprocess, "Popen", fake_popen)
@@ -142,7 +143,8 @@ def test_python_bypass_uses_bypass_preexec_and_bypass_env(captured_popen, monkey
monkeypatch.setenv("HOSTVAR", "benign-xyz")
monkeypatch.setenv("HF_TOKEN", "secret-abc")
_python_exec("print(1)", None, 5, "t", disable_sandbox = True)
- assert captured_popen["kwargs"]["preexec_fn"] is tools._bypass_preexec
+ assert captured_popen["kwargs"]["start_new_session"] is True
+ assert "preexec_fn" not in captured_popen["kwargs"]
env = captured_popen["kwargs"]["env"]
assert env.get("HOSTVAR") == "benign-xyz"
assert env.get("PYTHONIOENCODING") == "utf-8"
@@ -168,7 +170,8 @@ def test_bash_blocklist_skipped_when_bypassed(captured_popen):
def test_bash_bypass_uses_bypass_preexec(captured_popen, monkeypatch):
monkeypatch.delenv("PYTHONIOENCODING", raising = False)
_bash_exec("echo hi", None, 5, "t", disable_sandbox = True)
- assert captured_popen["kwargs"]["preexec_fn"] is tools._bypass_preexec
+ assert captured_popen["kwargs"]["start_new_session"] is True
+ assert "preexec_fn" not in captured_popen["kwargs"]
assert "PYTHONIOENCODING" not in captured_popen["kwargs"]["env"]
@@ -669,3 +672,16 @@ def test_anthropic_request_model_bypass_default_false():
assert AnthropicMessagesRequest.model_fields["bypass_permissions"].default is False
req = AnthropicMessagesRequest(model = "x", messages = [], max_tokens = 8)
assert bool(req.bypass_permissions) is False
+
+
+@_POSIX_ONLY
+def test_bypass_child_leads_its_own_session():
+ # Every kill path is killpg based, so the bypass child must not share the server's session.
+ out = _python_exec(
+ "import os; print('LEADER=' + str(os.getsid(0) == os.getpid() == os.getpgid(0)))",
+ None,
+ 30,
+ "test-bypass-session",
+ disable_sandbox = True,
+ )
+ assert "LEADER=True" in out