Skip to content

Local UI to run and train LLMs and diffusion models. Supports GGUF, MLX, Qwen3.8, DeepSeek-V4.1, MiniMax-H3, Gemma 4, FLUX and more.

Studio: open the managed account folder browser on symlinked installs (#17321)

Nilay28b65cf9b7de
diff --git a/studio/backend/routes/models.py b/studio/backend/routes/models.py
index 370d4e0f8b2..b1c13eb77b4 100644
--- a/studio/backend/routes/models.py
+++ b/studio/backend/routes/models.py
@@ -319,7 +319,7 @@ from models.responses import (
VisionCheckResponse,
EmbeddingCheckResponse,
)
-from utils.paths.path_utils import is_appledouble_metadata
+from utils.paths.path_utils import is_appledouble_metadata, is_network_or_device_path
router = APIRouter()
logger = get_logger(__name__)
@@ -1826,6 +1826,16 @@ def _resolve_browse_target(path: Optional[str], allowed_roots: list[Path]) -> Pa
seen_roots.add(key)
resolved_roots.append(resolved)
+ if not any(_browse_relative_parts(requested_path, root) is not None for root in resolved_roots):
+ # Spelled through a symlinked root (moved install, linked $HOME): matches only once resolved.
+ if not is_network_or_device_path(requested_path):
+ try:
+ real = os.path.realpath(requested_path)
+ except (OSError, ValueError):
+ real = requested_path
+ if not is_network_or_device_path(real):
+ requested_path = real
+
for root in resolved_roots:
parts = _browse_relative_parts(requested_path, root)
if parts is None:
diff --git a/studio/backend/tests/multi_account/test_browse_folders_managed.py b/studio/backend/tests/multi_account/test_browse_folders_managed.py
index 00bbac24323..3197eda32e7 100644
--- a/studio/backend/tests/multi_account/test_browse_folders_managed.py
+++ b/studio/backend/tests/multi_account/test_browse_folders_managed.py
@@ -3,13 +3,23 @@
"""A managed account's folder browser is confined to its workspace, suggestions included."""
+import pytest
+
+import storage.studio_db as studio_db
from routes import models as models_routes
from utils.account_context import AccountContext, run_as
+from utils.paths import storage_roots
from utils.paths.storage_roots import workspace_root
ALICE = AccountContext("a" * 32, "alice")
[email protected](autouse = True)
+def _denylist_inert(monkeypatch):
+ # macOS tmp_path is under denied /private/var.
+ monkeypatch.setattr(studio_db, "is_denied_system_path", lambda _p: False)
+
+
def test_managed_browse_suggests_only_the_workspace(isolated_auth):
root = run_as(ALICE, workspace_root)
(root / "models").mkdir(parents = True)
@@ -18,3 +28,20 @@ def test_managed_browse_suggests_only_the_workspace(isolated_auth):
assert response.parent is None
assert response.suggestions == [str(root.resolve())]
assert [entry.name for entry in response.entries] == ["models"]
+
+
+def test_managed_browse_opens_when_the_install_root_is_a_symlink(
+ isolated_auth, tmp_path, monkeypatch
+):
+ relocated = tmp_path / "relocated"
+ relocated.mkdir()
+ linked = tmp_path / "linked"
+ linked.symlink_to(relocated, target_is_directory = True)
+ monkeypatch.setattr(storage_roots, "studio_root", lambda: linked)
+ root = run_as(ALICE, workspace_root)
+ (root / "models").mkdir(parents = True)
+ response = run_as(ALICE, models_routes.browse_folders, None, False, "alice")
+ assert response.current == str(root.resolve())
+ assert [entry.name for entry in response.entries] == ["models"]
+ nested = run_as(ALICE, models_routes.browse_folders, str(root / "models"), False, "alice")
+ assert nested.current == str((root / "models").resolve())
diff --git a/studio/backend/tests/test_browse_folders_route.py b/studio/backend/tests/test_browse_folders_route.py
index 9271db58822..4109058299f 100644
--- a/studio/backend/tests/test_browse_folders_route.py
+++ b/studio/backend/tests/test_browse_folders_route.py
@@ -89,3 +89,29 @@ def test_resolve_browse_target_allows_backslash_in_posix_segment(tmp_path):
resolved = models_route._resolve_browse_target(str(target), [allowed])
assert resolved == target.resolve()
+
+
+def test_resolve_browse_target_accepts_a_path_spelled_through_a_symlinked_root(tmp_path):
+ real = tmp_path / "real"
+ (real / "models").mkdir(parents = True)
+ linked = tmp_path / "linked"
+ linked.symlink_to(real, target_is_directory = True)
+
+ resolved = models_route._resolve_browse_target(str(linked / "models"), [real.resolve()])
+
+ assert resolved == (real / "models").resolve()
+
+
+def test_resolve_browse_target_symlinked_root_spelling_cannot_escape(tmp_path):
+ real = tmp_path / "real"
+ real.mkdir()
+ outside = tmp_path / "outside"
+ outside.mkdir()
+ (real / "out").symlink_to(outside, target_is_directory = True)
+ linked = tmp_path / "linked"
+ linked.symlink_to(real, target_is_directory = True)
+
+ with pytest.raises(HTTPException) as exc_info:
+ models_route._resolve_browse_target(str(linked / "out"), [real.resolve()])
+
+ assert exc_info.value.status_code == 403