Skip to content

Local UI to run and train LLMs and diffusion models. Supports GGUF, MLX, Qwen3.8, DeepSeek-V4.1, MiniMax-H3, Gemma 4, FLUX and more.

Backend tests: importorskip the unsloth submodule a test uses, not the stubbable package (#16898)

Daniel Han2bfb19747f22
diff --git a/studio/backend/tests/test_backend_tests_stub_heavy_imports.py b/studio/backend/tests/test_backend_tests_stub_heavy_imports.py
index 950b0f915eb..38a3d14f03c 100644
--- a/studio/backend/tests/test_backend_tests_stub_heavy_imports.py
+++ b/studio/backend/tests/test_backend_tests_stub_heavy_imports.py
@@ -1596,3 +1596,37 @@ def test_only_an_installed_stub_counts_as_stubbing():
):
assert not _stubs_before(_parse(source), 1), source
assert _is_offender(source, heavy), source
+
+
+def _bare_unsloth_importorskips(tree: ast.Module) -> int:
+ return sum(
+ isinstance(node, ast.Call)
+ and isinstance(node.func, ast.Attribute)
+ and node.func.attr == "importorskip"
+ and bool(node.args)
+ and isinstance(node.args[0], ast.Constant)
+ and node.args[0].value == "unsloth"
+ for node in ast.walk(tree)
+ )
+
+
+def test_no_test_importorskips_bare_unsloth():
+ """Files stub unsloth as a plain module, so importorskip("unsloth") returns the stub and a later
+ `from unsloth.models import ...` fails instead of skipping. importorskip the submodule."""
+ offenders = sorted(
+ path.name
+ for path in _TESTS_DIR.glob("test_*.py")
+ if _bare_unsloth_importorskips(_parse(path.read_text(encoding = "utf-8")))
+ )
+ assert (
+ not offenders
+ ), f"importorskip a submodule (e.g. 'unsloth.models.loader'), not the bare package: {offenders}"
+ assert (
+ _bare_unsloth_importorskips(_parse('import pytest\npytest.importorskip("unsloth")\n')) == 1
+ )
+ assert (
+ _bare_unsloth_importorskips(
+ _parse('import pytest\npytest.importorskip("unsloth.models")\n')
+ )
+ == 0
+ )
diff --git a/studio/backend/tests/test_load_download_repos_mapper.py b/studio/backend/tests/test_load_download_repos_mapper.py
index 06d57f8bd12..67116c14f82 100644
--- a/studio/backend/tests/test_load_download_repos_mapper.py
+++ b/studio/backend/tests/test_load_download_repos_mapper.py
@@ -7,8 +7,8 @@ import pytest
def test_unmapped_lora_base_skips_the_remote_mapper(monkeypatch):
- pytest.importorskip("unsloth")
- from unsloth.models import loader_utils
+ # Not importorskip("unsloth"): an earlier file in the worker may have stubbed it as a plain module.
+ loader_utils = pytest.importorskip("unsloth.models.loader_utils")
from core.inference import worker
fetches = []
@@ -39,7 +39,7 @@ def test_unmapped_lora_base_skips_the_remote_mapper(monkeypatch):
name = next(iter(loader_utils.FLOAT_TO_INT_MAPPER))
mapped = SimpleNamespace(identifier = "owner/adapter", base_model = name)
- from unsloth.models import loader
+ loader = pytest.importorskip("unsloth.models.loader")
expected = loader_utils.get_model_name(name, load_in_4bit = loader.ALLOW_BITSANDBYTES)
if not loader.ALLOW_PREQUANTIZED_MODELS:
@@ -51,8 +51,8 @@ def test_unmapped_lora_base_skips_the_remote_mapper(monkeypatch):
def test_unmapped_prequantized_base_still_lists_the_stripped_repo(monkeypatch):
- pytest.importorskip("unsloth")
- from unsloth.models import loader, loader_utils
+ loader = pytest.importorskip("unsloth.models.loader")
+ loader_utils = pytest.importorskip("unsloth.models.loader_utils")
from core.inference import worker
monkeypatch.setattr(loader_utils, "_get_new_mapper", lambda: ({}, {}, {}, {}, {}))