Local UI to run and train LLMs and diffusion models. Supports GGUF, MLX, Qwen3.8, DeepSeek-V4.1, MiniMax-H3, Gemma 4, FLUX and more.
Python agentaichatgptdeepseekfine-tuninggemmaimage-generationllamallmllmsopenaipythonqwenreinforcement-learningself-hostedstable-diffusiontext-to-speechttsuiunsloth
unsloth studio stop: return as soon as the server exits instead of on the next half-second step (#17283)
Daniel Han64795e570e48
diff --git a/unsloth_cli/commands/studio.py b/unsloth_cli/commands/studio.pyindex 9cc740c24a4..284e2357300 100644--- a/unsloth_cli/commands/studio.py+++ b/unsloth_cli/commands/studio.py@@ -3363,10 +3363,13 @@ def stop():raise typer.Exit(0)pending = list(signalled)- for _ in range(10):+ # 5 s budget; POSIX checks are one kill(pid, 0), Windows checks may spawn tasklist.+ step = 0.5 if sys.platform == "win32" else 0.05+ for attempt in range(round(5 / step) + 1):if not pending:break- time.sleep(0.5)+ if attempt:+ time.sleep(step)for entry in list(pending):pid, paths = entryif not _pid_alive(pid):diff --git a/unsloth_cli/tests/test_studio_stop.py b/unsloth_cli/tests/test_studio_stop.pyindex 9d0c107a1b5..6da875d3cb3 100644--- a/unsloth_cli/tests/test_studio_stop.py+++ b/unsloth_cli/tests/test_studio_stop.py@@ -539,3 +539,66 @@ def test_stop_drops_a_record_whose_stable_identity_proves_pid_reuse(monkeypatch,assert result.exit_code == 0, result.outputassert killed == []assert not record.exists()+++def test_stop_does_not_sleep_when_the_server_is_already_gone(monkeypatch, tmp_path):+ studio_mod = _studio()+ monkeypatch.setattr(studio_mod, "STUDIO_HOME", tmp_path)+ monkeypatch.setattr(studio_mod, "_PID_FILE", tmp_path / "studio.pid")+ sleeps = []+ monkeypatch.setattr(studio_mod.time, "sleep", sleeps.append)+ live = {8550}+ monkeypatch.setattr(studio_mod, "_pid_alive", lambda pid: pid in live)+ monkeypatch.setattr(studio_mod, "_pid_is_studio_server", lambda pid, created_times = (): True)+ monkeypatch.setattr(studio_mod.os, "kill", lambda pid, sig: live.discard(pid))+ monkeypatch.setattr(sys, "platform", "linux")+ _write_pid(tmp_path, "studio-8901-8550.pid", 8550)++ result = _run_stop(studio_mod)++ assert result.exit_code == 0, result.output+ assert "stopped (1)" in result.output+ assert sleeps == []+ assert not (tmp_path / "studio-8901-8550.pid").exists()+++ "platform, steps", [("linux", [0.05] * 100), ("darwin", [0.05] * 100), ("win32", [0.5] * 10)]+)+def test_stop_waits_the_same_five_seconds_for_a_server_that_keeps_running(+ monkeypatch, tmp_path, platform, steps+):+ studio_mod = _studio()+ monkeypatch.setattr(studio_mod, "STUDIO_HOME", tmp_path)+ monkeypatch.setattr(studio_mod, "_PID_FILE", tmp_path / "studio.pid")+ sleeps = []+ monkeypatch.setattr(studio_mod.time, "sleep", sleeps.append)+ monkeypatch.setattr(studio_mod, "_pid_alive", lambda pid: True)+ monkeypatch.setattr(studio_mod, "_pid_is_studio_server", lambda pid, created_times = (): True)+ monkeypatch.setattr(studio_mod, "_signal_stop", lambda pid: None)+ monkeypatch.setattr(sys, "platform", platform)+ _write_pid(tmp_path, "studio-8901-8550.pid", 8550)++ result = _run_stop(studio_mod)++ assert sleeps == steps+ assert "is shutting down" in result.output+++def test_stop_returns_within_one_short_step_once_a_posix_server_exits(monkeypatch, tmp_path):+ studio_mod = _studio()+ monkeypatch.setattr(studio_mod, "STUDIO_HOME", tmp_path)+ monkeypatch.setattr(studio_mod, "_PID_FILE", tmp_path / "studio.pid")+ sleeps = []+ monkeypatch.setattr(studio_mod.time, "sleep", sleeps.append)+ monkeypatch.setattr(studio_mod, "_pid_alive", lambda pid: len(sleeps) < 3)+ monkeypatch.setattr(studio_mod, "_pid_is_studio_server", lambda pid, created_times = (): True)+ monkeypatch.setattr(studio_mod, "_signal_stop", lambda pid: None)+ monkeypatch.setattr(sys, "platform", "linux")+ _write_pid(tmp_path, "studio-8901-8550.pid", 8550)++ result = _run_stop(studio_mod)++ assert result.exit_code == 0, result.output+ assert sleeps == [0.05] * 3+ assert "stopped (1)" in result.output