Local UI to run and train LLMs and diffusion models. Supports GGUF, MLX, Qwen3.8, DeepSeek-V4.1, MiniMax-H3, Gemma 4, FLUX and more.
Python agentaichatgptdeepseekfine-tuninggemmaimage-generationllamallmllmsopenaipythonqwenreinforcement-learningself-hostedstable-diffusiontext-to-speechttsuiunsloth
Release: stop publishing standalone signed scripts (#11123)
Wasim Yousef Said82a983c6510a
diff --git a/.github/workflows/release-desktop.yml b/.github/workflows/release-desktop.ymlindex 5b0391f8d1e..2ee647a7095 100644--- a/.github/workflows/release-desktop.yml+++ b/.github/workflows/release-desktop.yml@@ -305,26 +305,11 @@ jobs:sys.exit(f'Release {tag} is a prerelease; GitHub cannot mark it latest.')prefix = 'Unsloth-Desktop-'- # The signed scripts are uploaded after the bundles and without --clobber, so a name- # that already exists would fail that step with the bundles and manifest already- # public. They belong in the same pre-flight guard as the bundles, not in a later- # check that can only report a release which is already half replaced.- script_assets = {- 'install.ps1',- 'setup.ps1',- 'uninstall.ps1',- 'install.sh',- 'setup.sh',- 'uninstall.sh',- 'setup.bat',- 'SHA256SUMS.txt',- }clashing = sorted(asset['name']for asset in release.get('assets', [])if str(asset.get('name', '')).startswith(prefix)or asset.get('name') == 'latest.json'- or asset.get('name') in script_assets)if clashing:@@ -1159,85 +1144,6 @@ jobs:Write-Host "install.ps1 -> $($sig.Status) $($sig.SignerCertificate.Subject)"if ($sig.Status -ne 'Valid') { Write-Host "::error::install.ps1 is $($sig.Status) after signing"; exit 1 }- # setup.ps1 and uninstall.ps1 are not bundle resources, so users only get them unsigned from- # a clone or raw.githubusercontent. Sign copies here and publish them as release assets.- # Copies, because signing them in place would append a signature block to files later steps- # still read; install.ps1 is the exception, signed in place above because the bundler packs it.- # .sh and .bat cannot be Authenticode signed (no subject interface package, and Windows never- # checks a batch file), so they get a published digest instead.- - name: Sign the shipped scripts for release- if: matrix.platform == 'windows-latest'- shell: pwsh- env:- AZURE_CLIENT_ID: ${{ secrets.AZURE_CLIENT_ID }}- AZURE_CLIENT_SECRET: ${{ secrets.AZURE_CLIENT_SECRET }}- AZURE_TENANT_ID: ${{ secrets.AZURE_TENANT_ID }}- AZURE_TRUSTED_SIGNING_ACCOUNT_NAME: ${{ secrets.AZURE_TRUSTED_SIGNING_ACCOUNT_NAME }}- AZURE_CERTIFICATE_PROFILE_NAME: ${{ secrets.AZURE_CERTIFICATE_PROFILE_NAME }}- run: |- $ErrorActionPreference = 'Stop'- $stage = Join-Path $env:RUNNER_TEMP 'release-scripts'- New-Item -ItemType Directory -Force -Path $stage | Out-Null-- # install.ps1 was signed in place by the step above; copy it rather than sign it twice.- Copy-Item -LiteralPath (Resolve-Path 'install.ps1').Path -Destination (Join-Path $stage 'install.ps1')-- $toSign = @(- @{ Source = 'studio/setup.ps1'; Name = 'setup.ps1' }- @{ Source = 'scripts/uninstall.ps1'; Name = 'uninstall.ps1' }- )- foreach ($item in $toSign) {- $target = Join-Path $stage $item.Name- Copy-Item -LiteralPath (Resolve-Path $item.Source).Path -Destination $target- studio/src-tauri/windows/sign-with-trusted-signing.ps1 -Path $target- if ($LASTEXITCODE -ne 0) {- Write-Host "::error::could not sign $($item.Source) (exit $LASTEXITCODE)"- exit 1- }- }-- # Verify every staged .ps1, the earlier one included: a release must never carry a- # script whose signature does not check out on the machine that produced it.- foreach ($file in (Get-ChildItem -LiteralPath $stage -Filter '*.ps1')) {- $sig = Get-AuthenticodeSignature $file.FullName- Write-Host "$($file.Name) -> $($sig.Status) $($sig.SignerCertificate.Subject)"- if ($sig.Status -ne 'Valid') {- Write-Host "::error::$($file.Name) is $($sig.Status) after signing"- exit 1- }- }-- # Unsignable, but still published so the digests below describe the whole set.- $asIs = @(- @{ Source = 'install.sh'; Name = 'install.sh' }- @{ Source = 'studio/setup.sh'; Name = 'setup.sh' }- @{ Source = 'studio/setup.bat'; Name = 'setup.bat' }- @{ Source = 'scripts/uninstall.sh'; Name = 'uninstall.sh' }- )- foreach ($item in $asIs) {- Copy-Item -LiteralPath (Resolve-Path $item.Source).Path -Destination (Join-Path $stage $item.Name)- }-- # Two spaces then the name, the form `sha256sum -c` accepts unmodified.- $sums = foreach ($file in (Get-ChildItem -LiteralPath $stage -File | Sort-Object Name)) {- "{0} {1}" -f (Get-FileHash -LiteralPath $file.FullName -Algorithm SHA256).Hash.ToLowerInvariant(), $file.Name- }- $sumsPath = Join-Path $stage 'SHA256SUMS.txt'- [System.IO.File]::WriteAllText($sumsPath, (($sums -join "`n") + "`n"), (New-Object System.Text.UTF8Encoding($false)))- Get-Content -LiteralPath $sumsPath | Write-Host-- # Deliberately not named desktop-release-*: the publish job merges that pattern into one- # directory and validates it against an exact bundle name list, which these would break.- - name: Upload signed scripts- if: matrix.platform == 'windows-latest'- uses: actions/upload-artifact@043fb46d1a93c77aae656e7c1c64a875d1fc6a0a # v7.0.1- with:- name: release-scripts-signed- path: ${{ runner.temp }}/release-scripts/*- if-no-files-found: error- compression-level: 0- retention-days: 1-- name: Build Windows appid: build_windowsif: matrix.platform == 'windows-latest'@@ -1957,26 +1863,11 @@ jobs:sys.exit(f'Release {tag} is a prerelease; GitHub cannot mark it latest.')prefix = 'Unsloth-Desktop-'- # The signed scripts are uploaded after the bundles and without --clobber, so a name- # that already exists would fail that step with the bundles and manifest already- # public. They belong in the same pre-flight guard as the bundles, not in a later- # check that can only report a release which is already half replaced.- script_assets = {- 'install.ps1',- 'setup.ps1',- 'uninstall.ps1',- 'install.sh',- 'setup.sh',- 'uninstall.sh',- 'setup.bat',- 'SHA256SUMS.txt',- }clashing = sorted(asset['name']for asset in release.get('assets', [])if str(asset.get('name', '')).startswith(prefix)or asset.get('name') == 'latest.json'- or asset.get('name') in script_assets)if clashing:@@ -2089,35 +1980,6 @@ jobs:set -euo pipefailgh release upload "$DESKTOP_RELEASE_TAG" "$RUNNER_TEMP/latest.json"- # After the manifest: the scripts are secondary to the update contract, and a failure here- # must not leave bundles published with no latest.json, the state that stops every updater- # client. Own directory too, since the asset set validated earlier is the bundle contract.- - name: Download signed scripts- if: ${{ !inputs.draft }}- uses: actions/download-artifact@3e5f45b2cfb9172054b4087a40e8e0b5a5461e7c # v8.0.1- with:- name: release-scripts-signed- path: ${{ runner.temp }}/release-scripts-- - name: Publish signed scripts- if: ${{ !inputs.draft }}- shell: bash- env:- GH_TOKEN: ${{ github.token }}- run: |- set -euo pipefail- script_assets=()- for asset in "$RUNNER_TEMP/release-scripts"/*; do- script_assets+=("$asset")- done- if [[ ${#script_assets[@]} -eq 0 ]]; then- echo "::error::no signed scripts were staged"- exit 1- fi- # No --clobber, matching the bundle upload above: a re-run must fail rather than quietly- # replace bytes whose digest has already been published.- gh release upload "$DESKTOP_RELEASE_TAG" "${script_assets[@]}"-- name: Download versioned updater metadataif: ${{ !inputs.draft }}shell: bashdiff --git a/tests/security/test_release_desktop_integrity.py b/tests/security/test_release_desktop_integrity.pyindex 30255d6340a..6756b1e94ad 100644--- a/tests/security/test_release_desktop_integrity.py+++ b/tests/security/test_release_desktop_integrity.py@@ -66,9 +66,7 @@ if [ "$1" = "api" ]; thenprintf 'HTTP/2.0 %s Test Response\n' "$status"fiif [ "$status" = "200" ]; then- if [ -n "${TARGET_ASSET_NAMES:-}" ]; then- printf '{"tag_name":"%s","draft":false,"assets":[{"name":"%s"}]}\n' "$DESKTOP_RELEASE_TAG" "$TARGET_ASSET_NAMES"- elif [ "$TARGET_HAS_DESKTOP_ASSETS" = "1" ]; then+ if [ "$TARGET_HAS_DESKTOP_ASSETS" = "1" ]; thenprintf '{"tag_name":"%s","draft":false,"assets":[{"name":"latest.json"}]}\n' "$DESKTOP_RELEASE_TAG"elseprintf '{"tag_name":"%s","draft":false,"assets":[]}\n' "$DESKTOP_RELEASE_TAG"@@ -348,35 +346,13 @@ def test_release_uploads_never_clobber_or_mutate_the_legacy_channel():uploads = _upload_commands(_workflow())versioned = [line for line in uploads if "$DESKTOP_RELEASE_TAG" in line]channel = [line for line in uploads if "desktop-latest" in line]- # The bundles, the signed scripts, and the updater manifest. The count is pinned so a new- # upload has to be added here deliberately rather than appearing unnoticed.- assert len(versioned) == 3, uploads+ assert len(versioned) == 2, uploadsassert channel == [], uploadsfor line in versioned:assert "--clobber" not in line, line-def test_an_existing_script_asset_blocks_republishing_the_release(tmp_path):- """A script name already on the release must fail the pre-flight, not the upload.-- The signed scripts are uploaded after the bundles and without --clobber. If the guard only- looked for Unsloth-Desktop-* and latest.json, a release already carrying install.ps1 would- pass it, the bundles would upload, and only then would the script upload fail, leaving the- release publicly half replaced.- """- for existing in ("install.ps1", "SHA256SUMS.txt", "uninstall.sh"):- result, _ = _run_step(- _workflow(),- "prepare-version",- "Guard against republishing an existing version",- tmp_path,- extra_env = {"TARGET_ASSET_NAMES": existing},- )- assert result.returncode == 1, f"{existing} did not block republishing: {result.stdout}"- assert existing in result.stderr, result.stderr--def test_any_existing_manifest_blocks_republishing_the_release(tmp_path):workflow = _workflow()result, _ = _run_step(