Local UI to run and train LLMs and diffusion models. Supports GGUF, MLX, Qwen3.8, DeepSeek-V4.1, MiniMax-H3, Gemma 4, FLUX and more.
Python agentaichatgptdeepseekfine-tuninggemmaimage-generationllamallmllmsopenaipythonqwenreinforcement-learningself-hostedstable-diffusiontext-to-speechttsuiunsloth
Studio: fix PDF previews after a PDF attachment is extracted (#12346)
Michael Han864fc1dd0093
diff --git a/studio/frontend/src/components/file-viewer/pdf-view.tsx b/studio/frontend/src/components/file-viewer/pdf-view.tsxindex f5954fc862b..e27714e06a2 100644--- a/studio/frontend/src/components/file-viewer/pdf-view.tsx+++ b/studio/frontend/src/components/file-viewer/pdf-view.tsx@@ -4,10 +4,11 @@import { Spinner } from "@/components/ui/spinner";import { useT } from "@/i18n";import { useVirtualizer } from "@tanstack/react-virtual";-import { createContext, useCallback, useContext, useEffect, useRef, useState } from "react";+import { createContext, useCallback, useContext, useEffect, useMemo, useRef, useState } from "react";import { Document, Page, pdfjs, usePageContext } from "react-pdf";import "react-pdf/dist/Page/TextLayer.css";import { queueParse } from "./parse-queue";+import { usePdfWorker } from "./use-pdf-worker";import { useWidth } from "./use-width";pdfjs.GlobalWorkerOptions.workerSrc = new URL(@@ -244,17 +245,20 @@ export default function PdfView({const [failed, setFailed] = useState<Blob | null>(null);const width = Math.max(200, Math.min(available, MAX_PAGE_WIDTH)) * scale;const slot = useParseSlot(firstPageOnly, file);+ const pdfWorker = usePdfWorker(slot.ready && failed !== file);+ const options = useMemo(() => (pdfWorker ? { ...PDF_OPTIONS, worker: pdfWorker.worker } : null), [pdfWorker]);if (failed === file) {return <p className="m-auto text-sm text-muted-foreground">{t("library.preview.cannotPreview")}</p>;}- if (!slot.ready) return <div className="size-full bg-muted/60" />;+ if (!slot.ready || !options) return <div className="size-full bg-muted/60" />;return (<div ref={setContainer} className="size-full overflow-auto bg-muted/60"><Documentfile={file}- options={PDF_OPTIONS}+ options={options}onLoadSuccess={(document) => {+ pdfWorker?.loaded.add(document);slot.release();setPdf(document);setPages(document.numPages);diff --git a/studio/frontend/src/components/file-viewer/use-pdf-worker.ts b/studio/frontend/src/components/file-viewer/use-pdf-worker.tsnew file mode 100644index 00000000000..0f0ba239bfc--- /dev/null+++ b/studio/frontend/src/components/file-viewer/use-pdf-worker.ts@@ -0,0 +1,38 @@+// SPDX-License-Identifier: AGPL-3.0-only+// Copyright 2026-present the Unsloth AI Inc. team. All rights reserved. See /studio/LICENSE.AGPL-3.0++import { useEffect, useState } from "react";+import { pdfjs } from "react-pdf";++export type PdfWorker = {+ worker: InstanceType<typeof pdfjs.PDFWorker>;+ loaded: Set<{ destroy(): Promise<void> }>;+};++/** Own worker per viewer: unpdf's globalThis.pdfjsWorker is another PDF.js version, which PDF.js would adopt. */+export function usePdfWorker(enabled: boolean): PdfWorker | null {+ const [state, setState] = useState<PdfWorker | null>(null);+ useEffect(() => {+ if (!enabled) return;+ const port = new Worker(pdfjs.GlobalWorkerOptions.workerSrc, {+ type: "module",+ });+ const next: PdfWorker = {+ worker: pdfjs.PDFWorker.create({ port }),+ loaded: new Set(),+ };+ // eslint-disable-next-line react-hooks/set-state-in-effect+ setState(next);+ return () => {+ setState(null);+ // PDF.js frees a document's fonts only once the worker answers its Terminate.+ void Promise.allSettled(+ [...next.loaded].map((doc) => doc.destroy()),+ ).then(() => {+ next.worker.destroy();+ port.terminate();+ });+ };+ }, [enabled]);+ return state;+}diff --git a/studio/frontend/src/features/rag/components/document-preview-sheet.tsx b/studio/frontend/src/features/rag/components/document-preview-sheet.tsxindex ee16e86a3dd..5f95692ae6b 100644--- a/studio/frontend/src/features/rag/components/document-preview-sheet.tsx+++ b/studio/frontend/src/features/rag/components/document-preview-sheet.tsx@@ -3,7 +3,14 @@"use client";-import { useCallback, useEffect, useLayoutEffect, useRef, useState } from "react";+import {+ useCallback,+ useEffect,+ useLayoutEffect,+ useMemo,+ useRef,+ useState,+} from "react";import { Document, Page, pdfjs } from "react-pdf";import {ChevronLeftIcon,@@ -12,6 +19,7 @@ import {ZoomOutIcon,} from "lucide-react";import { Spinner } from "@/components/ui/spinner";+import { usePdfWorker } from "@/components/file-viewer/use-pdf-worker";import {Sheet,@@ -79,6 +87,11 @@ function PdfPreview({const [error, setError] = useState<string | null>(null);const [grabbing, setGrabbing] = useState(false);const [scrollable, setScrollable] = useState(false);+ const pdfWorker = usePdfWorker(error === null);+ const options = useMemo(+ () => (pdfWorker ? { worker: pdfWorker.worker } : null),+ [pdfWorker],+ );const panRef = useRef<{x: number;y: number;@@ -114,11 +127,13 @@ function PdfPreview({}, []);const onLoad = useCallback(- ({ numPages: n }: { numPages: number }) => {+ (doc: { numPages: number; destroy(): Promise<void> }) => {+ const n = doc.numPages;+ pdfWorker?.loaded.add(doc);setNumPages(n);setPage((p) => Math.min(Math.max(p, 1), n));},- [],+ [pdfWorker],);const zoomBy = useCallback(@@ -204,33 +219,36 @@ function PdfPreview({: "",)}>- <Document- file={fileUrl}- onLoadSuccess={onLoad}- onLoadError={(e) => setError(e.message)}- loading={- <div className="flex items-center gap-2 p-6 text-sm text-muted-foreground">- <Spinner className="size-3.5" /> Loading PDF…- </div>- }- >- {width > 0 && (- // min-w-fit lets the zoomed row grow past the panel so the page stays- // centered and reachable on both sides.- <div className="flex min-w-fit justify-center">- <div className="relative w-fit shadow-sm">- <Page- pageNumber={page}- width={(width - 8) * scale}- renderTextLayer={false}- renderAnnotationLayer={false}- onRenderSuccess={recheckScrollable}- />- <RegionOverlay regions={pageRegions} />+ {options && (+ <Document+ file={fileUrl}+ options={options}+ onLoadSuccess={onLoad}+ onLoadError={(e) => setError(e.message)}+ loading={+ <div className="flex items-center gap-2 p-6 text-sm text-muted-foreground">+ <Spinner className="size-3.5" /> Loading PDF…</div>- </div>- )}- </Document>+ }+ >+ {width > 0 && (+ // min-w-fit lets the zoomed row grow past the panel so the page stays+ // centered and reachable on both sides.+ <div className="flex min-w-fit justify-center">+ <div className="relative w-fit shadow-sm">+ <Page+ pageNumber={page}+ width={(width - 8) * scale}+ renderTextLayer={false}+ renderAnnotationLayer={false}+ onRenderSuccess={recheckScrollable}+ />+ <RegionOverlay regions={pageRegions} />+ </div>+ </div>+ )}+ </Document>+ )}</div><div className="grid grid-cols-[1fr_auto_1fr] items-center border-t px-3 py-2 text-xs"><div className="flex items-center gap-0.5 justify-self-start">diff --git a/studio/frontend/tests/pdf-worker-failure-lifecycle.test.ts b/studio/frontend/tests/pdf-worker-failure-lifecycle.test.tsnew file mode 100644index 00000000000..3ceb02d3cf6--- /dev/null+++ b/studio/frontend/tests/pdf-worker-failure-lifecycle.test.ts@@ -0,0 +1,19 @@+// SPDX-License-Identifier: AGPL-3.0-only+// Copyright 2026-present the Unsloth AI Inc. team. All rights reserved. See /studio/LICENSE.AGPL-3.0++import assert from "node:assert/strict";+import { readFile } from "node:fs/promises";+import test from "node:test";++test("RAG PDF previews release their worker after a load error", async () => {+ const source = await readFile(+ new URL(+ "../src/features/rag/components/document-preview-sheet.tsx",+ import.meta.url,+ ),+ "utf8",+ );++ assert.match(source, /usePdfWorker\(error === null\)/);+ assert.match(source, /onLoadError=\{\(e\) => setError\(e\.message\)\}/);+});