Skip to content

Local UI to run and train LLMs and diffusion models. Supports GGUF, MLX, Qwen3.8, DeepSeek-V4.1, MiniMax-H3, Gemma 4, FLUX and more.

Studio: open each Settings tab at the top instead of the previous tab's scroll offset (#14353)

Daniel Han9c5b09bf703e
diff --git a/studio/frontend/src/features/settings/settings-dialog.tsx b/studio/frontend/src/features/settings/settings-dialog.tsx
index eead05fb6a1..94491b5f1ba 100644
--- a/studio/frontend/src/features/settings/settings-dialog.tsx
+++ b/studio/frontend/src/features/settings/settings-dialog.tsx
@@ -49,6 +49,7 @@ import {
lazy,
useDeferredValue,
useEffect,
+ useLayoutEffect,
useMemo,
useRef,
useState,
@@ -367,6 +368,12 @@ export function SettingsDialog() {
} | null>(null);
const mainScrollRef = useRef<HTMLDivElement | null>(null);
+ // Shared scroller: reset per tab. panelTab, not activeTab, so the old panel does not jump mid-defer.
+ // biome-ignore lint/correctness/useExhaustiveDependencies: panelTab is the trigger, not an input.
+ useLayoutEffect(() => {
+ mainScrollRef.current?.scrollTo({ top: 0, behavior: "instant" });
+ }, [panelTab]);
+
const openResult = (tab: SettingsTab, entry?: string) => {
setActiveTab(tab);
setQuery("");
diff --git a/tests/studio/playwright_settings_tabs.py b/tests/studio/playwright_settings_tabs.py
index b0d3fc330b6..d05e3c26e13 100644
--- a/tests/studio/playwright_settings_tabs.py
+++ b/tests/studio/playwright_settings_tabs.py
@@ -539,6 +539,37 @@ def assert_model_memory_rows() -> None:
fail(f"{tab}: '{label}' {'missing' if present else 'still renders'} ({labels[tab]})")
+PANEL_SCROLL_JS = """(sel) => {
+ const root = document.querySelector(sel);
+ return root ? { top: root.scrollTop, max: root.scrollHeight - root.clientHeight } : null;
+}"""
+
+
+def run_scroll_resets_on_tab_switch(page) -> None:
+ """A tab opens at its top, not at the offset the previous tab was scrolled to (#14337)."""
+ until(page, DIALOG_GONE)
+ open_dialog(page, "appearance")
+ settle_panel(page)
+ page.evaluate(
+ "(sel) => { const r = document.querySelector(sel); r.scrollTop = r.scrollHeight; }", PANEL
+ )
+ scrolled = page.evaluate(PANEL_SCROLL_JS, PANEL)
+ report["scroll_reset"] = {"scrolled": scrolled}
+ if not scrolled or scrolled["top"] <= 0:
+ fail(f"scroll reset: appearance panel did not scroll, nothing to test ({scrolled})")
+ close_dialog(page)
+ return
+ click_tab_and_observe(page, "general")
+ after = page.evaluate(PANEL_SCROLL_JS, PANEL)
+ report["scroll_reset"]["after"] = after
+ if not after or after["top"] != 0:
+ fail(f"scroll reset: general opened at {after}, appearance was left at {scrolled['top']}")
+ else:
+ log(f"scroll reset: general opened at the top, appearance was left at {scrolled['top']}")
+ close_dialog(page)
+ report["steps"].append("scroll-reset")
+
+
def run(page) -> None:
if CHUNK_FAIL:
run_chunk_fail(page)
@@ -648,6 +679,8 @@ def run(page) -> None:
run_keystroke_search(page)
+ run_scroll_resets_on_tab_switch(page)
+
report["page_errors"] = page.evaluate("() => window.__settingsSmoke.errors()")