Skip to content

Local UI to run and train LLMs and diffusion models. Supports GGUF, MLX, Qwen3.8, DeepSeek-V4.1, MiniMax-H3, Gemma 4, FLUX and more.

Studio: keep the seeded admin password out of pages relayed by a proxy (#17454)

Nilaya7a718663aef
diff --git a/studio/backend/tests/test_forwarded_header_trust.py b/studio/backend/tests/test_forwarded_header_trust.py
index 6087adc65d1..80bda5b2bcb 100644
--- a/studio/backend/tests/test_forwarded_header_trust.py
+++ b/studio/backend/tests/test_forwarded_header_trust.py
@@ -249,6 +249,19 @@ def test_client_ip_ignores_cf_connecting_ip_without_the_managed_tunnel():
assert client_ip(_request("127.0.0.1")) == "127.0.0.1"
+ "header",
+ [
+ ("x-forwarded-proto", "https"),
+ ("via", "1.1 proxy"),
+ ("x-forwarded-port", "443"),
+ ("x-forwarded-server", "proxy.example.com"),
+ ],
+)
+def test_client_ip_treats_proxy_hop_headers_as_relayed(header):
+ assert not is_loopback_host(client_ip(_request("127.0.0.1", [header])))
+
+
def test_client_ip_honours_cf_connecting_ip_through_the_managed_tunnel():
request = _request(
"127.0.0.1",
diff --git a/studio/backend/tests/test_index_bootstrap_loopback.py b/studio/backend/tests/test_index_bootstrap_loopback.py
index 230da6d3068..795c4cb4c1c 100644
--- a/studio/backend/tests/test_index_bootstrap_loopback.py
+++ b/studio/backend/tests/test_index_bootstrap_loopback.py
@@ -82,6 +82,19 @@ def test_reverse_proxy_forwarded_headers_are_remote():
assert _is_local_bootstrap_request(request) is False, header
+def test_proxy_hop_headers_alone_are_remote(monkeypatch):
+ import main
+ monkeypatch.setattr(main, "_IS_COLAB", False)
+ for header, value in (
+ ("x-forwarded-proto", "https"),
+ ("via", "1.1 proxy"),
+ ("x-forwarded-port", "443"),
+ ("x-forwarded-server", "proxy.example.com"),
+ ):
+ request = _request("127.0.0.1", "127.0.0.1:8888", headers = {header: value})
+ assert main._should_inject_bootstrap(request) is False, header
+
+
def test_malformed_or_absent_host_is_remote():
"""A malformed/absent/scope-id Host must not fall back to the loopback server address."""
from main import _is_local_bootstrap_request
diff --git a/studio/backend/utils/client_ip.py b/studio/backend/utils/client_ip.py
index 5b77753a26b..dc75c7e7b7f 100644
--- a/studio/backend/utils/client_ip.py
+++ b/studio/backend/utils/client_ip.py
@@ -71,7 +71,7 @@ def client_ip(request) -> str:
cf = _normalize_addr(request.headers.get("cf-connecting-ip"))
if cf:
return cf
- if any(request.headers.get(h) is not None for h in _PROXIED_CLIENT_HEADERS):
+ if names_a_forwarded_client(request):
return f"relayed:{peer}"
return peer or "_unknown"
@@ -159,11 +159,12 @@ def _host_header_is_loopback(host_header: str | None) -> bool:
_PROXY_HOP_HEADERS = ("via", "x-forwarded-port", "x-forwarded-proto", "x-forwarded-server")
+_RELAY_HEADERS = frozenset(_PROXIED_CLIENT_HEADERS + _PROXY_HOP_HEADERS)
+
+
def names_a_forwarded_client(request) -> bool:
"""Whether a proxy or tunnel marked this request as relayed."""
- return any(
- request.headers.get(h) is not None for h in _PROXIED_CLIENT_HEADERS + _PROXY_HOP_HEADERS
- )
+ return not _RELAY_HEADERS.isdisjoint(k.lower() for k in request.headers.keys())
def is_direct_local_request(request) -> bool:
@@ -171,6 +172,6 @@ def is_direct_local_request(request) -> bool:
client = request.client
if client is None or not _is_loopback_ip(client.host):
return False
- if any(request.headers.get(h) is not None for h in _PROXIED_CLIENT_HEADERS):
+ if names_a_forwarded_client(request):
return False
return _host_header_is_loopback(request.headers.get("host"))