Skip to content

Local UI to run and train LLMs and diffusion models. Supports GGUF, MLX, Qwen3.8, DeepSeek-V4.1, MiniMax-H3, Gemma 4, FLUX and more.

Studio: keep Max Tool Calls Per Message set to Off after a reload (#11234)

Nilayb8f77526bf17
diff --git a/studio/backend/routes/chat_history.py b/studio/backend/routes/chat_history.py
index b96b173daa6..39bd8c891b7 100644
--- a/studio/backend/routes/chat_history.py
+++ b/studio/backend/routes/chat_history.py
@@ -477,7 +477,7 @@ class ChatSettingsPayload(BaseModel):
searchImages: Optional[bool] = None
autoHealToolCalls: Optional[bool] = None
nudgeToolCalls: Optional[bool] = None
- maxToolCallsPerMessage: Optional[int] = Field(default = None, ge = 1)
+ maxToolCallsPerMessage: Optional[int] = Field(default = None, ge = 0)
toolCallTimeout: Optional[int] = Field(default = None, ge = 1)
# Composer and RAG toggles. They describe the installation, not the browser that set them, so a
@@ -524,13 +524,12 @@ class ChatSettingsPayload(BaseModel):
contextPolicy: Optional[Literal["inherit", "checkpoint", "rolling"]] = None
compactionHeadroomRatio: Optional[float] = Field(default = None, ge = 0.0, le = 0.9)
- @field_validator("researchModelTimeoutSeconds", mode = "before")
+ @field_validator("researchModelTimeoutSeconds", "maxToolCallsPerMessage", mode = "before")
@classmethod
def _not_a_boolean(cls, value: Any) -> Any:
- # bool subclasses int, so False coerces to the 0 sentinel and would persist as
- # unlimited for every later run. The run route rejects booleans for the same reason.
+ # bool subclasses int, so False would persist as the 0 sentinel for every later run.
if isinstance(value, bool):
- raise ValueError("researchModelTimeoutSeconds must be an integer, not a boolean")
+ raise ValueError("Expected an integer, got a boolean.")
return value
@field_validator("researchModelTimeoutSeconds")
diff --git a/studio/backend/tests/test_chat_settings_payload.py b/studio/backend/tests/test_chat_settings_payload.py
index eaa12009126..3fe8b641736 100644
--- a/studio/backend/tests/test_chat_settings_payload.py
+++ b/studio/backend/tests/test_chat_settings_payload.py
@@ -131,6 +131,11 @@ def test_unset_fields_stay_out_of_the_merge():
assert payload.model_dump(exclude_unset = True) == {"ragTopK": 5}
+def test_max_tool_calls_off_survives_the_payload():
+ payload = ChatSettingsPayload.model_validate({"maxToolCallsPerMessage": 0})
+ assert payload.model_dump(exclude_unset = True) == {"maxToolCallsPerMessage": 0}
+
+
@pytest.mark.parametrize(
"payload",
[
@@ -150,8 +155,12 @@ def test_unset_fields_stay_out_of_the_merge():
{"researchModelTimeoutSeconds": 9},
{"researchModelTimeoutSeconds": -1},
{"researchModelTimeoutSeconds": 365 * 24 * 3600 + 1},
- # bool subclasses int, so False would persist as the 0 "unlimited" sentinel.
+ # bool subclasses int, so False would persist as the 0 sentinel.
{"researchModelTimeoutSeconds": False},
+ {"maxToolCallsPerMessage": False},
+ {"maxToolCallsPerMessage": True},
+ {"maxToolCallsPerMessage": -1},
+ {"toolCallTimeout": 0},
{"unknownSetting": True},
],
)
diff --git a/studio/frontend/src/features/chat/utils/chat-settings-storage.ts b/studio/frontend/src/features/chat/utils/chat-settings-storage.ts
index f91478ec073..e519305e83d 100644
--- a/studio/frontend/src/features/chat/utils/chat-settings-storage.ts
+++ b/studio/frontend/src/features/chat/utils/chat-settings-storage.ts
@@ -307,7 +307,7 @@ export function sanitizeChatSettings(value: unknown): PersistedChatSettings {
const compactionHeadroomRatio = sanitizeCompactionHeadroomRatio(
value.compactionHeadroomRatio,
);
- const maxToolCallsPerMessage = sanitizeInt(value.maxToolCallsPerMessage, 1);
+ const maxToolCallsPerMessage = sanitizeInt(value.maxToolCallsPerMessage, 0);
const toolCallTimeout = sanitizeInt(value.toolCallTimeout, 1);
if (inferenceParams) settings.inferenceParams = inferenceParams;
@@ -444,7 +444,7 @@ export function loadLegacyChatSettings(): PersistedChatSettings {
const allowArtifactNetworkAccess = loadBool(ALLOW_ARTIFACT_NETWORK_ACCESS_KEY);
const autoHealToolCalls = loadBool(AUTO_HEAL_TOOL_CALLS_KEY);
const nudgeToolCalls = loadBool(NUDGE_TOOL_CALLS_KEY);
- const maxToolCallsPerMessage = loadInt(MAX_TOOL_CALLS_KEY, 1);
+ const maxToolCallsPerMessage = loadInt(MAX_TOOL_CALLS_KEY, 0);
const toolCallTimeout = loadInt(TOOL_CALL_TIMEOUT_KEY, 1);
const allCustomPresets = sanitizeCustomPresets([
...(customPresets ?? []),
diff --git a/studio/frontend/tests/max-tool-calls-off-persists.test.ts b/studio/frontend/tests/max-tool-calls-off-persists.test.ts
new file mode 100644
index 00000000000..a58fa798def
--- /dev/null
+++ b/studio/frontend/tests/max-tool-calls-off-persists.test.ts
@@ -0,0 +1,59 @@
+// SPDX-License-Identifier: AGPL-3.0-only
+// Copyright 2026-present the Unsloth AI Inc. team. All rights reserved. See /studio/LICENSE.AGPL-3.0
+
+import assert from "node:assert/strict";
+import test from "node:test";
+
+import {
+ installLocalStorageFake,
+ registerStoreStubResolver,
+} from "./helpers/kit.ts";
+import { setAuthFetchHandler } from "./helpers/store-stubs/auth.ts";
+
+registerStoreStubResolver();
+const { store } = installLocalStorageFake();
+
+const {
+ loadChatSettingsWithLegacyImport,
+ loadLegacyChatSettings,
+ sanitizeChatSettings,
+ savePersistedChatSettingsPatch,
+} = await import("../src/features/chat/utils/chat-settings-storage.ts");
+
+test("Off survives the outgoing patch", () => {
+ assert.deepEqual(sanitizeChatSettings({ maxToolCallsPerMessage: 0 }), {
+ maxToolCallsPerMessage: 0,
+ });
+ assert.deepEqual(sanitizeChatSettings({ maxToolCallsPerMessage: -1 }), {});
+ assert.deepEqual(sanitizeChatSettings({ toolCallTimeout: 0 }), {});
+});
+
+test("Off survives hydration from localStorage", () => {
+ store.set("unsloth_max_tool_calls_per_message", "0");
+ store.set("unsloth_tool_call_timeout", "0");
+ assert.deepEqual(loadLegacyChatSettings(), { maxToolCallsPerMessage: 0 });
+ store.clear();
+});
+
+test("Off is sent to the server and read back on reload", async () => {
+ const server: Record<string, unknown> = { maxToolCallsPerMessage: 25 };
+ const bodies: string[] = [];
+ setAuthFetchHandler((_input, init) => {
+ if (init?.method === "PUT") {
+ bodies.push(String(init.body));
+ Object.assign(server, JSON.parse(String(init.body)));
+ }
+ return Response.json({ settings: server });
+ });
+ try {
+ const saved = await savePersistedChatSettingsPatch({
+ maxToolCallsPerMessage: 0,
+ });
+ assert.deepEqual(bodies, ['{"maxToolCallsPerMessage":0}']);
+ assert.equal(saved.maxToolCallsPerMessage, 0);
+ const reloaded = await loadChatSettingsWithLegacyImport();
+ assert.equal(reloaded.settings.maxToolCallsPerMessage, 0);
+ } finally {
+ setAuthFetchHandler(null);
+ }
+});