Local UI to run and train LLMs and diffusion models. Supports GGUF, MLX, Qwen3.8, DeepSeek-V4.1, MiniMax-H3, Gemma 4, FLUX and more.
Python agentaichatgptdeepseekfine-tuninggemmaimage-generationllamallmllmsopenaipythonqwenreinforcement-learningself-hostedstable-diffusiontext-to-speechttsuiunsloth
Studio: a managed account's Hub dataset card may not make the server dial an http(s) URL (#14091)
Daniel Hance3b7a5844fe
diff --git a/studio/backend/tests/test_hub_data_files_guard.py b/studio/backend/tests/test_hub_data_files_guard.pyindex daefc2f9587..7bc35759e26 100644--- a/studio/backend/tests/test_hub_data_files_guard.py+++ b/studio/backend/tests/test_hub_data_files_guard.py@@ -137,3 +137,82 @@ def test_without_the_guard_datasets_reads_the_host_file(tmp_path):# datasets 4.3.0 already refuses the chained form; the guard keeps refusing it if that changes.open_routes = [route for route in HUB_ROUTES if route != "CHAINED"]assert {route: seen[route] for route in open_routes} == dict.fromkeys(open_routes, "read")+++# A card whose data_files is an http(s) URL makes the server dial it, following redirects. The owner may+# load such cards as before; a managed account may not, or it could read loopback, LAN or metadata services.+URL_PROBE = """+import http.server+import os+import sys+import threading+from utils.security import hub_data_files+hub_data_files.install()+from datasets import load_dataset+from utils.account_context import AccountContext, run_as++hits = []++class Internal(http.server.BaseHTTPRequestHandler):+ def do_GET(self):+ hits.append(self.path)+ if self.path.startswith("/public.csv"):+ self.send_response(302)+ self.send_header("Location", "/internal-secret")+ self.end_headers()+ return+ body = b"secret\\nINTERNAL_ONLY\\n"+ self.send_response(200)+ self.send_header("Content-Length", str(len(body)))+ self.end_headers()+ self.wfile.write(body)++ do_HEAD = do_GET++ def log_message(self, *args):+ pass++server = http.server.HTTPServer(("127.0.0.1", 0), Internal)+threading.Thread(target = server.serve_forever, daemon = True).start()+snapshot = sys.argv[1]+with open(os.path.join(snapshot, "README.md"), "w") as f:+ f.write(+ "---\\nconfigs:\\n- config_name: default\\n data_files:\\n - split: train\\n"+ f" path: http://127.0.0.1:{server.server_port}/public.csv\\n---\\n"+ )++def rows():+ return list(load_dataset(snapshot, split = "train", streaming = True).take(2))++for label, account in (("OWNER", None), ("MANAGED", AccountContext("acct-bob", "bob"))):+ hits.clear()+ try:+ got = rows() if account is None else run_as(account, rows)+ print(label, "read" if "INTERNAL_ONLY" in str(got) else "other", len(hits))+ except FileNotFoundError:+ print(label, "refused", len(hits))+"""+++def test_a_managed_account_cannot_make_a_hub_card_dial_a_url(tmp_path):+ snapshot = tmp_path / "hub" / "datasets--org--card" / "snapshots" / "abc123"+ snapshot.mkdir(parents = True)+ out = subprocess.run(+ [sys.executable, "-c", textwrap.dedent(URL_PROBE), str(snapshot)],+ cwd = BACKEND,+ capture_output = True,+ text = True,+ timeout = 300,+ env = {+ **os.environ,+ "PYTHONPATH": str(BACKEND),+ "HF_HUB_CACHE": str(tmp_path / "hub"),+ "NO_PROXY": "127.0.0.1",+ "no_proxy": "127.0.0.1",+ },+ )+ assert out.returncode == 0, out.stderr+ seen = dict(line.split(" ", 1) for line in out.stdout.splitlines() if " " in line)++ assert seen["OWNER"].split()[0] == "read"+ assert seen["MANAGED"] == "refused 0"diff --git a/studio/backend/utils/security/hub_data_files.py b/studio/backend/utils/security/hub_data_files.pyindex 25941de656e..98c0582d3a0 100644--- a/studio/backend/utils/security/hub_data_files.py+++ b/studio/backend/utils/security/hub_data_files.py@@ -7,7 +7,9 @@ datasets joins a card's relative ``data_files`` and ``data_dir`` to the repo (``but keeps an absolute path, a ``file://`` / ``local://`` URL or an absolute ``data_dir`` as given, so a Hubrepo whose README lists ``/home/owner/private.csv`` makes ``load_dataset("org/repo")`` read that host file.No real card does that, and it would let anyone who can name a Hub dataset to Studio read host files-through a preview or a load. A Hub card may name relative paths and hf / http(s) URLs only.+through a preview or a load. A Hub card may name relative paths and hf / http(s) URLs only, and for a managed+account hf only: an http(s) URL makes the server dial wherever the card says (a redirect included), which would let+a managed account read loopback, LAN or cloud metadata services the rest of Studio keeps from it.``install()`` patches ``datasets`` once it is imported, without importing it at startup; it is idempotent."""@@ -20,6 +22,7 @@ import reimport sys_HUB_URL_PROTOCOLS = frozenset({"hf", "http", "https"})+_MANAGED_URL_PROTOCOLS = frozenset({"hf"})_PATCHES = {"datasets.data_files": ("resolve_pattern", "_pattern_guard"),"datasets.load": ("create_builder_configs_from_metadata_configs", "_card_guard"),@@ -66,11 +69,19 @@ def _stays_on_the_hub(value, *, urls: bool) -> bool:if protocol is None:# Relative, but ".." would climb out of a cached snapshot onto the host.return is_relative_path(text) and ".." not in re.split(r"[\\/]", text)- return urls and protocol in _HUB_URL_PROTOCOLS+ return urls and protocol in (_HUB_URL_PROTOCOLS if _is_owner() else _MANAGED_URL_PROTOCOLS)+++def _is_owner() -> bool:+ try:+ from utils.account_context import is_owner_context+ except ImportError: # outside Studio's backend there are no managed accounts+ return True+ return is_owner_context()def _refuse(value) -> None:- raise FileNotFoundError(f"Unable to find '{value}': a Hub dataset cannot point at a local file")+ raise FileNotFoundError(f"Unable to find '{value}': a Hub dataset card cannot point here")def _patterns(data_files):