Local UI to run and train LLMs and diffusion models. Supports GGUF, MLX, Qwen3.8, DeepSeek-V4.1, MiniMax-H3, Gemma 4, FLUX and more.
Python agentaichatgptdeepseekfine-tuninggemmaimage-generationllamallmllmsopenaipythonqwenreinforcement-learningself-hostedstable-diffusiontext-to-speechttsuiunsloth
Studio: unbreak the drag planner's diff, and key the tail where ids cannot reach (#11612)
Michael Hand3909e6f451c
diff --git a/studio/frontend/src/components/app-sidebar.tsx b/studio/frontend/src/components/app-sidebar.tsxindex 5ef369ec5a4..2f66a9ac57e 100644--- a/studio/frontend/src/components/app-sidebar.tsx+++ b/studio/frontend/src/components/app-sidebar.tsx@@ -236,7 +236,7 @@ import { useIsCoarsePointer } from "@/hooks/use-mobile";import {folderRingKey,sectionRingKey,- SIDEBAR_TAIL_ID,+ SIDEBAR_TAIL_SCOPE,useSidebarDrag,type SidebarDragItem,type SidebarDropContext,@@ -4368,14 +4368,11 @@ export function AppSidebar() {aria-hiddenclassName={cn("relative h-[calc(8px*var(--ui-space-scale,1))]",- dropCueClass(PINNED_ORDER_SCOPE, SIDEBAR_TAIL_ID),+ dropCueClass(SIDEBAR_TAIL_SCOPE, "pinned"),)}{...dnd.dropZoneProps({section: "pinned",- blockEnd: {- scope: PINNED_ORDER_SCOPE,- id: SIDEBAR_TAIL_ID,- },+ blockEnd: { scope: SIDEBAR_TAIL_SCOPE, id: "pinned" },})}/></SidebarMenu>diff --git a/studio/frontend/src/features/chat/index.ts b/studio/frontend/src/features/chat/index.tsindex 8c6d1631ee3..a7679dc78d3 100644--- a/studio/frontend/src/features/chat/index.ts+++ b/studio/frontend/src/features/chat/index.ts@@ -116,7 +116,7 @@ export {planSidebarDrop,rowKey,sectionRingKey,- SIDEBAR_TAIL_ID,+ SIDEBAR_TAIL_SCOPE,STAY,type DropEdge,type SidebarDragItem,diff --git a/studio/frontend/src/features/chat/lib/sidebar-drag.ts b/studio/frontend/src/features/chat/lib/sidebar-drag.tsindex e663d6f4339..34b5251ef4a 100644Binary files a/studio/frontend/src/features/chat/lib/sidebar-drag.ts and b/studio/frontend/src/features/chat/lib/sidebar-drag.ts differdiff --git a/studio/frontend/tests/sidebar-row-drag.test.ts b/studio/frontend/tests/sidebar-row-drag.test.tsindex 3533d153278..f698cd556d8 100644--- a/studio/frontend/tests/sidebar-row-drag.test.ts+++ b/studio/frontend/tests/sidebar-row-drag.test.ts@@ -14,7 +14,7 @@ import {planSidebarDrop,rowKey,sectionRingKey,- SIDEBAR_TAIL_ID,+ SIDEBAR_TAIL_SCOPE,STAY,type SidebarDragItem,type SidebarDropOutcome,@@ -1116,7 +1116,7 @@ test("a chat can be dropped after a folder that ends the Pinned list", () => {drag,{section: "pinned",- blockEnd: { scope: PINNED_ORDER_SCOPE, id: SIDEBAR_TAIL_ID },+ blockEnd: { scope: SIDEBAR_TAIL_SCOPE, id: "pinned" },},"bottom",ctx,@@ -1128,9 +1128,39 @@ test("a chat can be dropped after a folder that ends the Pinned list", () => {]);// Its own line, not the one under the folder's last chat: same pixels would be two drops.assert.deepEqual(afterFolder.cue, {- line: { rowKey: rowKey(PINNED_ORDER_SCOPE, SIDEBAR_TAIL_ID), edge: "bottom" },+ line: { rowKey: rowKey(SIDEBAR_TAIL_SCOPE, "pinned"), edge: "bottom" },});assert.notDeepEqual(afterFolder.cue, intoFolder.cue);+ // A row's id is not ours: a restored backup keeps the id in the file and the backend takes any+ // string, so reserving an id and asserting its shape proves nothing about what a project can be+ // called. A scope is ours. Every one is a constant here or `project:<id>`, so no row key can be+ // the tail's however hostile the id, and the tail cannot paint a line on somebody's folder.+ const tailKey = rowKey(SIDEBAR_TAIL_SCOPE, "pinned");+ for (const hostile of [+ "pinned",+ "sidebar-tail",+ SIDEBAR_TAIL_SCOPE,+ `${SIDEBAR_TAIL_SCOPE}:pinned`,+ ]) {+ for (const scope of [+ PINNED_ORDER_SCOPE,+ PROJECT_ORDER_SCOPE,+ RECENTS_ORDER_SCOPE,+ projectOrderScope(hostile),+ ]) {+ assert.notEqual(rowKey(scope, hostile), tailKey);+ assert.notEqual(scope, SIDEBAR_TAIL_SCOPE);+ }+ }+ // Printable too: a control character reads the same on screen and turns the whole planner+ // binary to Git, hiding it from every diff.+ assert.ok(+ [...SIDEBAR_TAIL_SCOPE].every((ch) => {+ const code = ch.codePointAt(0) ?? 0;+ return code > 0x1f && code !== 0x7f;+ }),+ `the tail scope holds a control character: ${JSON.stringify(SIDEBAR_TAIL_SCOPE)}`,+ );// Part of the layout, not summoned by the drag: a row mounting at drag start shifts every// section below it after the pointer was sampled, and the cue and the drop then disagree.const pinnedMenu = APP_SIDEBAR.slice(@@ -1140,7 +1170,7 @@ test("a chat can be dropped after a folder that ends the Pinned list", () => {assert.ok(pinnedMenu.length > 0, "the Pinned section moved");assert.match(pinnedMenu,- /<SidebarMenuItem\n\s*aria-hidden\n\s*className=\{cn\(\n\s*"relative h-\[calc\(8px\*var\(--ui-space-scale,1\)\)\]",\n\s*dropCueClass\(PINNED_ORDER_SCOPE, SIDEBAR_TAIL_ID\),/,+ /<SidebarMenuItem\n\s*aria-hidden\n\s*className=\{cn\(\n\s*"relative h-\[calc\(8px\*var\(--ui-space-scale,1\)\)\]",\n\s*dropCueClass\(SIDEBAR_TAIL_SCOPE, "pinned"\),/,);assert.ok(!/draggingRow && /.test(pinnedMenu),