Skip to content

Local UI to run and train LLMs and diffusion models. Supports GGUF, MLX, Qwen3.8, DeepSeek-V4.1, MiniMax-H3, Gemma 4, FLUX and more.

Name the method on the uploaded model card (#10816)

Vineeth Sai Varikuntlad4de144af67b
diff --git a/tests/test_upload_model_card_method.py b/tests/test_upload_model_card_method.py
new file mode 100644
index 00000000000..b7f3d3a382e
--- /dev/null
+++ b/tests/test_upload_model_card_method.py
@@ -0,0 +1,119 @@
+# SPDX-License-Identifier: AGPL-3.0-only
+# Copyright 2026-present the Unsloth AI Inc. team. All rights reserved.
+
+import ast
+from pathlib import Path
+from types import SimpleNamespace
+
+import pytest
+from huggingface_hub import ModelCard
+
+
+class Model:
+ config = SimpleNamespace(_name_or_path = "base/model", model_type = "llama")
+
+
+SAVE_PY = Path(__file__).resolve().parents[1] / "unsloth/save.py"
+
+LIFTED = ("upload_to_huggingface", "create_huggingface_repo")
+
+
+def uploading(monkeypatch):
+ """Lifted out of save.py, which cannot be imported: accelerator at module scope."""
+ source = SAVE_PY
+ tree = ast.parse(source.read_text(encoding = "utf-8"))
+
+ pushed = {}
+
+ class RecordingCard(ModelCard):
+ def push_to_hub(
+ self,
+ repo_id,
+ token = None,
+ **kwargs,
+ ):
+ pushed["repo_id"] = repo_id
+ pushed["content"] = self.content
+
+ import huggingface_hub
+
+ monkeypatch.setattr(huggingface_hub, "ModelCard", RecordingCard)
+ monkeypatch.setattr(huggingface_hub, "create_repo", lambda **kwargs: None)
+
+ env = {
+ "HfApi": lambda token = None: SimpleNamespace(),
+ "get_token": lambda: "env-token",
+ "_determine_username": lambda directory, old, token: (directory, directory.split("/")[0]),
+ "logger": SimpleNamespace(warning_once = lambda *args: None),
+ }
+ nodes = [
+ node
+ for node in tree.body
+ if (isinstance(node, ast.FunctionDef) and node.name in LIFTED)
+ or (
+ isinstance(node, ast.Assign)
+ and any(isinstance(t, ast.Name) and t.id == "MODEL_CARD" for t in node.targets)
+ )
+ ]
+ assert len(nodes) == len(LIFTED) + 1, f"expected MODEL_CARD and {LIFTED} in save.py"
+ module = ast.Module(body = nodes, type_ignores = [])
+ exec(compile(ast.fix_missing_locations(module), str(source), "exec"), env)
+ return env, pushed
+
+
+def test_upload_model_card_names_the_method(uploading):
+ env, pushed = uploading
+
+ env["upload_to_huggingface"](Model(), "owner/model", "token", "finetuned", "trl")
+
+ assert pushed["repo_id"] == "owner/model"
+ assert "# Uploaded finetuned model" in pushed["content"]
+ assert "# Uploaded model" not in pushed["content"]
+
+
+def test_upload_model_card_still_carries_username_extra_and_datasets(uploading):
+ env, pushed = uploading
+
+ env["upload_to_huggingface"](
+ Model(), "owner/model", "token", "finetuned", "trl", datasets = ["owner/data"]
+ )
+
+ card = ModelCard(pushed["content"])
+ assert "**Developed by:** owner" in pushed["content"]
+ assert card.data.base_model == "base/model"
+ assert "trl" in card.data.tags and "unsloth" in card.data.tags
+ assert card.data.datasets == ["owner/data"]
+
+
+def test_create_huggingface_repo_also_names_the_method(uploading):
+ env, pushed = uploading
+
+ env["create_huggingface_repo"](Model(), "owner/model", "token")
+
+ assert "# Uploaded finetuned model" in pushed["content"]
+ assert "# Uploaded model" not in pushed["content"]
+
+
+def test_no_card_in_save_py_is_formatted_without_a_method():
+ """The heading is "# Uploaded {method} model": an empty method ships "Uploaded model"."""
+ tree = ast.parse(SAVE_PY.read_text(encoding = "utf-8"))
+
+ formats = [
+ node
+ for node in ast.walk(tree)
+ if isinstance(node, ast.Call)
+ and isinstance(node.func, ast.Attribute)
+ and node.func.attr == "format"
+ and isinstance(node.func.value, ast.Name)
+ and node.func.value.id == "MODEL_CARD"
+ ]
+ assert formats, "no MODEL_CARD.format call found in save.py"
+
+ for call in formats:
+ method = next((kw.value for kw in call.keywords if kw.arg == "method"), None)
+ where = f"save.py:{call.lineno}"
+ assert method is not None, f"{where}: MODEL_CARD.format without a method"
+ if isinstance(method, ast.Constant):
+ assert isinstance(method.value, str), f"{where}: method is not a string"
+ assert method.value.strip(), f"{where}: method is empty, card reads 'Uploaded model'"
diff --git a/unsloth/save.py b/unsloth/save.py
index e37a51dec97..694f854d37f 100644
--- a/unsloth/save.py
+++ b/unsloth/save.py
@@ -2633,7 +2633,8 @@ def create_huggingface_repo(
username = username,
base_model = model.config._name_or_path,
model_type = model.config.model_type,
- method = "",
+ # "finetuned" for the same reason the other call sites say it: Unsloth trained it.
+ method = "finetuned",
extra = "unsloth",
)
card = ModelCard(content)
@@ -2684,7 +2685,7 @@ def upload_to_huggingface(
username = username,
base_model = model.config._name_or_path,
model_type = model.config.model_type,
- method = "",
+ method = method,
extra = extra,
)
card = ModelCard(content)
@@ -5445,7 +5446,7 @@ def _push_merged_to_hub_revision(save_kwargs):
username = username,
base_model = base_model,
model_type = model.config.model_type,
- method = "",
+ method = "finetuned",
extra = "unsloth",
)
)