Skip to content

Local UI to run and train LLMs and diffusion models. Supports GGUF, MLX, Qwen3.8, DeepSeek-V4.1, MiniMax-H3, Gemma 4, FLUX and more.

Docker: retry the deadsnakes PPA add so a Launchpad 504 does not fail the build

Daniel Hande3a347e2969
diff --git a/docker/Dockerfile b/docker/Dockerfile
index f35527ae350..e8b605750a5 100644
--- a/docker/Dockerfile
+++ b/docker/Dockerfile
@@ -69,7 +69,8 @@ ENV DEBIAN_FRONTEND=noninteractive \
RUN apt-get update && apt-get install -y --no-install-recommends \
software-properties-common ca-certificates curl git build-essential \
ninja-build cmake pkg-config \
- && add-apt-repository -y ppa:deadsnakes/ppa \
+ && for i in 1 2 3 4 5; do add-apt-repository -y ppa:deadsnakes/ppa && break; \
+ [ "$i" = 5 ] && exit 1; echo "add-apt-repository failed (attempt $i), retrying in 30s"; sleep 30; done \
&& apt-get update && apt-get install -y --no-install-recommends \
python${PYTHON_VERSION} python${PYTHON_VERSION}-venv python${PYTHON_VERSION}-dev \
&& ln -sf /usr/bin/python${PYTHON_VERSION} /usr/local/bin/python \
@@ -431,7 +432,8 @@ RUN CUDA_PKG="$(echo "${CUDA_VERSION}" | awk -F. '{print $1"-"$2}')" \
software-properties-common ca-certificates curl wget git libgomp1 \
gcc g++ zstd ffmpeg ninja-build \
"cuda-nvcc-${CUDA_PKG}" "cuda-cudart-dev-${CUDA_PKG}" \
- && add-apt-repository -y ppa:deadsnakes/ppa \
+ && for i in 1 2 3 4 5; do add-apt-repository -y ppa:deadsnakes/ppa && break; \
+ [ "$i" = 5 ] && exit 1; echo "add-apt-repository failed (attempt $i), retrying in 30s"; sleep 30; done \
&& apt-get update && apt-get install -y --no-install-recommends \
python${PYTHON_VERSION} python${PYTHON_VERSION}-venv python${PYTHON_VERSION}-dev \
&& ln -sf /usr/bin/python${PYTHON_VERSION} /usr/local/bin/python \
diff --git a/tests/python/test_docker_ppa_retry.py b/tests/python/test_docker_ppa_retry.py
new file mode 100644
index 00000000000..3c07fbec70f
--- /dev/null
+++ b/tests/python/test_docker_ppa_retry.py
@@ -0,0 +1,69 @@
+# SPDX-License-Identifier: AGPL-3.0-only
+# Copyright 2026-Present the Unsloth team. See /studio/LICENSE.AGPL-3.0
+
+"""Both apt stages must retry `add-apt-repository ppa:deadsnakes/ppa`, since Launchpad
+intermittently 504s and every push to main builds the image."""
+
+from __future__ import annotations
+
+import os
+import re
+import subprocess
+from pathlib import Path
+
+import pytest
+
+REPO_ROOT = Path(__file__).resolve().parents[2]
+DOCKERFILE = REPO_ROOT / "docker" / "Dockerfile"
+
+
+def _retry_loops() -> list[str]:
+ text = DOCKERFILE.read_text(encoding = "utf-8")
+ joined = re.sub(r"\\\n\s*", " ", text)
+ loops = re.findall(
+ r"for i in [^;]*; do add-apt-repository -y ppa:deadsnakes/ppa .*?; done", joined
+ )
+ return loops
+
+
+def test_both_apt_stages_retry_the_ppa_add():
+ text = DOCKERFILE.read_text(encoding = "utf-8")
+ assert text.count("add-apt-repository -y ppa:deadsnakes/ppa") == 2
+ assert len(_retry_loops()) == 2, "an add-apt-repository call lost its retry loop"
+
+
+def _run_loop(
+ loop: str, tmp_path: Path, *, failures: int
+) -> tuple[subprocess.CompletedProcess, int]:
+ bin_dir = tmp_path / "bin"
+ bin_dir.mkdir()
+ counter = tmp_path / "calls"
+ counter.write_text("0", encoding = "utf-8")
+ (bin_dir / "add-apt-repository").write_text(
+ "#!/usr/bin/env bash\n"
+ f"n=$(cat {counter}); n=$((n + 1)); echo $n > {counter}\n"
+ f"[ $n -gt {failures} ] || {{ echo '504 Gateway Time-out' >&2; exit 1; }}\n",
+ encoding = "utf-8",
+ )
+ (bin_dir / "add-apt-repository").chmod(0o755)
+ (bin_dir / "sleep").write_text("#!/usr/bin/env bash\nexit 0\n", encoding = "utf-8")
+ (bin_dir / "sleep").chmod(0o755)
+ env = dict(os.environ)
+ env["PATH"] = f"{bin_dir}{os.pathsep}" + env["PATH"]
+ res = subprocess.run(["sh", "-c", loop], capture_output = True, text = True, env = env, timeout = 60)
+ return res, int(counter.read_text(encoding = "utf-8"))
+
+
[email protected]("loop", _retry_loops(), ids = ["builder", "runtime"])
+def test_two_outages_are_absorbed(loop: str, tmp_path: Path):
+ res, calls = _run_loop(loop, tmp_path, failures = 2)
+ assert res.returncode == 0, res.stdout + res.stderr
+ assert calls == 3
+ assert res.stdout.count("retrying") == 2
+
+
[email protected]("loop", _retry_loops(), ids = ["builder", "runtime"])
+def test_a_lasting_outage_still_fails_the_build(loop: str, tmp_path: Path):
+ res, calls = _run_loop(loop, tmp_path, failures = 99)
+ assert res.returncode != 0
+ assert calls == 5