Local UI to run and train LLMs and diffusion models. Supports GGUF, MLX, Qwen3.8, DeepSeek-V4.1, MiniMax-H3, Gemma 4, FLUX and more.
Python agentaichatgptdeepseekfine-tuninggemmaimage-generationllamallmllmsopenaipythonqwenreinforcement-learningself-hostedstable-diffusiontext-to-speechttsuiunsloth
Studio: say the installer script is missing instead of showing the PowerShell logo (#11862)
oobaboogaf3a5c5ebb17a
diff --git a/studio/src-tauri/src/install.rs b/studio/src-tauri/src/install.rsindex ece3c7cbf58..4e38165d4ef 100644--- a/studio/src-tauri/src/install.rs+++ b/studio/src-tauri/src/install.rs@@ -42,6 +42,34 @@ fn generic_failure_message(code: i32) -> String {)}+/// Open rather than check existence: security software can block reads without removing the file.+fn unavailable_script_message(script: &Path) -> Option<String> {+ let err = std::fs::File::open(script).err()?;+ let name = script+ .file_name()+ .map(|name| name.to_string_lossy().into_owned())+ .unwrap_or_else(|| script.display().to_string());+ warn!("[install] cannot open {}: {err}", script.display());+ Some(format!(+ "Installation failed: {name}, which Unsloth needs to finish setting up, is missing or \+ cannot be read. Security software may have quarantined or blocked it. Restore it from \+ quarantine or reinstall Unsloth, then try again."+ ))+}++/// Recheck for quarantine during launch, but prefer AMSI and structured installer errors.+fn failure_message(context: &InstallFailureContext, code: i32, script: &Path) -> String {+ if context.security_block.is_none()+ && context.explicit_error.is_none()+ && context.default_error.is_none()+ {+ if let Some(message) = unavailable_script_message(script) {+ return message;+ }+ }+ context.message(code)+}+/// PowerShell hands the whole top-level script block to AMSI while compiling it, so a security/// product's verdict arrives as a parse error over the entire file before the installer's first/// line runs: no `[TAURI:ERROR]` marker, no phase log, just an unexplained stderr tail. Match the@@ -878,6 +906,14 @@ fn run_install_with_event_mode("meta",&format!("Using script: {}", script.display()),);+ if let Some(msg) = unavailable_script_message(&script) {+ diagnostics::finish_attempt(&diagnostics, &attempt, None, false, Some(msg.clone()));+ clear_current_attempt(&state);+ if event_mode.emit_terminal_events() {+ emit_failed(&app, &msg);+ }+ return Err(msg);+ }emit_mode_progress(&app,event_mode,@@ -953,7 +989,7 @@ fn run_install_with_event_mode(} else {let msg = failure_context.lock()- .map(|context| context.message(code))+ .map(|context| failure_message(&context, code, &script)).unwrap_or_else(|_| generic_failure_message(code));diagnostics::finish_attempt(&diagnostics,@@ -1535,6 +1571,106 @@ mod tests {assert!(!message.contains("This is a false positive"), "{message}");}+ // PowerShell 5.1 prints its logo even with -NoLogo when the script is missing.+ // Model stdout arriving last, hiding the stderr error.+ fn observe_missing_script_output(context: &mut InstallFailureContext) {+ context.observe_stderr(concat!(+ r"The argument 'C:\Users\Owner\AppData\Local\Unsloth\install.ps1' ",+ "to the -File parameter does not exist. Provide the path to an existing '.ps1' file as ",+ "an argument to the -File parameter.",+ ));+ context.observe_stdout("Windows PowerShell");+ context.observe_stdout("Copyright (C) Microsoft Corporation. All rights reserved.");+ }++ #[test]+ fn a_quarantined_script_is_reported_instead_of_the_powershell_logo() {+ let dir = tempfile::tempdir().expect("temp dir");+ let script = dir.path().join("install.ps1");+ let mut context = InstallFailureContext::default();+ observe_missing_script_output(&mut context);+ assert!(context.message(1).contains("Copyright (C) Microsoft"));++ let message = failure_message(&context, 1, &script);+ assert!(message.contains("install.ps1, which Unsloth needs"), "{message}");+ assert!(message.contains("quarantined"), "{message}");+ assert!(!message.contains("Copyright"), "{message}");+ assert_eq!(Some(message), unavailable_script_message(&script));+ }++ #[test]+ fn a_script_that_is_still_there_keeps_the_captured_failure() {+ let dir = tempfile::tempdir().expect("temp dir");+ let script = dir.path().join("install.ps1");+ std::fs::write(&script, "exit 1\r\n").expect("write script");+ assert_eq!(unavailable_script_message(&script), None);++ let mut context = InstallFailureContext::default();+ context.observe_stdout("[TAURI:ERROR] Python could not be installed");+ assert_eq!(+ failure_message(&context, 1, &script),+ "Installation failed: Python could not be installed"+ );+ }++ #[test]+ fn a_removed_script_does_not_hide_a_structured_failure() {+ let dir = tempfile::tempdir().expect("temp dir");+ let script = dir.path().join("install.ps1");+ assert!(unavailable_script_message(&script).is_some());++ let mut context = InstallFailureContext::default();+ context.observe_stdout("[TAURI:STEP] Installing Python");+ context.observe_stdout("[TAURI:ERROR] Python could not be installed");+ assert_eq!(+ failure_message(&context, 1, &script),+ "Installation failed: Python could not be installed"+ );+ }++ #[test]+ fn an_amsi_block_keeps_its_guidance_when_the_script_is_then_removed() {+ let dir = tempfile::tempdir().expect("temp dir");+ let script = dir.path().join("install.ps1");+ let mut context = InstallFailureContext::default();+ for line in AMSI_BLOCK_STDERR {+ context.observe_stderr(line);+ }+ let message = failure_message(&context, 1, &script);+ assert_eq!(message, context.message(1));+ assert!(message.contains(AMSI_MALWARE_GUIDANCE_PRE_START), "{message}");+ }++ // Exercise the real interpreter with the app's launch arguments.+ #[cfg(windows)]+ #[test]+ fn powershell_given_a_missing_script_is_reported_as_missing() {+ let dir = tempfile::tempdir().expect("temp dir");+ let script = std::fs::canonicalize(dir.path())+ .expect("canonicalize")+ .join("install.ps1");+ let output = Command::new(powershell_exe())+ .args(powershell_launch_args(&script))+ .output()+ .expect("spawn powershell");+ assert!(!output.status.success());++ let mut context = InstallFailureContext::default();+ for line in String::from_utf8_lossy(&output.stderr).lines() {+ context.observe_stderr(line);+ }+ for line in String::from_utf8_lossy(&output.stdout).lines() {+ context.observe_stdout(line);+ }+ let message = failure_message(&context, output.status.code().unwrap_or(-1), &script);+ assert!(+ message.contains("install.ps1, which Unsloth needs"),+ "{message}\nstdout: {}\nstderr: {}",+ String::from_utf8_lossy(&output.stdout),+ String::from_utf8_lossy(&output.stderr)+ );+ }+#[test]fn a_block_after_the_install_started_does_not_claim_nothing_changed() {// install.ps1 runs `unsloth studio setup` near the end, and that child spawns