Skip to content

World's first open-source enterprise world model.

Keep signed rule range bounds intact when parsing editor text (#1147)

Rudy Mizrahi Celekli4bdd94d30c9f
diff --git a/web/src/pages/RulesPanel.tsx b/web/src/pages/RulesPanel.tsx
index 7ec9b070..f6e2e632 100644
--- a/web/src/pages/RulesPanel.tsx
+++ b/web/src/pages/RulesPanel.tsx
@@ -107,7 +107,9 @@ export function parseOperand(op: string, text: string): unknown | undefined {
return set.length ? set : undefined;
}
if (kind === "range") {
- const parts = t.split(/[-~]/).map((s) => Number(s.trim()));
+ const number = "[+-]?(?:\\d+(?:\\.\\d*)?|\\.\\d+)(?:[eE][+-]?\\d+)?";
+ const match = new RegExp(`^(${number})\\s*[-~]\\s*(${number})$`).exec(t);
+ const parts = match ? [Number(match[1]), Number(match[2])] : [];
return parts.length === 2 && parts.every((n) => Number.isFinite(n))
? parts
: undefined;
diff --git a/web/src/pages/ruleRangeOperands.test.ts b/web/src/pages/ruleRangeOperands.test.ts
new file mode 100644
index 00000000..0d7b80df
--- /dev/null
+++ b/web/src/pages/ruleRangeOperands.test.ts
@@ -0,0 +1,15 @@
+import { describe, expect, it } from "vitest";
+import { parseOperand } from "./RulesPanel";
+
+describe("rule range operands", () => {
+ it.each([
+ ["-5 - -1", [-5, -1]],
+ ["-5 ~ 1", [-5, 1]],
+ ["1e-3 - 2e-3", [0.001, 0.002]],
+ ])("reads signed bounds in %s", (text, expected) => {
+ expect(parseOperand("between", text as string)).toEqual(expected);
+ });
+ it.each(["1 -", "-", "~ 1"])("keeps %s incomplete", (text) => {
+ expect(parseOperand("between", text)).toBeUndefined();
+ });
+});