World's first open-source enterprise world model.
Rust agent-memorybitemporalgraphragknowledge-baseknowledge-graphllmontologypgvectorpostgresqlragrustself-hostedsemantic-searchtemporal-knowledge-graphworld-model
Six tests that prove again what their change left alone are removed (#1127)
WaylandYang9683f30f35d9
diff --git a/crates/utopia-server/src/api/documents_routes_tests.rs b/crates/utopia-server/src/api/documents_routes_tests.rsindex 5bcb74d3..623cb83c 100644--- a/crates/utopia-server/src/api/documents_routes_tests.rs+++ b/crates/utopia-server/src/api/documents_routes_tests.rs@@ -417,7 +417,6 @@ struct Fixture {other_kb: Uuid,user: Uuid,folder: Uuid,- foreign_folder: Uuid,source: Uuid,token: String,_dir: tempfile::TempDir,@@ -490,7 +489,6 @@ impl Fixture {other_kb,user,folder,- foreign_folder,source,token,_dir: dir,@@ -783,34 +781,3 @@ async fn fallback_restore_and_other_ingest_dates_do_not_change() -> anyhow::Resu}f.cleanup().await}--#[tokio::test]-async fn date_detection_keeps_upload_access_and_folder_checks() -> anyhow::Result<()> {- let Some(f) = Fixture::new().await? else {- return Ok(());- };- for source in [f.foreign_folder, f.source] {- let (status, body) = f- .upload(- f.kb,- &format!("?source={source}"),- &[("dated.txt", "2024-03-01")],- )- .await?;- assert_eq!(status, StatusCode::UNPROCESSABLE_ENTITY);- assert_eq!(body["code"], "upload_needs_folder");- }- sqlx::query("UPDATE kb_members SET role='viewer' WHERE kb_id=$1 AND user_id=$2")- .bind(f.kb)- .bind(f.user)- .execute(&f.pool)- .await?;- let (status, _) = f.upload(f.kb, "", &[("dated.txt", "2024-03-01")]).await?;- assert_eq!(status, StatusCode::FORBIDDEN);- let count: i64 = sqlx::query_scalar("SELECT count(*) FROM documents WHERE kb_id=$1")- .bind(f.kb)- .fetch_one(&f.pool)- .await?;- assert_eq!(count, 0);- f.cleanup().await-}diff --git a/crates/utopia-server/src/notion.rs b/crates/utopia-server/src/notion.rsindex e53f1390..489a0b31 100644--- a/crates/utopia-server/src/notion.rs+++ b/crates/utopia-server/src/notion.rs@@ -445,11 +445,6 @@ fn slug(title: &str) -> String {#[cfg(test)]#[path = "notion_tests.rs"]mod traversal_tests;--#[cfg(test)]-#[path = "notion_resync_tests.rs"]-mod resync_tests;-#[cfg(test)]mod tests {use super::*;diff --git a/crates/utopia-server/src/notion_resync_tests.rs b/crates/utopia-server/src/notion_resync_tests.rsdeleted file mode 100644index 7fe9051e..00000000--- a/crates/utopia-server/src/notion_resync_tests.rs+++ /dev/null@@ -1,218 +0,0 @@-//! A page imported before nested traversal must gain its missing body on resync,-//! even when Notion's edit timestamp has not changed. A later failed read must-//! leave that complete body and its processing history unchanged.-use super::{fetch_pages, Paced};-use crate::ingest_sources::{ingest_item, IngestAction};-use chrono::{DateTime, Utc};-use serde_json::json;-use std::sync::Arc;-use utopia_store::documents;-use uuid::Uuid;-use wiremock::{matchers::method, matchers::path, Mock, MockServer, ResponseTemplate};--#[tokio::test]-async fn resync_adds_nested_body_and_preserves_it_when_a_later_read_fails() -> anyhow::Result<()> {- let Some(url) = utopia_store::test_db::url() else {- return Ok(());- };- let pool = sqlx::PgPool::connect(&url).await?;- let (org, workspace, kb, source) = (- Uuid::now_v7(),- Uuid::now_v7(),- Uuid::now_v7(),- Uuid::now_v7(),- );- let result = async {- sqlx::query("INSERT INTO organizations(id,name) VALUES($1,'notion-resync-test')")- .bind(org)- .execute(&pool)- .await?;- sqlx::query("INSERT INTO workspaces(id,org_id,name) VALUES($1,$2,'notion-resync-test')")- .bind(workspace)- .bind(org)- .execute(&pool)- .await?;- sqlx::query(- "INSERT INTO knowledge_bases(id,workspace_id,name) VALUES($1,$2,'notion-resync-test')",- )- .bind(kb)- .bind(workspace)- .execute(&pool)- .await?;- sqlx::query("INSERT INTO sources(id,kb_id,kind,name) VALUES($1,$2,'notion','fixture')")- .bind(source)- .bind(kb)- .execute(&pool)- .await?;- let dir = tempfile::tempdir()?;- let config = utopia_core::config::AppConfig {- data_dir: dir.path().to_string_lossy().into_owned(),- ..Default::default()- };- let search = Arc::new(utopia_search::SearchIndex::open(- &dir.path().join("search"),- )?);- let state = crate::state::AppState::new(pool.clone(), &config, search, "test-only".into());- let edited: DateTime<Utc> = "2026-10-01T12:00:00Z".parse()?;- let external_key = "notion://page";- let old_body = "# Quarterly policy\n\nPolicy details\n";- let complete_body = "# Quarterly policy\n\nPolicy details\nRevenue was 42 million.\n";-- // Seed exactly the body the old top-level-only reader would have stored.- let created = ingest_item(- &state,- kb,- source,- external_key,- "Quarterly-policy.md",- "text/markdown",- old_body.as_bytes(),- Some(edited),- )- .await?;- anyhow::ensure!(created == IngestAction::Created);- let original = documents::find_by_external_key(&pool, source, external_key)- .await?- .ok_or_else(|| anyhow::anyhow!("the original page was not persisted"))?;-- let server = MockServer::start().await;- Mock::given(method("POST"))- .and(path("/search"))- .respond_with(ResponseTemplate::new(200).set_body_json(json!({- "results": [{- "id": "page",- "properties": {"Name": {"type": "title", "title": [{"plain_text": "Quarterly policy"}]}},- "last_edited_time": "2026-10-01T12:00:00Z"- }],- "has_more": false- })))- .expect(3)- .mount(&server)- .await;- Mock::given(method("GET"))- .and(path("/blocks/page/children"))- .respond_with(ResponseTemplate::new(200).set_body_json(json!({- "results": [{- "id": "toggle", "type": "toggle", "has_children": true,- "toggle": {"rich_text": [{"plain_text": "Policy details"}]}- }],- "has_more": false- })))- .expect(3)- .mount(&server)- .await;- Mock::given(method("GET"))- .and(path("/blocks/toggle/children"))- .respond_with(ResponseTemplate::new(200).set_body_json(json!({- "results": [{- "id": "paragraph", "type": "paragraph", "has_children": false,- "paragraph": {"rich_text": [{"plain_text": "Revenue was 42 million."}]}- }],- "has_more": false- })))- .expect(2)- .mount(&server)- .await;- let mut http = Paced::new(reqwest::Client::builder().no_proxy().build()?);- http.api_root = server.uri();-- for expected in [IngestAction::Updated, IngestAction::Unchanged] {- let (pages, truncated, _) = fetch_pages(&mut http, None).await?;- anyhow::ensure!(!truncated && pages.len() == 1);- let page = &pages[0];- anyhow::ensure!(page.external_key == external_key);- anyhow::ensure!(page.last_edited == Some(edited));- anyhow::ensure!(page.text == complete_body);- let action = ingest_item(- &state,- kb,- source,- &page.external_key,- &page.filename,- "text/markdown",- page.text.as_bytes(),- page.last_edited,- )- .await?;- anyhow::ensure!(action == expected, "expected {expected:?}, got {action:?}");- let updated = documents::find_by_external_key(&pool, source, external_key)- .await?- .ok_or_else(|| anyhow::anyhow!("the resynced page was not persisted"))?;- anyhow::ensure!(updated.id == original.id);- anyhow::ensure!(updated.external_key.as_deref() == Some(external_key));- anyhow::ensure!(updated.doc_time == original.doc_time);- anyhow::ensure!(updated.doc_time == Some(edited));- anyhow::ensure!(updated.sha256 != original.sha256);- anyhow::ensure!(state.blob.get(&updated.sha256).await? == complete_body.as_bytes());- anyhow::ensure!(state.blob.get(&original.sha256).await? == old_body.as_bytes());- let versions: Vec<(i32, String)> = sqlx::query_as(- "SELECT version, sha256 FROM document_versions WHERE document_id=$1 ORDER BY version",- )- .bind(updated.id)- .fetch_all(&pool)- .await?;- anyhow::ensure!(- versions == vec![(1, original.sha256.clone()), (2, updated.sha256.clone())],- "resync must retain the old body and create exactly one new version"- );- if expected == IngestAction::Updated {- let jobs_before: i64 = sqlx::query_scalar(- "SELECT count(*) FROM jobs WHERE kind='process_document' AND payload->>'document_id'=$1",- )- .bind(updated.id.to_string())- .fetch_one(&pool)- .await?;- Mock::given(method("GET"))- .and(path("/blocks/toggle/children"))- .respond_with(ResponseTemplate::new(503).set_body_json(json!({- "message": "temporarily unavailable"- })))- .with_priority(1)- .up_to_n_times(1)- .expect(1)- .mount(&server)- .await;- let (pages, _, unread) = fetch_pages(&mut http, None).await?;- anyhow::ensure!(- pages.is_empty(),- "a failed body read must not return a page to ingest"- );- anyhow::ensure!(- unread- == vec!["notion page page: notion blocks returned 503 Service Unavailable: temporarily unavailable".to_string()]- );- let retained = documents::find_by_external_key(&pool, source, external_key)- .await?- .ok_or_else(|| anyhow::anyhow!("the complete page was lost after a failed read"))?;- anyhow::ensure!(retained.sha256 == updated.sha256);- anyhow::ensure!(retained.updated_at == updated.updated_at);- anyhow::ensure!(state.blob.get(&retained.sha256).await? == complete_body.as_bytes());- let versions_after: Vec<(i32, String)> = sqlx::query_as(- "SELECT version, sha256 FROM document_versions WHERE document_id=$1 ORDER BY version",- )- .bind(updated.id)- .fetch_all(&pool)- .await?;- anyhow::ensure!(versions_after == versions);- let jobs_after: i64 = sqlx::query_scalar(- "SELECT count(*) FROM jobs WHERE kind='process_document' AND payload->>'document_id'=$1",- )- .bind(updated.id.to_string())- .fetch_one(&pool)- .await?;- anyhow::ensure!(jobs_after == jobs_before);- }- }- Ok::<_, anyhow::Error>(())- }- .await;- sqlx::query("DELETE FROM knowledge_bases WHERE id=$1")- .bind(kb)- .execute(&pool)- .await?;- sqlx::query("DELETE FROM organizations WHERE id=$1")- .bind(org)- .execute(&pool)- .await?;- result-}diff --git a/crates/utopia-server/src/notion_tests.rs b/crates/utopia-server/src/notion_tests.rsindex 12b45f92..8542fb5d 100644--- a/crates/utopia-server/src/notion_tests.rs+++ b/crates/utopia-server/src/notion_tests.rs@@ -318,50 +318,6 @@ async fn independent_pages_and_databases_are_not_inlined() {assert_eq!(request_paths(&server).await, ["/blocks/page/children"]);}-#[tokio::test]-async fn flat_page_markdown_is_unchanged() {- let server = MockServer::start().await;- children(&server, "page", None, vec![- block("heading", "heading_1", "Heading", false),- block("paragraph", "paragraph", "Body", false),- block("bullet", "bulleted_list_item", "Bullet", false),- block("number", "numbered_list_item", "Number", false),- json!({"type":"to_do", "to_do":{"checked":true, "rich_text":[{"plain_text":"Done"}]}}),- block("quote", "quote", "Quote", false),- json!({"type":"code", "code":{"language":"rust", "rich_text":[{"plain_text":"let x = 1;"}]}}),- json!({"type":"divider", "divider":{}}),- block("unknown", "new_type", "Unknown text", false),- ], None).await;- assert_eq!(page_text(&mut paced(&server), "page").await.unwrap(),- "## Heading\nBody\n- Bullet\n1. Number\n- [x] Done\n> Quote\n```rust\nlet x = 1;\n```\nUnknown text\n");- assert_eq!(request_paths(&server).await.len(), 1);-}--#[tokio::test]-async fn child_request_error_keeps_existing_diagnostics() {- let server = MockServer::start().await;- children(- &server,- "page",- None,- vec![block("child", "toggle", "Parent", true)],- None,- )- .await;- Mock::given(path("/blocks/child/children"))- .respond_with(- ResponseTemplate::new(403).set_body_json(json!({"message":"child access denied"})),- )- .expect(1)- .mount(&server)- .await;- let error = page_text(&mut paced(&server), "page").await.unwrap_err();- assert_eq!(- error.to_string(),- "notion blocks returned 403 Forbidden: child access denied"- );-}-#[tokio::test]async fn nested_requests_share_pacing_and_honor_retry_after() {let server = MockServer::start().await;@@ -396,33 +352,6 @@ async fn nested_requests_share_pacing_and_honor_retry_after() {assert!(calls[2].1.duration_since(calls[1].1) >= Duration::from_millis(500));}-#[tokio::test]-async fn child_rate_limit_exhaustion_is_an_error() {- let server = MockServer::start().await;- children(- &server,- "page",- None,- vec![block("child", "toggle", "Parent", true)],- None,- )- .await;- Mock::given(path("/blocks/child/children"))- .respond_with(- ResponseTemplate::new(429)- .insert_header("Retry-After", "0")- .set_body_json(json!({"message":"still limited"})),- )- .expect(u64::from(MAX_RATE_LIMIT_RETRIES + 1))- .mount(&server)- .await;- let error = page_text(&mut paced(&server), "page").await.unwrap_err();- assert_eq!(- error.to_string(),- "notion blocks returned 429 Too Many Requests: still limited"- );-}-#[tokio::test]async fn a_page_whose_body_cannot_be_read_is_left_out_and_the_others_still_come_back() {let server = MockServer::start().await;diff --git a/crates/utopia-server/src/rdf.rs b/crates/utopia-server/src/rdf.rsindex 01ffbf56..740b580a 100644--- a/crates/utopia-server/src/rdf.rs+++ b/crates/utopia-server/src/rdf.rs@@ -1358,22 +1358,6 @@ mod tests {}}- #[test]- fn unrecognized_literal_text_keeps_the_existing_fallback() {- for value in ["1e309", "1e-325", "1e2147483648", "1_0e2", "before"] {- assert_eq!(decimal_text(value.to_string()), value);- }- for value in [- "2024-07-15Tnot-a-clock",- "2024-07-15T14:32:07.noiseZ",- "2024-07-15T14+14:01",- "2024-07-15T14+08:60",- "2024-07-15T14+时区",- ] {- assert!(date_literal(value).is_none(), "{value}");- }- }-#[test]fn typed_attributes_keep_value_precedence_prose_and_missing_objects() {for (value, datatype, expected) in [