Skip to content

World's first open-source enterprise world model.

A vector index is built by the role that owns the table, so a deployment with a restricted runtime role gets its indexes (#1124)

WaylandYangc3ce29f89410
diff --git a/crates/utopia-server/src/main.rs b/crates/utopia-server/src/main.rs
index d3173377..d6305c6c 100644
--- a/crates/utopia-server/src/main.rs
+++ b/crates/utopia-server/src/main.rs
@@ -487,14 +487,19 @@ async fn dispatch(st: &state::AppState, job: &utopia_store::jobs::Job) -> anyhow
.get("dims")
.and_then(|v| v.as_u64())
.ok_or_else(|| anyhow::anyhow!("payload 缺少 dims"))? as usize;
- let built = utopia_store::vector_index::build(&st.pool, target, dims)
- .await
- .map_err(|e| match e {
- utopia_core::AppError::Validation(_) => {
- anyhow::Error::from(e).context(utopia_core::Terminal)
- }
- other => anyhow::Error::from(other),
- })?;
+ let built = utopia_store::vector_index::build_as_owner(
+ &st.pool,
+ st.owner_database_url.as_deref(),
+ target,
+ dims,
+ )
+ .await
+ .map_err(|e| match e {
+ utopia_core::AppError::Validation(_) => {
+ anyhow::Error::from(e).context(utopia_core::Terminal)
+ }
+ other => anyhow::Error::from(other),
+ })?;
tracing::info!(
index = %built.name,
created = built.created,
diff --git a/crates/utopia-server/src/state.rs b/crates/utopia-server/src/state.rs
index e2fb48ef..b2161c96 100644
--- a/crates/utopia-server/src/state.rs
+++ b/crates/utopia-server/src/state.rs
@@ -42,6 +42,9 @@ pub struct AppState {
pub events: broadcast::Sender<AppEvent>,
/// 正在生成的回答,按会话查。**刷新页面之后还能接上**(见 `live`)
pub live: Arc<crate::live::Registry>,
+ /// 表的 owner 的连接串:迁移身份与运行身份分开时才有(`UTOPIA_MIGRATION_URL`)。
+ /// 运行期只有建向量索引用它,用完即关(`vector_index::build_as_owner`,#1120)
+ pub owner_database_url: Option<String>,
}
impl AppState {
@@ -75,6 +78,7 @@ impl AppState {
model_gates: Arc::new(crate::llm_util::ModelGates::default()),
events,
live: Arc::new(crate::live::Registry::default()),
+ owner_database_url: cfg.migration_url.clone(),
}
}
diff --git a/crates/utopia-store/src/vector_index.rs b/crates/utopia-store/src/vector_index.rs
index c22180f9..e1be34e7 100644
--- a/crates/utopia-store/src/vector_index.rs
+++ b/crates/utopia-store/src/vector_index.rs
@@ -209,6 +209,33 @@ pub struct Built {
pub seconds: f64,
}
+/// 用表的 owner 建。`owner_url` 是迁移身份的连接串,只在它跟运行身份分开时才有。
+///
+/// **建索引要的是表的所有权,授权顶替不了。** 部署按 `.env.example` 分开两个身份时,
+/// 应用连库用的是受限角色 `utopia_app`,它在这里拿到的是 `must be owner of table`:
+/// 任务失败三次,索引永远建不出来,每一次近邻查询都退回全表精确扫描。四万一千个名字
+/// 向量的库上,消解给每个 mention 做的那一次查找要一分半到三分钟(#1120)。
+///
+/// 所以分开了身份就用迁移那个身份开一条连接,建完即关——跟启动时跑迁移是同一个做法,
+/// 高权限连接不在运行期常驻。没分开时 `owner_url` 是 `None`,照旧用应用的池子
+pub async fn build_as_owner(
+ app: &PgPool,
+ owner_url: Option<&str>,
+ target: Target,
+ dims: usize,
+) -> AppResult<Built> {
+ let Some(url) = owner_url else {
+ return build(app, target, dims).await;
+ };
+ let owner = sqlx::postgres::PgPoolOptions::new()
+ .max_connections(1)
+ .connect(url)
+ .await?;
+ let built = build(&owner, target, dims).await;
+ owner.close().await;
+ built
+}
+
/// 任务本体。**事务外**(CONCURRENTLY 的要求)、**串行**(并行建索引要共享内存,
/// Docker 默认 64 MB 的 `/dev/shm` 会让它报 could not resize shared memory segment;
/// 串行 6 万行 1024 维约 90 秒,到处能跑)。上一次建到一半留下的无效索引先删——
diff --git a/crates/utopia-store/tests/a_vector_index_is_built_by_the_owner.rs b/crates/utopia-store/tests/a_vector_index_is_built_by_the_owner.rs
new file mode 100644
index 00000000..d7f40949
--- /dev/null
+++ b/crates/utopia-store/tests/a_vector_index_is_built_by_the_owner.rs
@@ -0,0 +1,81 @@
+//! 建索引要表的所有权(#1120):运行身份是受限角色时,它自己建不出来,
+//! 得用迁移那个身份的连接去建。
+//!
+//! 连库才测得到:建一个只有读写授权、不拥有任何表的登录角色,跟部署里的 `utopia_app`
+//! 一个处境。没有 `UTOPIA_DATABASE_URL` 时跳过;角色和索引自建自拆。
+use utopia_store::vector_index::{self, Target};
+
+const ROLE: &str = "utopia_index_probe";
+const PASSWORD: &str = "index-probe-only";
+// 别的测试不用的维度,索引名不会撞
+const DIMS: usize = 19;
+
+/// 把连接串里的身份换成受限角色:`postgres://owner:pw@host/db` → `postgres://probe:pw@host/db`
+fn as_restricted(url: &str) -> String {
+ let (scheme, rest) = url.split_once("://").expect("a postgres URL");
+ let host_and_path = rest.rsplit_once('@').map_or(rest, |(_, h)| h);
+ format!("{scheme}://{ROLE}:{PASSWORD}@{host_and_path}")
+}
+
+#[tokio::test]
+async fn a_restricted_role_cannot_build_and_the_owner_can() -> anyhow::Result<()> {
+ let Some(url) = utopia_store::test_db::url() else {
+ return Ok(());
+ };
+ let owner = sqlx::postgres::PgPoolOptions::new()
+ .max_connections(2)
+ .connect(&url)
+ .await?;
+ utopia_store::db::migrate(&owner).await?;
+ sqlx::raw_sql(&format!(
+ "DO $$ BEGIN
+ IF NOT EXISTS (SELECT 1 FROM pg_roles WHERE rolname = '{ROLE}') THEN
+ CREATE ROLE {ROLE} LOGIN PASSWORD '{PASSWORD}';
+ END IF;
+ END $$;
+ GRANT USAGE ON SCHEMA public TO {ROLE};
+ GRANT SELECT, INSERT, UPDATE, DELETE ON ALL TABLES IN SCHEMA public TO {ROLE};"
+ ))
+ .execute(&owner)
+ .await?;
+ vector_index::drop(&owner, Target::NameVectors, DIMS).await?;
+
+ let app = sqlx::postgres::PgPoolOptions::new()
+ .max_connections(2)
+ .connect(&as_restricted(&url))
+ .await?;
+ let run = async {
+ // 身份没分开时的老路:受限角色自己建,库拒绝
+ let refused = vector_index::build_as_owner(&app, None, Target::NameVectors, DIMS)
+ .await
+ .expect_err("a role that does not own the table cannot index it");
+ assert!(
+ refused.to_string().contains("must be owner"),
+ "the refusal is about ownership: {refused}"
+ );
+ assert_eq!(
+ vector_index::status(&owner, Target::NameVectors, DIMS).await?,
+ None,
+ "nothing was built"
+ );
+
+ // 给了 owner 的连接串:同一个任务建得出来,应用的池子仍是受限角色
+ let built =
+ vector_index::build_as_owner(&app, Some(&url), Target::NameVectors, DIMS).await?;
+ assert!(built.created);
+ assert_eq!(
+ vector_index::status(&app, Target::NameVectors, DIMS).await?,
+ Some(true),
+ "the restricted role sees a valid index it can use"
+ );
+ Ok::<_, anyhow::Error>(())
+ }
+ .await;
+ app.close().await;
+ vector_index::drop(&owner, Target::NameVectors, DIMS).await?;
+ sqlx::raw_sql(&format!("DROP OWNED BY {ROLE}; DROP ROLE {ROLE};"))
+ .execute(&owner)
+ .await?;
+ owner.close().await;
+ run
+}