Skip to content

World's first open-source enterprise world model.

Tell the reader when a conversation cannot be deleted, and keep the list in place while a search loads (#949)

Maya Kidd0d6d9d0c7af
diff --git a/web/src/pages/Chat.tsx b/web/src/pages/Chat.tsx
index a05d4bc1..6fdcd59f 100644
--- a/web/src/pages/Chat.tsx
+++ b/web/src/pages/Chat.tsx
@@ -224,6 +224,10 @@ export function Chat() {
return last.conversations.length > 0 && loaded < last.total ? loaded : undefined;
},
enabled: !!kbId && kb?.id === kbId,
+ // 换搜索词时留着上一屏,别每敲一个字就清空再冒出来(Graph、Library 同理)。
+ // 换了库不留:另一个库的会话一刻也不该出现在这里
+ placeholderData: (prev, prevQuery) =>
+ prevQuery?.queryKey[1] === kbId ? prev : undefined,
});
// Updated conversations can move between offset pages. Deduplicate by identity;
// invalidation refetches the loaded page range rather than appending stale offsets.
@@ -416,7 +420,13 @@ export function Chat() {
const removeConversation = async (id: string) => {
const owner = viewRequest.current;
- await conversationsApi.remove(kb!.id, id);
+ try {
+ await conversationsApi.remove(kb!.id, id);
+ } catch (e) {
+ // 确认框已经关了:删不掉不说出来的话,这一行只是安静地留在列表里
+ toast.error(e instanceof Error ? e.message : String(e));
+ return;
+ }
// 记号跟着会话走,否则这个 id 会一直留在浏览器的那张表里
convMarks.forget(id);
if (sessionStorage.getItem(lastKey(kb!.id)) === id) {
diff --git a/web/tests/chat-view.test.mjs b/web/tests/chat-view.test.mjs
index 8b7514a1..fb0f980c 100644
--- a/web/tests/chat-view.test.mjs
+++ b/web/tests/chat-view.test.mjs
@@ -18,13 +18,13 @@ const entry = `
import React from 'react'; import {createRoot} from 'react-dom/client';
import {QueryClient,QueryClientProvider} from '@tanstack/react-query';
import {createRouter,createRootRoute,createRoute,RouterProvider,Outlet} from '@tanstack/react-router';
-import {Chat} from '/src/pages/Chat.tsx'; import {liveAnswer} from '/src/liveAnswer.ts';
+import {Chat} from '/src/pages/Chat.tsx'; import {liveAnswer} from '/src/liveAnswer.ts'; import {ToastHost} from '/src/toast.tsx';
const parent=createRootRoute({component:Outlet});
const routes=['/kb/$kbId/chat','/kb/$kbId/chat/$conversationId'].map(path=>createRoute({getParentRoute:()=>parent,path,component:Chat}));
const router=createRouter({routeTree:parent.addChildren(routes)});
window.__go=to=>router.navigate({to}); window.__live=liveAnswer;
const client=new QueryClient({defaultOptions:{queries:{retry:false},mutations:{retry:false}}});
-const tree=React.createElement(QueryClientProvider,{client},React.createElement(RouterProvider,{router}));
+const tree=React.createElement(QueryClientProvider,{client},React.createElement(RouterProvider,{router}),React.createElement(ToastHost));
createRoot(document.getElementById('root')).render(location.search.includes('strict')?React.createElement(React.StrictMode,null,tree):tree);
`;
function plugin() {
@@ -726,5 +726,85 @@ test(
}
},
);
+ const row = (id, title = `Conversation ${id}`) => ({
+ id,
+ title,
+ created_at: "2026-01-01",
+ updated_at: "2026-01-01",
+ });
+ await t.test("a delete that fails says so and keeps the conversation", async () => {
+ const f = await open("/kb/one/chat/b", async (route, p) => {
+ if (route.request().method() === "DELETE" && p.endsWith("/conversations/a")) {
+ await route.fulfill({ status: 500, json: { error: "Could not delete it" } });
+ return true;
+ }
+ });
+ try {
+ await f.page.getByText("Answer beta", { exact: true }).waitFor();
+ await f.page.getByRole("button", { name: "More", exact: true }).first().click();
+ await f.page.getByRole("menuitem", { name: "Delete conversation" }).click();
+ await f.page.getByRole("button", { name: "Delete", exact: true }).click();
+ await f.page.getByText("Could not delete it", { exact: true }).waitFor();
+ assert.equal(
+ await f.page.getByText("Conversation a", { exact: true }).count(),
+ 1,
+ );
+ assert.deepEqual(f.errors, []);
+ } finally {
+ await f.close();
+ }
+ });
+ await t.test("a search keeps the listed conversations until its results arrive", async () => {
+ const held = deferred();
+ const f = await open("/kb/one/chat/b", async (route, p, url) => {
+ if (p.endsWith("/conversations") && url.searchParams.get("q")) {
+ held.resolve(route);
+ return true;
+ }
+ });
+ try {
+ await f.page.getByText("Answer beta", { exact: true }).waitFor();
+ await f.page.getByPlaceholder("Search chats").fill("alp");
+ const search = await held.promise;
+ for (const title of ["Conversation a", "Conversation b"])
+ assert.equal(await f.page.getByText(title, { exact: true }).count(), 1, title);
+ await search.fulfill({ json: { conversations: [row("a")], total: 1 } });
+ await f.page
+ .getByText("Conversation b", { exact: true })
+ .waitFor({ state: "detached" });
+ assert.equal(
+ await f.page.getByText("Conversation a", { exact: true }).count(),
+ 1,
+ );
+ assert.deepEqual(f.errors, []);
+ } finally {
+ await f.close();
+ }
+ });
+ await t.test("another library's conversations never stand in for this one's", async () => {
+ const held = deferred();
+ const f = await open("/kb/one/chat", async (route, p) => {
+ if (p === "/api/v1/kbs/two/conversations") {
+ held.resolve(route);
+ return true;
+ }
+ });
+ try {
+ await f.page.getByText("Conversation a", { exact: true }).waitFor();
+ await f.page.evaluate(() => window.__go("/kb/two/chat"));
+ const list = await held.promise;
+ assert.equal(
+ await f.page.getByText("Conversation a", { exact: true }).count(),
+ 0,
+ );
+ await list.fulfill({
+ json: { conversations: [row("c", "Other library chat")], total: 1 },
+ });
+ await f.page.getByText("Other library chat", { exact: true }).waitFor();
+ assert.deepEqual(f.errors, []);
+ } finally {
+ await f.close();
+ }
+ });
},
);