Skip to content

armgit / vaul

Public Imported from GitHub
0

A drawer component for React.

fix: restore position setting on unmount (#136)

Andre Jilderda888d27fdea04
diff --git a/src/index.tsx b/src/index.tsx
index 1f6e421..4a24f0c 100644
--- a/src/index.tsx
+++ b/src/index.tsx
@@ -117,7 +117,7 @@ function Root({
isDisabled: !isOpen || isDragging || !modal || justReleased || !hasBeenOpened,
});
- usePositionFixed({ isOpen, modal, nested, hasBeenOpened });
+ const { restorePositionSetting } = usePositionFixed({ isOpen, modal, nested, hasBeenOpened });
function getScale() {
return (window.innerWidth - WINDOW_TOP_OFFSET) / window.innerWidth;
@@ -294,8 +294,13 @@ function Root({
const wrapper = document.querySelector('[vaul-drawer-wrapper]');
if (wrapper) {
- return () => scaleBackground(false);
+ return () => {
+ scaleBackground(false);
+ restorePositionSetting();
+ };
}
+
+ return restorePositionSetting;
}, []);
React.useEffect(() => {
diff --git a/src/use-position-fixed.ts b/src/use-position-fixed.ts
index d25d4c2..88491f4 100644
--- a/src/use-position-fixed.ts
+++ b/src/use-position-fixed.ts
@@ -99,4 +99,6 @@ export function usePositionFixed({
restorePositionSetting();
}
}, [isOpen]);
+
+ return { restorePositionSetting };
}