A drawer component for React.
fix: missing dependencies on fixed position hook effect (#231)
GJuniordc1e35d31df9
diff --git a/src/use-position-fixed.ts b/src/use-position-fixed.tsindex d917167..2beffaa 100644--- a/src/use-position-fixed.ts+++ b/src/use-position-fixed.ts@@ -18,7 +18,7 @@ export function usePositionFixed({const [activeUrl, setActiveUrl] = React.useState(typeof window !== 'undefined' ? window.location.href : '');const scrollPos = React.useRef(0);- function setPositionFixed() {+ const setPositionFixed = React.useCallback(() => {// If previousBodyPosition is already set, don't set it again.if (previousBodyPosition === null && isOpen) {previousBodyPosition = {@@ -50,9 +50,9 @@ export function usePositionFixed({300,);}- }+ }, [isOpen]);- function restorePositionSetting() {+ const restorePositionSetting = React.useCallback(() => {if (previousBodyPosition !== null) {// Convert the position from "px" to Intconst y = -parseInt(document.body.style.top, 10);@@ -76,7 +76,7 @@ export function usePositionFixed({previousBodyPosition = null;}- }+ }, [activeUrl]);React.useEffect(() => {function onScroll() {@@ -106,7 +106,7 @@ export function usePositionFixed({} else {restorePositionSetting();}- }, [isOpen, hasBeenOpened, activeUrl]);+ }, [isOpen, hasBeenOpened, activeUrl, modal, nested, setPositionFixed, restorePositionSetting]);return { restorePositionSetting };}