Skip to content

VectorCraft: An open-source, vector art tool written by scratch in pure Rust

Wrap to_hsb hue of 360 back to 0 for near-red colours

NetterSilver4a29fd4112f3
diff --git a/crates/color/src/lib.rs b/crates/color/src/lib.rs
index aff5c5122..d7921a948 100644
--- a/crates/color/src/lib.rs
+++ b/crates/color/src/lib.rs
@@ -146,6 +146,8 @@ impl Color {
} else {
60.0 * ((r - g) / d + 4.0)
};
+ // f32 rounding in rem_euclid can yield exactly 360; wrap back to 0.
+ let h = if h >= 360.0 { 0.0 } else { h };
let s = if max <= 0.0 { 0.0 } else { d / max };
[h, s, max]
}
@@ -438,6 +440,12 @@ impl Paint {
mod tests {
use super::*;
+ #[test]
+ fn hue_below_360() {
+ let h = Color::Rgb { r: 1.0, g: 0.0, b: 1e-7 }.to_hsb()[0];
+ assert!((0.0..360.0).contains(&h), "hue {h}");
+ }
+
#[test]
fn hex_roundtrip() {
let c = Color::from_hex("#ff8000").unwrap();