The open-source AI voice studio. Clone, dictate, create.
feat: add download cancel/clear UI, fix whisper-large and error reporting
Daddy Raegena362d7de2ab9
diff --git a/app/src/components/ServerSettings/ModelManagement.tsx b/app/src/components/ServerSettings/ModelManagement.tsxindex 4a5fd439..71c8b68b 100644--- a/app/src/components/ServerSettings/ModelManagement.tsx+++ b/app/src/components/ServerSettings/ModelManagement.tsx@@ -1,5 +1,5 @@import { useMutation, useQuery, useQueryClient } from '@tanstack/react-query';-import { Download, Loader2, Trash2 } from 'lucide-react';+import { ChevronDown, ChevronUp, Download, Loader2, RotateCcw, Trash2, X } from 'lucide-react';import { useCallback, useState } from 'react';import {AlertDialog,@@ -16,6 +16,7 @@ import { Button } from '@/components/ui/button';import { Card, CardContent, CardDescription, CardHeader, CardTitle } from '@/components/ui/card';import { useToast } from '@/components/ui/use-toast';import { apiClient } from '@/lib/api/client';+import type { ActiveDownloadTask } from '@/lib/api/types';import { useModelDownloadToast } from '@/lib/hooks/useModelDownloadToast';export function ModelManagement() {@@ -23,6 +24,9 @@ export function ModelManagement() {const queryClient = useQueryClient();const [downloadingModel, setDownloadingModel] = useState<string | null>(null);const [downloadingDisplayName, setDownloadingDisplayName] = useState<string | null>(null);+ const [consoleOpen, setConsoleOpen] = useState(false);+ const [dismissedErrors, setDismissedErrors] = useState<Set<string>>(new Set());+ const [localErrors, setLocalErrors] = useState<Map<string, string>>(new Map());const { data: modelStatus, isLoading } = useQuery({queryKey: ['modelStatus'],@@ -35,19 +39,57 @@ export function ModelManagement() {refetchInterval: 5000, // Refresh every 5 seconds});+ const { data: activeTasks } = useQuery({+ queryKey: ['activeTasks'],+ queryFn: () => apiClient.getActiveTasks(),+ refetchInterval: 5000,+ });++ // Build a map of errored downloads for quick lookup, excluding dismissed ones+ // Merge server errors with locally captured SSE errors+ const erroredDownloads = new Map<string, ActiveDownloadTask>();+ if (activeTasks?.downloads) {+ for (const dl of activeTasks.downloads) {+ if (dl.status === 'error' && !dismissedErrors.has(dl.model_name)) {+ // Prefer locally captured error (from SSE) over server error+ const localErr = localErrors.get(dl.model_name);+ erroredDownloads.set(dl.model_name, localErr ? { ...dl, error: localErr } : dl);+ }+ }+ }+ // Also add locally captured errors that aren't in server response yet+ for (const [modelName, error] of localErrors) {+ if (!erroredDownloads.has(modelName) && !dismissedErrors.has(modelName)) {+ erroredDownloads.set(modelName, {+ model_name: modelName,+ status: 'error',+ started_at: new Date().toISOString(),+ error,+ });+ }+ }++ const errorCount = erroredDownloads.size;+// Callbacks for download completionconst handleDownloadComplete = useCallback(() => {console.log('[ModelManagement] Download complete, clearing state');setDownloadingModel(null);setDownloadingDisplayName(null);queryClient.invalidateQueries({ queryKey: ['modelStatus'] });+ queryClient.invalidateQueries({ queryKey: ['activeTasks'] });}, [queryClient]);- const handleDownloadError = useCallback(() => {+ const handleDownloadError = useCallback((error: string) => {console.log('[ModelManagement] Download error, clearing state');+ if (downloadingModel) {+ setLocalErrors((prev) => new Map(prev).set(downloadingModel, error));+ setConsoleOpen(true);+ }setDownloadingModel(null);setDownloadingDisplayName(null);- }, []);+ queryClient.invalidateQueries({ queryKey: ['activeTasks'] });+ }, [queryClient, downloadingModel]);// Use progress toast hook for the downloading modeluseModelDownloadToast({@@ -67,11 +109,17 @@ export function ModelManagement() {const handleDownload = async (modelName: string) => {console.log('[Download] Button clicked for:', modelName, 'at', new Date().toISOString());-+ // Clear any previous dismissal so fresh errors can appear+ setDismissedErrors((prev) => {+ const next = new Set(prev);+ next.delete(modelName);+ return next;+ });+// Find display nameconst model = modelStatus?.models.find((m) => m.model_name === modelName);const displayName = model?.display_name || modelName;-+try {// IMPORTANT: Call the API FIRST before setting state// Setting state enables the SSE EventSource in useModelDownloadToast,@@ -79,14 +127,15 @@ export function ModelManagement() {console.log('[Download] Calling download API for:', modelName);const result = await apiClient.triggerModelDownload(modelName);console.log('[Download] Download API responded:', result);-+// NOW set state to enable SSE tracking (after download has started on backend)setDownloadingModel(modelName);setDownloadingDisplayName(displayName);-+// Download initiated successfully - state will be cleared when SSE reports completion// or by the polling interval detecting the model is downloadedqueryClient.invalidateQueries({ queryKey: ['modelStatus'] });+ queryClient.invalidateQueries({ queryKey: ['activeTasks'] });} catch (error) {console.error('[Download] Download failed:', error);setDownloadingModel(null);@@ -99,6 +148,39 @@ export function ModelManagement() {}};+ const cancelMutation = useMutation({+ mutationFn: (modelName: string) => apiClient.cancelDownload(modelName),+ onSuccess: async () => {+ await queryClient.invalidateQueries({ queryKey: ['modelStatus'], refetchType: 'all' });+ await queryClient.invalidateQueries({ queryKey: ['activeTasks'], refetchType: 'all' });+ },+ });++ const handleCancel = (modelName: string) => {+ // Immediately hide the error and suppress downloading state in UI+ setDismissedErrors((prev) => new Set(prev).add(modelName));+ setLocalErrors((prev) => { const next = new Map(prev); next.delete(modelName); return next; });+ // Also clear local downloading state if this was our current download+ if (downloadingModel === modelName) {+ setDownloadingModel(null);+ setDownloadingDisplayName(null);+ }+ // Fire-and-forget the backend cancel, then refetch to sync+ cancelMutation.mutate(modelName);+ };++ const clearAllMutation = useMutation({+ mutationFn: () => apiClient.clearAllTasks(),+ onSuccess: async () => {+ setDismissedErrors(new Set());+ setLocalErrors(new Map());+ setDownloadingModel(null);+ setDownloadingDisplayName(null);+ await queryClient.invalidateQueries({ queryKey: ['modelStatus'], refetchType: 'all' });+ await queryClient.invalidateQueries({ queryKey: ['activeTasks'], refetchType: 'all' });+ },+ });+const deleteMutation = useMutation({mutationFn: async (modelName: string) => {console.log('[Delete] Deleting model:', modelName);@@ -114,14 +196,11 @@ export function ModelManagement() {});setDeleteDialogOpen(false);setModelToDelete(null);- // Invalidate AND explicitly refetch to ensure UI updates- // Using refetchType: 'all' ensures we refetch even if the query is staleconsole.log('[Delete] Invalidating modelStatus query');- await queryClient.invalidateQueries({+ await queryClient.invalidateQueries({queryKey: ['modelStatus'],refetchType: 'all',});- // Also explicitly refetch to guarantee fresh dataconsole.log('[Delete] Explicitly refetching modelStatus query');await queryClient.refetchQueries({ queryKey: ['modelStatus'] });console.log('[Delete] Query refetched');@@ -178,7 +257,11 @@ export function ModelManagement() {});setDeleteDialogOpen(true);}}+ onCancel={() => handleCancel(model.model_name)}isDownloading={downloadingModel === model.model_name}+ isCancelling={cancelMutation.isPending}+ isDismissed={dismissedErrors.has(model.model_name)}+ erroredDownload={erroredDownloads.get(model.model_name)}formatSize={formatSize}/>))}@@ -206,13 +289,73 @@ export function ModelManagement() {});setDeleteDialogOpen(true);}}+ onCancel={() => handleCancel(model.model_name)}isDownloading={downloadingModel === model.model_name}+ isCancelling={cancelMutation.isPending}+ isDismissed={dismissedErrors.has(model.model_name)}+ erroredDownload={erroredDownloads.get(model.model_name)}formatSize={formatSize}/>))}</div></div>+ {/* Console Panel */}+ {errorCount > 0 && (+ <div className="border rounded-lg overflow-hidden">+ <div className="flex items-center justify-between px-3 py-1.5 bg-muted/50 text-xs font-medium text-muted-foreground">+ <button+ type="button"+ onClick={() => setConsoleOpen((v) => !v)}+ className="flex items-center gap-2 hover:text-foreground transition-colors"+ >+ {consoleOpen ? (+ <ChevronDown className="h-3.5 w-3.5" />+ ) : (+ <ChevronUp className="h-3.5 w-3.5" />+ )}+ <span>Problems</span>+ <Badge variant="destructive" className="text-[10px] h-4 px-1.5 rounded-full">+ {errorCount}+ </Badge>+ </button>+ <Button+ size="sm"+ variant="ghost"+ className="h-6 px-2 text-xs text-muted-foreground hover:text-foreground"+ onClick={() => clearAllMutation.mutate()}+ disabled={clearAllMutation.isPending}+ >+ <RotateCcw className="h-3 w-3 mr-1" />+ Clear All+ </Button>+ </div>+ {consoleOpen && (+ <div className="bg-[#1e1e1e] text-[#d4d4d4] p-3 max-h-48 overflow-auto font-mono text-xs leading-relaxed">+ {Array.from(erroredDownloads.entries()).map(([modelName, dl]) => (+ <div key={modelName} className="mb-2 last:mb-0">+ <span className="text-[#f44747]">[error]</span>{' '}+ <span className="text-[#569cd6]">{modelName}</span>+ {dl.error ? (+ <>+ {': '}+ <span className="text-[#ce9178] whitespace-pre-wrap break-all">{dl.error}</span>+ </>+ ) : (+ <>+ {': '}+ <span className="text-[#808080]">No error details available. Try downloading again.</span>+ </>+ )}+ <div className="text-[#6a9955] mt-0.5">+ started at {new Date(dl.started_at).toLocaleString()}+ </div>+ </div>+ ))}+ </div>+ )}+ </div>+ )}</div>) : null}</CardContent>@@ -271,17 +414,22 @@ interface ModelItemProps {};onDownload: () => void;onDelete: () => void;+ onCancel: () => void;isDownloading: boolean; // Local state - true if user just clicked download+ isCancelling: boolean;+ isDismissed: boolean;+ erroredDownload?: ActiveDownloadTask;formatSize: (sizeMb?: number) => string;}-function ModelItem({ model, onDownload, onDelete, isDownloading, formatSize }: ModelItemProps) {+function ModelItem({ model, onDownload, onDelete, onCancel, isDownloading, isCancelling, isDismissed, erroredDownload, formatSize }: ModelItemProps) {// Use server's downloading state OR local state (for immediate feedback before server updates)- const showDownloading = model.downloading || isDownloading;-+ // Suppress downloading if user just dismissed/cancelled this model+ const showDownloading = (model.downloading || isDownloading) && !erroredDownload && !isDismissed;+return (<div className="flex items-center justify-between p-3 border rounded-lg">- <div className="flex-1">+ <div className="flex-1 min-w-0"><div className="flex items-center gap-2"><span className="font-medium text-sm">{model.display_name}</span>{model.loaded && (@@ -289,21 +437,41 @@ function ModelItem({ model, onDownload, onDelete, isDownloading, formatSize }: MLoaded</Badge>)}- {/* Only show Downloaded if actually downloaded AND not downloading */}- {model.downloaded && !model.loaded && !showDownloading && (+ {model.downloaded && !model.loaded && !showDownloading && !erroredDownload && (<Badge variant="secondary" className="text-xs">Downloaded</Badge>)}+ {erroredDownload && (+ <Badge variant="destructive" className="text-xs">+ Error+ </Badge>+ )}</div>- {model.downloaded && model.size_mb && !showDownloading && (+ {model.downloaded && model.size_mb && !showDownloading && !erroredDownload && (<div className="text-xs text-muted-foreground mt-1">Size: {formatSize(model.size_mb)}</div>)}</div>- <div className="flex items-center gap-2">- {model.downloaded && !showDownloading ? (+ <div className="flex items-center gap-2 shrink-0 ml-2">+ {erroredDownload ? (+ <div className="flex items-center gap-2">+ <Button size="sm" onClick={onDownload} variant="outline">+ <Download className="h-4 w-4 mr-2" />+ Retry+ </Button>+ <Button+ size="sm"+ onClick={onCancel}+ variant="ghost"+ disabled={isCancelling}+ title="Dismiss error"+ >+ <X className="h-4 w-4" />+ </Button>+ </div>+ ) : model.downloaded && !showDownloading ? (<div className="flex items-center gap-2"><div className="flex items-center gap-1 text-sm text-muted-foreground"><span>Ready</span>@@ -319,10 +487,21 @@ function ModelItem({ model, onDownload, onDelete, isDownloading, formatSize }: M</Button></div>) : showDownloading ? (- <Button size="sm" variant="outline" disabled>- <Loader2 className="h-4 w-4 mr-2 animate-spin" />- Downloading...- </Button>+ <div className="flex items-center gap-2">+ <Button size="sm" variant="outline" disabled>+ <Loader2 className="h-4 w-4 mr-2 animate-spin" />+ Downloading...+ </Button>+ <Button+ size="sm"+ onClick={onCancel}+ variant="ghost"+ disabled={isCancelling}+ title="Cancel download"+ >+ <X className="h-4 w-4" />+ </Button>+ </div>) : (<Button size="sm" onClick={onDownload} variant="outline"><Download className="h-4 w-4 mr-2" />diff --git a/app/src/lib/api/client.ts b/app/src/lib/api/client.tsindex c5b079b2..ce54d2bc 100644--- a/app/src/lib/api/client.ts+++ b/app/src/lib/api/client.ts@@ -325,11 +325,22 @@ class ApiClient {});}+ async cancelDownload(modelName: string): Promise<{ message: string }> {+ return this.request<{ message: string }>('/models/download/cancel', {+ method: 'POST',+ body: JSON.stringify({ model_name: modelName } as ModelDownloadRequest),+ });+ }+// Task Managementasync getActiveTasks(): Promise<ActiveTasksResponse> {return this.request<ActiveTasksResponse>('/tasks/active');}+ async clearAllTasks(): Promise<{ message: string }> {+ return this.request<{ message: string }>('/tasks/clear', { method: 'POST' });+ }+// Audio Channelsasync listChannels(): Promise<Array<{diff --git a/app/src/lib/api/types.ts b/app/src/lib/api/types.tsindex 131c1be5..e4cfe1fb 100644--- a/app/src/lib/api/types.ts+++ b/app/src/lib/api/types.ts@@ -113,6 +113,7 @@ export interface ActiveDownloadTask {model_name: string;status: string;started_at: string;+ error?: string;}export interface ActiveGenerationTask {diff --git a/app/src/lib/hooks/useModelDownloadToast.tsx b/app/src/lib/hooks/useModelDownloadToast.tsxindex 2df221e1..d179ed22 100644--- a/app/src/lib/hooks/useModelDownloadToast.tsx+++ b/app/src/lib/hooks/useModelDownloadToast.tsx@@ -10,7 +10,7 @@ interface UseModelDownloadToastOptions {displayName: string;enabled?: boolean;onComplete?: () => void;- onError?: () => void;+ onError?: (error: string) => void;}/**@@ -101,7 +101,7 @@ export function useModelDownloadToast({break;case 'error':statusIcon = <XCircle className="h-4 w-4 text-destructive" />;- statusText = `Error: ${progress.error || 'Unknown error'}`;+ statusText = 'Download failed. See Problems panel for details.';break;case 'downloading':statusIcon = <Loader2 className="h-4 w-4 animate-spin" />;@@ -131,8 +131,7 @@ export function useModelDownloadToast({)}</div>),- duration: progress.status === 'complete' ? 5000 : Infinity,- variant: progress.status === 'error' ? 'destructive' : 'default',+ duration: progress.status === 'complete' || progress.status === 'error' ? 5000 : Infinity,});// Close connection and dismiss toast on completion or error@@ -169,7 +168,7 @@ export function useModelDownloadToast({onComplete();} else if (isError && onError) {console.log('[useModelDownloadToast] Download error, calling onError callback');- onError();+ onError(progress.error || 'Unknown error');}}}diff --git a/backend/backends/mlx_backend.py b/backend/backends/mlx_backend.pyindex c4ecc090..60c015de 100644--- a/backend/backends/mlx_backend.py+++ b/backend/backends/mlx_backend.py@@ -379,9 +379,17 @@ class MLXTTSBackend:return audio, sample_rate+WHISPER_HF_REPOS = {+ "base": "openai/whisper-base",+ "small": "openai/whisper-small",+ "medium": "openai/whisper-medium",+ "large": "openai/whisper-large-v3",+}++class MLXSTTBackend:"""MLX-based STT backend using mlx-audio Whisper."""-+def __init__(self, model_size: str = "base"):self.model = Noneself.model_size = model_size@@ -402,8 +410,8 @@ class MLXSTTBackend:"""try:from huggingface_hub import constants as hf_constants- model_name = f"openai/whisper-{model_size}"- repo_cache = Path(hf_constants.HF_HUB_CACHE) / ("models--" + model_name.replace("/", "--"))+ hf_repo = WHISPER_HF_REPOS.get(model_size, f"openai/whisper-{model_size}")+ repo_cache = Path(hf_constants.HF_HUB_CACHE) / ("models--" + hf_repo.replace("/", "--"))if not repo_cache.exists():return False@@ -474,7 +482,7 @@ class MLXSTTBackend:from mlx_audio.stt import load# MLX Whisper uses the standard OpenAI models- model_name = f"openai/whisper-{model_size}"+ model_name = WHISPER_HF_REPOS.get(model_size, f"openai/whisper-{model_size}")print(f"Loading MLX Whisper model {model_size}...")diff --git a/backend/backends/pytorch_backend.py b/backend/backends/pytorch_backend.pyindex d0cba11a..8059dc09 100644--- a/backend/backends/pytorch_backend.py+++ b/backend/backends/pytorch_backend.py@@ -369,9 +369,17 @@ class PyTorchTTSBackend:return audio, sample_rate+WHISPER_HF_REPOS = {+ "base": "openai/whisper-base",+ "small": "openai/whisper-small",+ "medium": "openai/whisper-medium",+ "large": "openai/whisper-large-v3",+}++class PyTorchSTTBackend:"""PyTorch-based STT backend using Whisper."""-+def __init__(self, model_size: str = "base"):self.model = Noneself.processor = None@@ -416,18 +424,18 @@ class PyTorchSTTBackend:"""try:from huggingface_hub import constants as hf_constants- model_name = f"openai/whisper-{model_size}"- repo_cache = Path(hf_constants.HF_HUB_CACHE) / ("models--" + model_name.replace("/", "--"))-+ hf_repo = WHISPER_HF_REPOS.get(model_size, f"openai/whisper-{model_size}")+ repo_cache = Path(hf_constants.HF_HUB_CACHE) / ("models--" + hf_repo.replace("/", "--"))+if not repo_cache.exists():return False-+# Check for .incomplete files - if any exist, download is still in progressblobs_dir = repo_cache / "blobs"if blobs_dir.exists() and any(blobs_dir.glob("*.incomplete")):print(f"[_is_model_cached] Found .incomplete files for whisper-{model_size}, treating as not cached")return False-+# Check that actual model weight files exist in snapshotssnapshots_dir = repo_cache / "snapshots"if snapshots_dir.exists():@@ -438,12 +446,12 @@ class PyTorchSTTBackend:if not has_weights:print(f"[_is_model_cached] No model weights found for whisper-{model_size}, treating as not cached")return False-+return Trueexcept Exception as e:print(f"[_is_model_cached] Error checking cache for whisper-{model_size}: {e}")return False-+async def load_model_async(self, model_size: Optional[str] = None):"""Lazy load the Whisper model.@@ -494,7 +502,7 @@ class PyTorchSTTBackend:# Import transformersfrom transformers import WhisperProcessor, WhisperForConditionalGeneration- model_name = f"openai/whisper-{model_size}"+ model_name = WHISPER_HF_REPOS.get(model_size, f"openai/whisper-{model_size}")print(f"[DEBUG] Model name: {model_name}")print(f"Loading Whisper model {model_size} on {self.device}...")diff --git a/backend/main.py b/backend/main.pyindex e218d237..0893e626 100644--- a/backend/main.py+++ b/backend/main.py@@ -1310,14 +1310,14 @@ async def get_model_status():whisper_base_id = "openai/whisper-base"whisper_small_id = "openai/whisper-small"whisper_medium_id = "openai/whisper-medium"- whisper_large_id = "openai/whisper-large"+ whisper_large_id = "openai/whisper-large-v3"else:tts_1_7b_id = "Qwen/Qwen3-TTS-12Hz-1.7B-Base"tts_0_6b_id = "Qwen/Qwen3-TTS-12Hz-0.6B-Base"whisper_base_id = "openai/whisper-base"whisper_small_id = "openai/whisper-small"whisper_medium_id = "openai/whisper-medium"- whisper_large_id = "openai/whisper-large"+ whisper_large_id = "openai/whisper-large-v3"model_configs = [{@@ -1586,6 +1586,39 @@ async def trigger_model_download(request: models.ModelDownloadRequest):return {"message": f"Model {request.model_name} download started"}[email protected]("/models/download/cancel")+async def cancel_model_download(request: models.ModelDownloadRequest):+ """Cancel or dismiss an errored/stale download task."""+ task_manager = get_task_manager()+ progress_manager = get_progress_manager()++ removed = task_manager.cancel_download(request.model_name)++ # Also clear progress state so the model doesn't show as downloading+ with progress_manager._lock:+ if request.model_name in progress_manager._progress:+ del progress_manager._progress[request.model_name]++ return {"message": f"Download task for {request.model_name} cancelled"}++[email protected]("/tasks/clear")+async def clear_all_tasks():+ """Clear all download tasks and progress state. Does not delete downloaded files."""+ task_manager = get_task_manager()+ progress_manager = get_progress_manager()++ task_manager._active_downloads.clear()+ task_manager._active_generations.clear()++ with progress_manager._lock:+ progress_manager._progress.clear()+ progress_manager._last_notify_time.clear()+ progress_manager._last_notify_progress.clear()++ return {"message": "All task state cleared"}++@app.delete("/models/{model_name}")async def delete_model(model_name: str):"""Delete a downloaded model from the HuggingFace cache."""@@ -1621,12 +1654,12 @@ async def delete_model(model_name: str):"model_type": "whisper",},"whisper-large": {- "hf_repo_id": "openai/whisper-large",+ "hf_repo_id": "openai/whisper-large-v3","model_size": "large","model_type": "whisper",},}-+if model_name not in model_configs:raise HTTPException(status_code=400, detail=f"Unknown model: {model_name}")@@ -1710,10 +1743,18 @@ async def get_active_tasks():progress = progress_map.get(model_name)if task:+ # Prefer task error, fall back to progress manager error+ error = task.error+ if not error:+ with progress_manager._lock:+ pm_data = progress_manager._progress.get(model_name)+ if pm_data:+ error = pm_data.get("error")active_downloads.append(models.ActiveDownloadTask(model_name=model_name,status=task.status,started_at=task.started_at,+ error=error,))elif progress:# Progress exists but no task - create from progress datadiff --git a/backend/models.py b/backend/models.pyindex 59e45405..3f55b591 100644--- a/backend/models.py+++ b/backend/models.py@@ -154,6 +154,7 @@ class ActiveDownloadTask(BaseModel):model_name: strstatus: strstarted_at: datetime+ error: Optional[str] = Noneclass ActiveGenerationTask(BaseModel):diff --git a/backend/utils/tasks.py b/backend/utils/tasks.pyindex 05b8e019..98ead512 100644--- a/backend/utils/tasks.py+++ b/backend/utils/tasks.py@@ -72,6 +72,13 @@ class TaskManager:"""Get all active generations."""return list(self._active_generations.values())+ def cancel_download(self, model_name: str) -> bool:+ """Cancel/dismiss a download task (removes it from active list)."""+ if model_name in self._active_downloads:+ del self._active_downloads[model_name]+ return True+ return False+def is_download_active(self, model_name: str) -> bool:"""Check if a download is active."""return model_name in self._active_downloads