Skip to content

A lightweight WebAssembly runtime that is fast, secure, and standards-compliant

[Cranelift] `(x - y) u> x --> y u> x` (#11521)

Bongjun Jang63fc25eaa362
diff --git a/cranelift/codegen/src/opts/icmp.isle b/cranelift/codegen/src/opts/icmp.isle
index 4eaf486b5b..cd26775470 100644
--- a/cranelift/codegen/src/opts/icmp.isle
+++ b/cranelift/codegen/src/opts/icmp.isle
@@ -290,3 +290,7 @@
(rule (simplify (eq cty x (bxor (ty_int bty) x y))) (subsume (eq cty y (iconst_u bty 0))))
(rule (simplify (ne cty x (bxor (ty_int bty) x y))) (subsume (ne cty y (iconst_u bty 0))))
+
+; (x - y) > x == y > x
+(rule (simplify (ugt cty (isub ty x y) x)) (ugt cty y x))
+(rule (simplify (ule cty (isub ty x y) x)) (ule cty y x))
diff --git a/cranelift/filetests/filetests/egraph/icmp.clif b/cranelift/filetests/filetests/egraph/icmp.clif
index c8f5eb9f8d..cf4825176d 100644
--- a/cranelift/filetests/filetests/egraph/icmp.clif
+++ b/cranelift/filetests/filetests/egraph/icmp.clif
@@ -223,3 +223,30 @@ block0():
; return v3
; }
+;; (x - y) u> x == y u> x
+function %ugt_isub_x_y_x(i32, i32) -> i8 fast {
+block0(v0: i32, v1: i32):
+ v2 = isub v0, v1
+ v3 = icmp ugt v2, v0
+ return v3
+}
+
+; function %ugt_isub_x_y_x(i32, i32) -> i8 fast {
+; block0(v0: i32, v1: i32):
+; v4 = icmp ugt v1, v0
+; return v4
+; }
+
+;; (x - y) u<= x == y u<= x
+function %ule_isub_x_y_x(i32, i32) -> i8 fast {
+block0(v0: i32, v1: i32):
+ v2 = isub v0, v1
+ v3 = icmp ule v2, v0
+ return v3
+}
+
+; function %ule_isub_x_y_x(i32, i32) -> i8 fast {
+; block0(v0: i32, v1: i32):
+; v4 = icmp ule v1, v0
+; return v4
+; }
\ No newline at end of file
diff --git a/cranelift/filetests/filetests/runtests/icmp.clif b/cranelift/filetests/filetests/runtests/icmp.clif
index 8fe798068e..2d280cb817 100644
--- a/cranelift/filetests/filetests/runtests/icmp.clif
+++ b/cranelift/filetests/filetests/runtests/icmp.clif
@@ -22,3 +22,25 @@ block0(v0: i8):
}
; run: %overflow_rhs_const(49) == 1
; run: %overflow_rhs_const(-65) == 0
+
+function %ugt_sub_swap(i32, i32) -> i8 fast {
+block0(v0: i32, v1: i32):
+ v2 = isub v0, v1
+ v3 = icmp ugt v2, v0
+ return v3
+}
+
+; run: %ugt_sub_swap(1, -49) == 1
+; run: %ugt_sub_swap(1, 2) == 1
+; run: %ugt_sub_swap(2, 1) == 0
+
+function %ule_sub_swap(i32, i32) -> i8 fast {
+block0(v0: i32, v1: i32):
+ v2 = isub v0, v1
+ v3 = icmp ule v2, v0
+ return v3
+}
+
+; run: %ule_sub_swap(1, -88) == 0
+; run: %ule_sub_swap(1, 2) == 0
+; run: %ule_sub_swap(2, 1) == 1