Skip to content

A lightweight WebAssembly runtime that is fast, secure, and standards-compliant

remove unused `MachInst::ref_type_regclass()` function (#13859)

Firestar9984ae9e6cce20
diff --git a/cranelift/codegen/src/isa/aarch64/inst/mod.rs b/cranelift/codegen/src/isa/aarch64/inst/mod.rs
index 2c325cbc49..acaeb8a431 100644
--- a/cranelift/codegen/src/isa/aarch64/inst/mod.rs
+++ b/cranelift/codegen/src/isa/aarch64/inst/mod.rs
@@ -1179,10 +1179,6 @@ impl MachInst for Inst {
128
}
- fn ref_type_regclass(_: &settings::Flags) -> RegClass {
- RegClass::Int
- }
-
fn gen_block_start(
is_indirect_branch_target: bool,
is_forward_edge_cfi_enabled: bool,
diff --git a/cranelift/codegen/src/isa/pulley_shared/inst/mod.rs b/cranelift/codegen/src/isa/pulley_shared/inst/mod.rs
index 6bbe69795e..df920f9bce 100644
--- a/cranelift/codegen/src/isa/pulley_shared/inst/mod.rs
+++ b/cranelift/codegen/src/isa/pulley_shared/inst/mod.rs
@@ -599,10 +599,6 @@ where
32
}
- fn ref_type_regclass(_settings: &settings::Flags) -> RegClass {
- RegClass::Int
- }
-
fn function_alignment() -> FunctionAlignment {
FunctionAlignment {
minimum: 1,
diff --git a/cranelift/codegen/src/isa/riscv64/inst/mod.rs b/cranelift/codegen/src/isa/riscv64/inst/mod.rs
index 61158afb91..ade5289b33 100644
--- a/cranelift/codegen/src/isa/riscv64/inst/mod.rs
+++ b/cranelift/codegen/src/isa/riscv64/inst/mod.rs
@@ -867,10 +867,6 @@ impl MachInst for Inst {
128
}
- fn ref_type_regclass(_settings: &settings::Flags) -> RegClass {
- RegClass::Int
- }
-
fn function_alignment() -> FunctionAlignment {
FunctionAlignment {
minimum: 2,
diff --git a/cranelift/codegen/src/isa/s390x/inst/emit_tests.rs b/cranelift/codegen/src/isa/s390x/inst/emit_tests.rs
index 98c7c2ca6b..e2ac640ffb 100644
--- a/cranelift/codegen/src/isa/s390x/inst/emit_tests.rs
+++ b/cranelift/codegen/src/isa/s390x/inst/emit_tests.rs
@@ -1,6 +1,7 @@
use crate::ir::{MachMemFlags, TrapCode};
use crate::isa::s390x::inst::*;
use crate::isa::s390x::settings as s390x_settings;
+use crate::settings;
#[cfg(test)]
fn simm20_zero() -> SImm20 {
diff --git a/cranelift/codegen/src/isa/s390x/inst/mod.rs b/cranelift/codegen/src/isa/s390x/inst/mod.rs
index a201bbdd3e..98a283f4b8 100644
--- a/cranelift/codegen/src/isa/s390x/inst/mod.rs
+++ b/cranelift/codegen/src/isa/s390x/inst/mod.rs
@@ -5,7 +5,7 @@ use crate::ir::{ExternalName, MemFlagsData, Type, types};
use crate::isa::s390x::abi::S390xMachineDeps;
use crate::isa::{CallConv, FunctionAlignment};
use crate::machinst::*;
-use crate::{CodegenError, CodegenResult, settings};
+use crate::{CodegenError, CodegenResult};
use alloc::boxed::Box;
use alloc::string::{String, ToString};
use alloc::vec::Vec;
@@ -1269,10 +1269,6 @@ impl MachInst for Inst {
0
}
- fn ref_type_regclass(_: &settings::Flags) -> RegClass {
- RegClass::Int
- }
-
fn gen_dummy_use(reg: Reg) -> Inst {
Inst::DummyUse { reg }
}
diff --git a/cranelift/codegen/src/isa/x64/inst/mod.rs b/cranelift/codegen/src/isa/x64/inst/mod.rs
index 37e79b2fae..bc4f249718 100644
--- a/cranelift/codegen/src/isa/x64/inst/mod.rs
+++ b/cranelift/codegen/src/isa/x64/inst/mod.rs
@@ -1467,10 +1467,6 @@ impl MachInst for Inst {
0
}
- fn ref_type_regclass(_: &settings::Flags) -> RegClass {
- RegClass::Int
- }
-
fn is_safepoint(&self) -> bool {
match self {
Inst::CallKnown { .. } | Inst::CallUnknown { .. } => true,
diff --git a/cranelift/codegen/src/machinst/mod.rs b/cranelift/codegen/src/machinst/mod.rs
index b9d57d099d..bfad55d17a 100644
--- a/cranelift/codegen/src/machinst/mod.rs
+++ b/cranelift/codegen/src/machinst/mod.rs
@@ -52,7 +52,6 @@ use crate::ir::{
use crate::isa::FunctionAlignment;
use crate::result::CodegenResult;
use crate::settings;
-use crate::settings::Flags;
use crate::value_label::ValueLabelsRanges;
use alloc::string::String;
use alloc::vec::Vec;
@@ -385,10 +384,6 @@ pub trait MachInst: Clone + Debug {
/// never required may leave this at zero.
fn worst_case_island_growth() -> CodeOffset;
- /// What is the register class used for reference types (GC-observable pointers)? Can
- /// be dependent on compilation flags.
- fn ref_type_regclass(_flags: &Flags) -> RegClass;
-
/// Is this a safepoint?
fn is_safepoint(&self) -> bool;