Skip to content

A lightweight WebAssembly runtime that is fast, secure, and standards-compliant

wasmtime-wasi-http: Only inject Host header in the default HTTP/1 send_request path (#13138)

Nam Se Hyuncc84f9863c8b
diff --git a/crates/wasi-http/src/p2/http_impl.rs b/crates/wasi-http/src/p2/http_impl.rs
index 9510f7a44d..ae73ef8a20 100644
--- a/crates/wasi-http/src/p2/http_impl.rs
+++ b/crates/wasi-http/src/p2/http_impl.rs
@@ -64,8 +64,6 @@ impl outgoing_handler::Host for WasiHttpCtxView<'_> {
let authority = req.authority.unwrap_or_else(String::new);
- builder = builder.header(hyper::header::HOST, &authority);
-
let mut uri = http::Uri::builder()
.scheme(scheme)
.authority(authority.clone());
diff --git a/crates/wasi-http/src/p2/mod.rs b/crates/wasi-http/src/p2/mod.rs
index 3090b32d05..0e6a4f2684 100644
--- a/crates/wasi-http/src/p2/mod.rs
+++ b/crates/wasi-http/src/p2/mod.rs
@@ -582,6 +582,14 @@ pub async fn default_send_request_handler(
use tokio::net::TcpStream;
use tokio::time::timeout;
+ if !request.headers().contains_key(hyper::header::HOST) {
+ if let Some(authority) = request.uri().authority() {
+ if let Ok(value) = hyper::header::HeaderValue::from_str(authority.as_str()) {
+ request.headers_mut().insert(hyper::header::HOST, value);
+ }
+ }
+ }
+
let authority = if let Some(authority) = request.uri().authority() {
if authority.port().is_some() {
authority.to_string()