Skip to content

A lightweight WebAssembly runtime that is fast, secure, and standards-compliant

wasi-http: make p3 get-headers immutable on both sides (#14614)

Xia Chaoe8e4f4239856
diff --git a/crates/wasi-http/src/p3/host/types.rs b/crates/wasi-http/src/p3/host/types.rs
index a8c86b5129..6ebf7481f8 100644
--- a/crates/wasi-http/src/p3/host/types.rs
+++ b/crates/wasi-http/src/p3/host/types.rs
@@ -385,7 +385,10 @@ impl HostRequest for WasiHttpCtxView<'_> {
fn get_headers(&mut self, req: Resource<Request>) -> wasmtime::Result<Resource<Headers>> {
let Request { headers, .. } = get_request(self.table, &req)?;
- push_fields(self.table, headers.clone())
+ // `get-headers` promises immutable headers; that includes requests built with `Request::new`.
+ let mut headers = headers.clone();
+ headers.set_immutable();
+ push_fields(self.table, headers)
}
}
@@ -560,7 +563,10 @@ impl HostResponse for WasiHttpCtxView<'_> {
fn get_headers(&mut self, res: Resource<Response>) -> wasmtime::Result<Resource<Headers>> {
let Response { headers, .. } = get_response(self.table, &res)?;
- push_fields(self.table, headers.clone())
+ // The response side makes the same promise as the request side.
+ let mut headers = headers.clone();
+ headers.set_immutable();
+ push_fields(self.table, headers)
}
}