Skip to content

Open-source AI browser agent for Chrome and Firefox (monorepo) 🧠

Validate nested Markdown fence indentation

Emre Sokullu009406567f17
diff --git a/src/chrome/src/ui/markdown-render.js b/src/chrome/src/ui/markdown-render.js
index 09f0473a2..71fef6e01 100644
--- a/src/chrome/src/ui/markdown-render.js
+++ b/src/chrome/src/ui/markdown-render.js
@@ -372,14 +372,20 @@ export function replaceMarkdownCodeFences(value, renderBlock, { streaming = fals
cursor = match.index + match.raw.replace(/\r?\n$/, '').length;
block = null;
}
- } else if (streaming && active.markdown && validOpening && info.trim()
- && fence[0] === active.fence[0] && fence.length >= active.fence.length
- && (!active.container.quoteDepth && !active.container.listPrefix
- || fenceCloserInContainer(active.container, container))) {
- // Models sometimes wrap a README in ```markdown and reuse ```lang
- // inside it. Recover only this named Markdown nesting; ordinary code
- // and correctly longer outer fences retain their literal contents.
- stack.push({ fence, markdown, container });
+ } else {
+ const nestedContainer = (indentationColumns(container.indentation) > 3 || container.leadingQuoteIndent > 3)
+ ? listContinuationContainer(source, match.index, prefix, indentation, noListScanPositions)
+ : container;
+ if (streaming && active.markdown && validOpening && info.trim()
+ && fence[0] === active.fence[0] && fence.length >= active.fence.length
+ && nestedContainer
+ && (!active.container.quoteDepth && !active.container.listPrefix
+ || fenceCloserInContainer(active.container, nestedContainer))) {
+ // Models sometimes wrap a README in ```markdown and reuse ```lang
+ // inside it. Recover only this named Markdown nesting; ordinary code
+ // and correctly longer outer fences retain their literal contents.
+ stack.push({ fence, markdown, container: nestedContainer });
+ }
}
}
diff --git a/src/firefox/src/ui/markdown-render.js b/src/firefox/src/ui/markdown-render.js
index 09f0473a2..71fef6e01 100644
--- a/src/firefox/src/ui/markdown-render.js
+++ b/src/firefox/src/ui/markdown-render.js
@@ -372,14 +372,20 @@ export function replaceMarkdownCodeFences(value, renderBlock, { streaming = fals
cursor = match.index + match.raw.replace(/\r?\n$/, '').length;
block = null;
}
- } else if (streaming && active.markdown && validOpening && info.trim()
- && fence[0] === active.fence[0] && fence.length >= active.fence.length
- && (!active.container.quoteDepth && !active.container.listPrefix
- || fenceCloserInContainer(active.container, container))) {
- // Models sometimes wrap a README in ```markdown and reuse ```lang
- // inside it. Recover only this named Markdown nesting; ordinary code
- // and correctly longer outer fences retain their literal contents.
- stack.push({ fence, markdown, container });
+ } else {
+ const nestedContainer = (indentationColumns(container.indentation) > 3 || container.leadingQuoteIndent > 3)
+ ? listContinuationContainer(source, match.index, prefix, indentation, noListScanPositions)
+ : container;
+ if (streaming && active.markdown && validOpening && info.trim()
+ && fence[0] === active.fence[0] && fence.length >= active.fence.length
+ && nestedContainer
+ && (!active.container.quoteDepth && !active.container.listPrefix
+ || fenceCloserInContainer(active.container, nestedContainer))) {
+ // Models sometimes wrap a README in ```markdown and reuse ```lang
+ // inside it. Recover only this named Markdown nesting; ordinary code
+ // and correctly longer outer fences retain their literal contents.
+ stack.push({ fence, markdown, container: nestedContainer });
+ }
}
}
diff --git a/test/markdown-render.mjs b/test/markdown-render.mjs
index 6b385ef80..8610fb1ec 100644
--- a/test/markdown-render.mjs
+++ b/test/markdown-render.mjs
@@ -64,6 +64,14 @@ for (const build of ['chrome', 'firefox']) {
assert.deepEqual(preContents(renderSkillMarkdown(source)), [escapeHtml(nested)]);
});
+ test(`${build}: Markdown wrappers keep over-indented fences literal`, () => {
+ const nested = ' ```js\nliteral\n';
+ const source = `\`\`\`markdown\n${nested}\`\`\`\nAfter`;
+ assert.deepEqual(preContents(formatMarkdown(source)), [helpers.escapeCodeHtml(nested)]);
+ assert.match(formatMarkdown(source), /After/);
+ assert.deepEqual(preContents(renderSkillMarkdown(source)), [escapeHtml(nested)]);
+ });
+
test(`${build}: fence length, marker and whole-line closers protect literal code`, () => {
const cases = [
['````markdown', '```js\nconst x = 1;\n```\n', '````'],