Skip to content

Open-source AI browser agent for Chrome and Firefox (monorepo) 🧠

fix(newtab): round-84 review — the Act eligibility query re-checks the provider even when Act is already selected

Claude080cb7264e27
diff --git a/src/chrome/src/ui/sidepanel.js b/src/chrome/src/ui/sidepanel.js
index dcbb74fca..756f2aadc 100644
--- a/src/chrome/src/ui/sidepanel.js
+++ b/src/chrome/src/ui/sidepanel.js
@@ -14604,15 +14604,17 @@ async function inBrowserProviderBlocksMode() {
// `switchMode: false` only answers whether Act may run; the caller switches the mode itself (the
// new-tab handoff does so after re-checking the composer, which can change while this awaits).
+// That query also re-checks the provider when Act is already selected: picking an Ask-only
+// provider (WebGPU) leaves the mode as it was.
async function ensureActMode({ switchMode = true } = {}) {
if (isSelectionGroundedForTab(currentTabId)) {
showComposerToast(t('sp.selection_scope.description'), { duration: 5000 });
return false;
}
- if (agentMode === 'act') return true;
+ if (agentMode === 'act' && switchMode) return true;
if (await inBrowserProviderBlocksMode()) return false;
if (autoModeSelection) return true;
- if (switchMode) setMode('act');
+ if (switchMode && agentMode !== 'act') setMode('act');
return true;
}
diff --git a/test/newtab.mjs b/test/newtab.mjs
index f5686378c..2bc97b76e 100644
--- a/test/newtab.mjs
+++ b/test/newtab.mjs
@@ -2689,6 +2689,9 @@ test('round-82: the Apps popup reads one appsPinned key everywhere', () => {
test('round-83: ensureActMode can answer eligibility without switching the panel mode', () => {
for (const browser of ['chrome', 'firefox']) {
const src = readFileSync(path.join(root, 'src', browser, 'src/ui/sidepanel.js'), 'utf8');
- assert.match(src, /async function ensureActMode\(\{ switchMode = true \} = \{\}\)[\s\S]*?if \(switchMode\) setMode\('act'\);/, browser);
+ assert.match(src, /async function ensureActMode\(\{ switchMode = true \} = \{\}\)[\s\S]*?setMode\('act'\);/, browser);
}
+ const chrome = readFileSync(path.join(root, 'src', 'chrome', 'src/ui/sidepanel.js'), 'utf8');
+ // already in Act: the eligibility query still looks at the provider (WebGPU is Ask-only)
+ assert.match(chrome, /if \(agentMode === 'act' && switchMode\) return true;\s*if \(await inBrowserProviderBlocksMode\(\)\) return false;/);
});