Open-source AI browser agent for Chrome and Firefox (monorepo) ðŸ§
JavaScript ai-agentai-agentsai-toolsbrowser-aibrowser-automationbrowser-extensionchrome-aichrome-devtoolschrome-extensionchrome-extensionsfirefox-addonfirefox-addonsfirefox-extensionfirefox-extensionsgemmagemma4minimaxoffline-aioffline-llmqwen
fix: bound visible layer metadata in page reads
Barack Sokullu145ca7baa7c9
diff --git a/src/chrome/src/agent/read-page-window.js b/src/chrome/src/agent/read-page-window.jsindex ab2a6c6c3..f532ea421 100644--- a/src/chrome/src/agent/read-page-window.js+++ b/src/chrome/src/agent/read-page-window.js@@ -88,6 +88,20 @@ function compactCoreResult(result) {const shortString = (value, limit) => (typeof value === 'string' ? value.slice(0, limit) : value);+ const finiteCoord = value => Number.isFinite(value) ? value : 0;+ const visibleLayers = Array.isArray(result.visibleLayers)+ ? result.visibleLayers.slice(0, 4).map(layer => ({+ role: shortString(layer?.role, 80),+ text: shortString(layer?.text, 240),+ position: shortString(layer?.position, 20),+ rect: {+ x: finiteCoord(layer?.rect?.x),+ y: finiteCoord(layer?.rect?.y),+ w: finiteCoord(layer?.rect?.w),+ h: finiteCoord(layer?.rect?.h),+ },+ }))+ : undefined;const pageGate = result.pageGate && typeof result.pageGate === 'object'? {type: shortString(result.pageGate.type, 100),@@ -109,7 +123,7 @@ function compactCoreResult(result) {accessState: result.accessState,accessGateEvidence: result.accessGateEvidence,...(pageGate ? { pageGate } : {}),- ...(Array.isArray(result.visibleLayers) ? { visibleLayers: result.visibleLayers.slice(0, 4) } : {}),+ ...(visibleLayers ? { visibleLayers } : {}),auxiliaryContentTruncated: true,}, result.text);}@@ -180,6 +194,9 @@ export function fitReadPageWindowResult(result, maxChars = 8000) {}if (!fits(withDeliveredText(compact, ''))) {compact = compactCoreResult(result);+ while (compact.visibleLayers?.length && !fits(withDeliveredText(compact, ''))) {+ compact = { ...compact, visibleLayers: compact.visibleLayers.slice(0, -1) };+ }}let low = 0;diff --git a/src/chrome/src/cdp/cdp-client.js b/src/chrome/src/cdp/cdp-client.jsindex c4b968926..db3bc6604 100644--- a/src/chrome/src/cdp/cdp-client.js+++ b/src/chrome/src/cdp/cdp-client.js@@ -3407,7 +3407,7 @@ export class CDPClient {})) continue;layers.push({element: el,- role: el.getAttribute('role') || el.tagName.toLowerCase(),+ role: (el.getAttribute('role') || el.tagName.toLowerCase()).slice(0, 80),text,position: style.position,rect: { x: Math.round(r.x), y: Math.round(r.y), w: Math.round(r.width), h: Math.round(r.height) },diff --git a/src/chrome/src/content/content.js b/src/chrome/src/content/content.jsindex abaef38ee..81c835b64 100644--- a/src/chrome/src/content/content.js+++ b/src/chrome/src/content/content.js@@ -3329,7 +3329,7 @@})) continue;layers.push({element: el,- role: el.getAttribute('role') || el.tagName.toLowerCase(),+ role: (el.getAttribute('role') || el.tagName.toLowerCase()).slice(0, 80),text,position: style.position,rect: { x: Math.round(r.x), y: Math.round(r.y), w: Math.round(r.width), h: Math.round(r.height) },diff --git a/src/firefox/src/agent/read-page-window.js b/src/firefox/src/agent/read-page-window.jsindex ab2a6c6c3..f532ea421 100644--- a/src/firefox/src/agent/read-page-window.js+++ b/src/firefox/src/agent/read-page-window.js@@ -88,6 +88,20 @@ function compactCoreResult(result) {const shortString = (value, limit) => (typeof value === 'string' ? value.slice(0, limit) : value);+ const finiteCoord = value => Number.isFinite(value) ? value : 0;+ const visibleLayers = Array.isArray(result.visibleLayers)+ ? result.visibleLayers.slice(0, 4).map(layer => ({+ role: shortString(layer?.role, 80),+ text: shortString(layer?.text, 240),+ position: shortString(layer?.position, 20),+ rect: {+ x: finiteCoord(layer?.rect?.x),+ y: finiteCoord(layer?.rect?.y),+ w: finiteCoord(layer?.rect?.w),+ h: finiteCoord(layer?.rect?.h),+ },+ }))+ : undefined;const pageGate = result.pageGate && typeof result.pageGate === 'object'? {type: shortString(result.pageGate.type, 100),@@ -109,7 +123,7 @@ function compactCoreResult(result) {accessState: result.accessState,accessGateEvidence: result.accessGateEvidence,...(pageGate ? { pageGate } : {}),- ...(Array.isArray(result.visibleLayers) ? { visibleLayers: result.visibleLayers.slice(0, 4) } : {}),+ ...(visibleLayers ? { visibleLayers } : {}),auxiliaryContentTruncated: true,}, result.text);}@@ -180,6 +194,9 @@ export function fitReadPageWindowResult(result, maxChars = 8000) {}if (!fits(withDeliveredText(compact, ''))) {compact = compactCoreResult(result);+ while (compact.visibleLayers?.length && !fits(withDeliveredText(compact, ''))) {+ compact = { ...compact, visibleLayers: compact.visibleLayers.slice(0, -1) };+ }}let low = 0;diff --git a/src/firefox/src/content/content.js b/src/firefox/src/content/content.jsindex 7f1374d22..9d69c4127 100644--- a/src/firefox/src/content/content.js+++ b/src/firefox/src/content/content.js@@ -205,7 +205,7 @@})) continue;layers.push({element: el,- role: el.getAttribute('role') || el.tagName.toLowerCase(),+ role: (el.getAttribute('role') || el.tagName.toLowerCase()).slice(0, 80),text,position: style.position,rect: { x: Math.round(r.x), y: Math.round(r.y), w: Math.round(r.width), h: Math.round(r.height) },diff --git a/test/fixtures/run.mjs b/test/fixtures/run.mjsindex 4cf068b17..59c45bd34 100644--- a/test/fixtures/run.mjs+++ b/test/fixtures/run.mjs@@ -1196,6 +1196,22 @@ test('read_page windows keep layer context when oversized output is compacted',if (JSON.stringify(fitted).length > 1200 || fitted.visibleLayers?.[0]?.text !== 'Open filters dialog') {throw new Error(`${label}: bounded read lost the visible layer: ${JSON.stringify(fitted)}`);}+ const oversized = {+ ...raw,+ visibleLayers: [+ { ...raw.visibleLayers[0], role: 'dialog' + 'x'.repeat(10000) },+ ...Array.from({ length: 3 }, (_, i) => ({+ role: 'toolbar', text: `Toolbar ${i} ${'x'.repeat(220)}`, position: 'fixed',+ rect: { x: 0, y: i * 30, w: 800, h: 30 },+ })),+ ],+ };+ const bounded = fitWindow(applyWindow(oversized, { limit: 6000 }), 1200);+ if (JSON.stringify(bounded).length > 1200+ || bounded.visibleLayers?.[0]?.text !== 'Open filters dialog'+ || bounded.visibleLayers[0].role.length > 80) {+ throw new Error(`${label}: oversized layer metadata broke the read_page cap: ${JSON.stringify(bounded)}`);+ }}});