Open-source AI browser agent for Chrome and Firefox (monorepo) ðŸ§
JavaScript ai-agentai-agentsai-toolsbrowser-aibrowser-automationbrowser-extensionchrome-aichrome-devtoolschrome-extensionchrome-extensionsfirefox-addonfirefox-addonsfirefox-extensionfirefox-extensionsgemmagemma4minimaxoffline-aioffline-llmqwen
fix(linkedin): detect shadow modal boundaries
16Miku2c2c7057b541
diff --git a/src/chrome/src/content/content.js b/src/chrome/src/content/content.jsindex 0701840d4..518729d81 100644--- a/src/chrome/src/content/content.js+++ b/src/chrome/src/content/content.js@@ -5176,9 +5176,14 @@|| _composedClosestElement(link, 'form')|| link.hasAttribute?.('download')|| (link.getAttribute?.('role') && link.getAttribute('role') !== 'link')) return 'blocked';- const modal = blockingModal && _isComposedAncestor(blockingModal, link)- ? blockingModal- : _composedClosestElement(link, 'dialog,[role="dialog"],[role="alertdialog"]');+ const composedModal = _composedClosestElement(+ link,+ 'dialog,[role="dialog"],[role="alertdialog"],[data-overlay],.modal.show,.modal-overlay,.overlay,'+ + '[class*="modal"][class*="open"],[class*="overlay"][class*="active"],'+ + '[class*="DialogOverlay"],[class*="ModalOverlay"]',+ );+ const modal = composedModal+ || (blockingModal && _isComposedAncestor(blockingModal, link) ? blockingModal : null);const unresolved = () => modal ? 'blocked' : 'none';try {const href = String(link.getAttribute('href') || '').trim();diff --git a/src/firefox/src/content/content.js b/src/firefox/src/content/content.jsindex 6e2f10ce9..4fab3b570 100644--- a/src/firefox/src/content/content.js+++ b/src/firefox/src/content/content.js@@ -4339,9 +4339,14 @@|| _composedClosestElement(link, 'form')|| link.hasAttribute?.('download')|| (link.getAttribute?.('role') && link.getAttribute('role') !== 'link')) return 'blocked';- const modal = blockingModal && _isComposedAncestor(blockingModal, link)- ? blockingModal- : _composedClosestElement(link, 'dialog,[role="dialog"],[role="alertdialog"]');+ const composedModal = _composedClosestElement(+ link,+ 'dialog,[role="dialog"],[role="alertdialog"],[data-overlay],.modal.show,.modal-overlay,.overlay,'+ + '[class*="modal"][class*="open"],[class*="overlay"][class*="active"],'+ + '[class*="DialogOverlay"],[class*="ModalOverlay"]',+ );+ const modal = composedModal+ || (blockingModal && _isComposedAncestor(blockingModal, link) ? blockingModal : null);const unresolved = () => modal ? 'blocked' : 'none';try {const href = String(link.getAttribute('href') || '').trim();diff --git a/test/fixtures/message-recipient-navigation.mjs b/test/fixtures/message-recipient-navigation.mjsindex bba4bc678..62c81f7a4 100644--- a/test/fixtures/message-recipient-navigation.mjs+++ b/test/fixtures/message-recipient-navigation.mjs@@ -223,6 +223,27 @@ export function registerMessageRecipientNavigationFixtures({assert.equal((await guard('click', args))?.noDispatch, true);});+ register(`${kind}: LinkedIn safety redirects cannot escape a shadow-root heuristic modal`, async (page) => {+ const { guard, probe } = await setup(page);+ const ref_id = await page.evaluate(() => {+ history.replaceState(null, '', '/in/alice/overlay/contact-info/');+ document.querySelector('#chat').hidden = false;+ const host = document.createElement('div');+ document.body.append(host);+ const shadow = host.attachShadow({ mode: 'open' });+ shadow.innerHTML = `+ <div class="modal show" style="position:fixed;inset:0;background:white">+ <a href="/safety/go/?url=https%3A%2F%2Fportfolio.example%2F" style="display:inline-block;padding:8px">Shadow heuristic modal link</a>+ </div>`;+ return window.__wb_ax_ref(shadow.querySelector('a'));+ });+ const args = { ref_id };+ const result = await probe('click_ax', args);+ assert.equal(result.navigationBlocked, true, JSON.stringify(result));+ assert.equal(result.conclusive, false, JSON.stringify(result));+ assert.equal((await guard('click_ax', args))?.noDispatch, true);+ });+register(`${kind}: LinkedIn recipient guard rejects ambiguous navigation and action lookalikes`, async (page) => {const { guard } = await setup(page);for (const href of [