Skip to content

Open-source AI browser agent for Chrome and Firefox (monorepo) 🧠

Firefox sparse config patch: drop the Chrome-only provider without touching the mode

Claude2cdf68d3107a
diff --git a/src/firefox/src/config-transfer.js b/src/firefox/src/config-transfer.js
index a11c7988f..00cd53ee4 100644
--- a/src/firefox/src/config-transfer.js
+++ b/src/firefox/src/config-transfer.js
@@ -270,8 +270,16 @@ function validSettingValue(key, value) {
// provider as it is.
function dropChromeOnlyDecisionProvider(settings, { sparse = false } = {}) {
if (settings.decisionProvider !== 'webgpu_chat') return;
- if (sparse) delete settings.decisionProvider;
- else settings.decisionProvider = DEFAULT_CONFIG_SETTINGS.decisionProvider;
+ if (sparse) {
+ delete settings.decisionProvider;
+ // A sparse patch only changes what it names: a provider-only patch must not
+ // rewrite the mode of an existing On or Off profile. A mode the patch does
+ // carry is still downgraded, as in a full restore.
+ if (Object.hasOwn(settings, 'systemOneEnabled')) settings.systemOneEnabled = false;
+ if (Object.hasOwn(settings, 'decisionMode') && settings.decisionMode !== 'off') settings.decisionMode = 'auto';
+ return;
+ }
+ settings.decisionProvider = DEFAULT_CONFIG_SETTINGS.decisionProvider;
settings.systemOneEnabled = false;
// On with that provider becomes Auto here; an explicit Off stays off.
if (settings.decisionMode !== 'off') settings.decisionMode = 'auto';
diff --git a/test/decision-mode.mjs b/test/decision-mode.mjs
index 15d3d8d15..2a48a096f 100644
--- a/test/decision-mode.mjs
+++ b/test/decision-mode.mjs
@@ -232,3 +232,20 @@ test('Firefox imports a Chrome On selection of the Chrome-only chat model in Aut
const off = transfer.parseConfigImport(JSON.stringify({ ...chromeExport, settings: { ...chromeExport.settings, decisionMode: 'off' } })).settings;
assert.equal(off.decisionMode, 'off', 'an explicit Off stays off');
});
+
+test('a provider-only Chrome patch leaves the Firefox mode alone', async () => {
+ const transfer = await import('../src/firefox/src/config-transfer.js');
+ const sparse = (settings) => transfer.parseConfigPatchImport(JSON.stringify({ schema: transfer.CONFIG_SCHEMA, settings })).settings;
+ const providerOnly = sparse({ decisionProvider: 'webgpu_chat' });
+ assert.deepEqual(providerOnly, {}, 'the unusable provider is dropped and nothing else is invented');
+ // Merged over an existing On or Off profile, nothing about the mode changes.
+ for (const mode of ['on', 'off']) {
+ const stored = { decisionMode: mode, systemOneEnabled: mode === 'on', decisionProvider: 'openrouter' };
+ assert.deepEqual({ ...stored, ...transfer.mergeConfigPatchSettings(stored, providerOnly) }, stored, `${mode} profile unchanged`);
+ }
+ // A patch that names the mode still downgrades On, and keeps an explicit Off.
+ const named = sparse({ decisionProvider: 'webgpu_chat', decisionMode: 'on', systemOneEnabled: true });
+ assert.equal(named.decisionMode, 'auto'); assert.equal(named.systemOneEnabled, false);
+ assert.equal(sparse({ decisionProvider: 'webgpu_chat', decisionMode: 'off' }).decisionMode, 'off');
+ assert.equal(Object.hasOwn(sparse({ decisionProvider: 'webgpu_chat', decisionMode: 'off' }), 'systemOneEnabled'), false);
+});