Skip to content

Open-source AI browser agent for Chrome and Firefox (monorepo) 🧠

Handle empty Markdown list fence containers

Emre Sokullu314a112a6c61
diff --git a/src/chrome/src/ui/markdown-render.js b/src/chrome/src/ui/markdown-render.js
index dbb95485a..6876a63f2 100644
--- a/src/chrome/src/ui/markdown-render.js
+++ b/src/chrome/src/ui/markdown-render.js
@@ -103,8 +103,13 @@ function indentationColumns(value) {
}
function listPrefixAt(value, startColumn = 0) {
- const marker = String(value).match(/^[ \t]*(?:[-+*]|\d+[.)])/);
- if (!marker || !/^[ \t]/.test(value[marker[0].length] || '')) return null;
+ const source = String(value);
+ const marker = source.match(/^[ \t]*(?:[-+*]|\d+[.)])/);
+ const leadingIndentation = marker?.[0].match(/^[ \t]*/)?.[0] || '';
+ const next = source[marker?.[0].length];
+ if (!marker
+ || (startColumn === 0 && indentationColumns(leadingIndentation) > 3)
+ || (next && !/^[ \t]$/.test(next))) return null;
let offset = marker[0].length;
let column = indentationColumnsAt(marker[0], startColumn);
let paddingColumns = 0;
@@ -114,7 +119,7 @@ function listPrefixAt(value, startColumn = 0) {
column += width;
offset += 1;
}
- return String(value).slice(0, marker[0].length + (paddingColumns <= 4 ? offset - marker[0].length : 1));
+ return source.slice(0, marker[0].length + (paddingColumns <= 4 ? offset - marker[0].length : 1));
}
function quoteMarkerAt(value, startColumn = 0) {
diff --git a/src/firefox/src/ui/markdown-render.js b/src/firefox/src/ui/markdown-render.js
index dbb95485a..6876a63f2 100644
--- a/src/firefox/src/ui/markdown-render.js
+++ b/src/firefox/src/ui/markdown-render.js
@@ -103,8 +103,13 @@ function indentationColumns(value) {
}
function listPrefixAt(value, startColumn = 0) {
- const marker = String(value).match(/^[ \t]*(?:[-+*]|\d+[.)])/);
- if (!marker || !/^[ \t]/.test(value[marker[0].length] || '')) return null;
+ const source = String(value);
+ const marker = source.match(/^[ \t]*(?:[-+*]|\d+[.)])/);
+ const leadingIndentation = marker?.[0].match(/^[ \t]*/)?.[0] || '';
+ const next = source[marker?.[0].length];
+ if (!marker
+ || (startColumn === 0 && indentationColumns(leadingIndentation) > 3)
+ || (next && !/^[ \t]$/.test(next))) return null;
let offset = marker[0].length;
let column = indentationColumnsAt(marker[0], startColumn);
let paddingColumns = 0;
@@ -114,7 +119,7 @@ function listPrefixAt(value, startColumn = 0) {
column += width;
offset += 1;
}
- return String(value).slice(0, marker[0].length + (paddingColumns <= 4 ? offset - marker[0].length : 1));
+ return source.slice(0, marker[0].length + (paddingColumns <= 4 ? offset - marker[0].length : 1));
}
function quoteMarkerAt(value, startColumn = 0) {
diff --git a/test/markdown-render.mjs b/test/markdown-render.mjs
index d6789381c..8df61b1a0 100644
--- a/test/markdown-render.mjs
+++ b/test/markdown-render.mjs
@@ -136,6 +136,9 @@ for (const build of ['chrome', 'firefox']) {
}), 'BLOCK\nAfter');
assert.deepEqual(blocks, [{ info: 'text', code: 'hello\n' }]);
+ const indentedListFence = ' - ```text\n hello\n ```\nAfter';
+ assert.equal(helpers.replaceMarkdownCodeFences(indentedListFence, () => 'BLOCK'), indentedListFence);
+
const excessListPadding = '- ```text\n literal\n ```\nAfter';
assert.equal(helpers.replaceMarkdownCodeFences(excessListPadding, () => 'BLOCK'), excessListPadding);
@@ -409,6 +412,14 @@ for (const build of ['chrome', 'firefox']) {
assert.deepEqual(emptyBlocks, [{ info: 'text', code: '' }]);
}
+ const emptyListItem = '-\n ```text\n hi\nOutside';
+ const emptyListBlocks = [];
+ assert.equal(helpers.replaceMarkdownCodeFences(emptyListItem, (info, code) => {
+ emptyListBlocks.push({ info, code });
+ return 'BLOCK';
+ }), '-\n BLOCK\nOutside');
+ assert.deepEqual(emptyListBlocks, [{ info: 'text', code: 'hi\n' }]);
+
const trailingQuoteBlank = '> ```text\n> hello\n>\n';
const trailingQuoteBlocks = [];
assert.equal(helpers.replaceMarkdownCodeFences(trailingQuoteBlank, (info, code) => {