Open-source AI browser agent for Chrome and Firefox (monorepo) ðŸ§
JavaScript ai-agentai-agentsai-toolsbrowser-aibrowser-automationbrowser-extensionchrome-aichrome-devtoolschrome-extensionchrome-extensionsfirefox-addonfirefox-addonsfirefox-extensionfirefox-extensionsgemmagemma4minimaxoffline-aioffline-llmqwen
fix(newtab): round-72 review — the hold allowance is dropped once the last delayed task has been claimed
Claude335383a2f550
diff --git a/src/chrome/src/ui/newtab-handoff.js b/src/chrome/src/ui/newtab-handoff.jsindex d6534474a..4afb103f3 100644--- a/src/chrome/src/ui/newtab-handoff.js+++ b/src/chrome/src/ui/newtab-handoff.js@@ -318,7 +318,14 @@ export function createNewtabHandoff({}// A task handed back earlier may be waiting behind the one just claimed (removing a// primary record raises no change event this panel acts on), so look again if so.- if (key === primaryKey) claimedOne = await retryWaiting();+ if (key === primaryKey) {+ claimedOne = await retryWaiting();+ // Nothing else was delayed by the hold: whatever arrives next is judged on its own age.+ if (!claimedOne) heldAllowanceMs.delete(Number(tabId));+ } else {+ // A hand-back was claimed; look again, which finds the next one or clears the allowance.+ claimedOne = true;+ }return true;} catch {return false;diff --git a/src/firefox/src/ui/newtab-handoff.js b/src/firefox/src/ui/newtab-handoff.jsindex d6534474a..4afb103f3 100644--- a/src/firefox/src/ui/newtab-handoff.js+++ b/src/firefox/src/ui/newtab-handoff.js@@ -318,7 +318,14 @@ export function createNewtabHandoff({}// A task handed back earlier may be waiting behind the one just claimed (removing a// primary record raises no change event this panel acts on), so look again if so.- if (key === primaryKey) claimedOne = await retryWaiting();+ if (key === primaryKey) {+ claimedOne = await retryWaiting();+ // Nothing else was delayed by the hold: whatever arrives next is judged on its own age.+ if (!claimedOne) heldAllowanceMs.delete(Number(tabId));+ } else {+ // A hand-back was claimed; look again, which finds the next one or clears the allowance.+ claimedOne = true;+ }return true;} catch {return false;diff --git a/test/newtab.mjs b/test/newtab.mjsindex 38870e64f..41501d3da 100644--- a/test/newtab.mjs+++ b/test/newtab.mjs@@ -642,6 +642,45 @@ for (const browser of ['chrome', 'firefox']) {assert.equal(input.value, '', 'a task created after startup uses the ordinary window');});+ test(`${browser}: the hold allowance is dropped once the delayed task has been claimed`, async () => {+ const key3 = newtabHandoffKey(3);+ const store = { [key3]: { id: 'A', tabId: 3, text: 'task A', mode: 'ask', createdAt: 99_000 } };+ const state = { clock: 100_000 };+ const input = { value: '', dispatchEvent() {}, focus() {} };+ let releaseA;+ const gateA = new Promise((r) => { releaseA = r; });+ const handoff = createNewtabHandoff({+ storage: {+ get: async (k) => (k in store ? { [k]: store[k] } : {}),+ remove: async (k) => { delete store[k]; },+ set: async (o) => Object.assign(store, o),+ },+ getCurrentTabId: () => 3,+ getIsProcessing: () => false,+ getIsBlocked: () => false,+ getIsDocumentVisible: () => true,+ doc: { addEventListener() {} },+ setMode() {},+ getInputEl: () => input,+ autoResizeInput() {},+ sendMessage: async () => { await gateA; input.value = ''; return true; },+ now: () => state.clock,+ });+ await handoff.start();+ // an Act task waits behind A's slow send (nothing is sent for it, so no later look follows)+ store[key3] = { id: 'B', tabId: 3, text: 'task B', mode: 'act', createdAt: 99_800 };+ await handoff.consume();+ state.clock = 135_000; // B is 35 s old because of the hold+ releaseA();+ for (let i = 0; i < 6; i++) await new Promise((r) => setTimeout(r, 0));+ assert.equal(input.value, 'task B', 'the delayed task is accepted');+ // a later, unrelated task that is genuinely stale (40 s) must not borrow the allowance+ input.value = '';+ store[key3] = { id: 'C', tabId: 3, text: 'task C', mode: 'act', createdAt: state.clock - 40_000 };+ await handoff.consume();+ assert.equal(input.value, '', 'it is judged on its own age');+ });+test(`${browser}: a declined send never refills another tab's composer; the task goes back to its own tab`, async () => {const key3 = newtabHandoffKey(3);const store = { [key3]: { id: 'r1', tabId: 3, text: 'for tab three', mode: 'ask', createdAt: 99_000 } };