Skip to content

Open-source AI browser agent for Chrome and Firefox (monorepo) 🧠

fix: preserve consent clicks inside same-origin iframes

Emre Sokullu34f2dabb16fa
diff --git a/src/chrome/src/content/autoconsent-runtime.js b/src/chrome/src/content/autoconsent-runtime.js
index 0682a38a5..986684cde 100644
--- a/src/chrome/src/content/autoconsent-runtime.js
+++ b/src/chrome/src/content/autoconsent-runtime.js
@@ -56,7 +56,11 @@ export function guardCookieBannerInstance(consent, hasCoverage) {
const elements = dom.elementSelector(selector);
if (!elements.length) return false;
for (const element of all ? elements : elements.slice(0, 1)) {
- if (!await dom.clickElement(element)) return false;
+ // Selector chains can enter a same-origin iframe. Upstream clickElement
+ // rejects that realm's HTMLElement; upstream selector clicks do not.
+ await requireCoverage();
+ element.click();
+ await requireCoverage();
}
return true;
};
diff --git a/src/firefox/src/content/autoconsent-runtime.js b/src/firefox/src/content/autoconsent-runtime.js
index 0682a38a5..986684cde 100644
--- a/src/firefox/src/content/autoconsent-runtime.js
+++ b/src/firefox/src/content/autoconsent-runtime.js
@@ -56,7 +56,11 @@ export function guardCookieBannerInstance(consent, hasCoverage) {
const elements = dom.elementSelector(selector);
if (!elements.length) return false;
for (const element of all ? elements : elements.slice(0, 1)) {
- if (!await dom.clickElement(element)) return false;
+ // Selector chains can enter a same-origin iframe. Upstream clickElement
+ // rejects that realm's HTMLElement; upstream selector clicks do not.
+ await requireCoverage();
+ element.click();
+ await requireCoverage();
}
return true;
};
diff --git a/test/cookie-banner-ui.mjs b/test/cookie-banner-ui.mjs
index 6377178e9..8ce64e09b 100644
--- a/test/cookie-banner-ui.mjs
+++ b/test/cookie-banner-ui.mjs
@@ -7,6 +7,7 @@
// - a consent-looking iframe is injected, but the same URL on a CAPTCHA host
// (hcaptcha.com) never is;
// - a rule whose opt-out needs a page-world eval snippet completes;
+// - selector-chain rules can click buttons inside same-origin iframes;
// - WebBrain's own rules decline Efilli banners inside a shadow root (Efilli's
// English and Turkish templates, a renamed layout found by its Turkish text,
// hepsiburada's layout) and mediamarkt.com.tr's consent layer;
@@ -210,6 +211,14 @@ const server = createServer((req, res) => {
const url = new URL(req.url, 'http://localhost');
const host = String(req.headers.host || '').split(':')[0];
const script = url.pathname.match(/^\/efilli-(stock|turkish|inline|hepsiburada)\.js$/);
+ if (url.pathname === '/iframe-choice.js') {
+ res.setHeader('Content-Type', 'application/javascript; charset=utf-8');
+ res.end(`document.querySelector('button').onclick = () => {
+ parent.document.documentElement.dataset.consent = 'refused';
+ window.frameElement.remove();
+ };`);
+ return;
+ }
if (url.pathname === '/late-banner.js') {
res.setHeader('Content-Type', 'application/javascript; charset=utf-8');
res.end(lateBannerScript);
@@ -222,7 +231,13 @@ const server = createServer((req, res) => {
return;
}
res.setHeader('Content-Type', 'text/html; charset=utf-8');
- if (url.pathname.startsWith('/late-banner')) {
+ if (url.pathname === '/iframe-consent') {
+ res.end('<!doctype html><html><head><title>Iframe consent fixture</title></head><body><h1>Fixture shop</h1>'
+ + '<div id="fast-cmp-root"><iframe id="fast-cmp-iframe" src="/iframe-button"></iframe></div></body></html>');
+ } else if (url.pathname === '/iframe-button') {
+ res.end('<!doctype html><html><body><div class="fast-cmp-home-refuse"><button>Refuse</button></div>'
+ + '<script src="/iframe-choice.js"></script></body></html>');
+ } else if (url.pathname.startsWith('/late-banner')) {
res.end(lateBannerPage);
} else if (url.pathname === '/index.html') {
res.end(`<!doctype html><html><body><p>${host} frame</p></body></html>`);
@@ -326,6 +341,11 @@ async function scenarios(name, driver) {
assert.equal(captchaStyles, 0, `${name}: autoconsent added nothing to the CAPTCHA frame`);
pass("'everywhere' declines the banner from the isolated world; the CAPTCHA frame is untouched");
+ const iframeUrl = `${origin}/iframe-consent`;
+ await driver.open(iframeUrl);
+ await until(async () => (await consent()) === 'refused', `${name}: the fastcmp rule to click inside its same-origin iframe`);
+ pass('a bundled selector-chain rule declines a banner inside a same-origin iframe');
+
// Revoking coverage must also stop a handler already searching this page.
const lateOffUrl = `${origin}/late-banner-off`;
await driver.open(lateOffUrl);