Skip to content

Open-source AI browser agent for Chrome and Firefox (monorepo) 🧠

fix: monitor popovers and release gestures over owned UI

Barack Sokullu3d6956dc947b
diff --git a/docs/page-feedback-monitor.md b/docs/page-feedback-monitor.md
index fd909192b..dbc9af13e 100644
--- a/docs/page-feedback-monitor.md
+++ b/docs/page-feedback-monitor.md
@@ -148,5 +148,10 @@ Text signatures cover the whole non-editable text with a cached fixed-size
fingerprint, so middle/suffix edits and appends beyond the first 200 characters
invalidate prepared actions even when geometry stays fixed. Accessibility-state
regressions also cover aria-pressed-only toggle changes and their agent attribution.
+Popover opening/closing is observed in document and open shadow roots before the
+next dispatch task, after cancellable page handlers finish. The later toggle event
+keeps the same action attribution; canceled openings and owned UI remain quiet.
+Trusted gesture endings always release the owning frame's idle gate, including
+pointer capture/release over extension-owned UI, without exposing that UI's target.
The monitor regressions are also included in `npm run test:runtime-lifecycle`.
diff --git a/src/chrome/src/content/page-monitor.js b/src/chrome/src/content/page-monitor.js
index dded97dd4..b946ddb9a 100644
--- a/src/chrome/src/content/page-monitor.js
+++ b/src/chrome/src/content/page-monitor.js
@@ -16,6 +16,7 @@
const nativeTargets = new Set();
let signatures = new WeakMap();
let textSignatures = new WeakMap();
+ let popoverTurns = new WeakMap();
let roots = new WeakSet();
let active = false, disposed = false, runToken = '', seq = 0, revision = 0;
let observer = null, domTimer = null, scrollTimer = null, lastUserAt = 0;
@@ -75,9 +76,10 @@
return delivery;
} catch { stop(); }
};
- const interact = (kind, el, extra = {}) => {
- if (!active || ignored(el)) return;
- lastUserAt = Date.now(); lastUserTarget = el; revision++;
+ const interact = (kind, el, { completeGesture = false, ...extra } = {}) => {
+ const isIgnored = ignored(el);
+ if (!active || (isIgnored && !completeGesture)) return;
+ lastUserAt = Date.now(); lastUserTarget = isIgnored ? null : el; revision++;
const marker = {}; userTurn = marker;
setTimeout(() => { if (userTurn === marker) userTurn = null; }, 0);
send({ kind, source: 'user', target: targetName(el), interacting: pointerHeld || composing, ...extra });
@@ -180,6 +182,7 @@
return JSON.stringify([shown, content, el.children.length + (el.shadowRoot?.children.length || 0), el.getAttribute('role'), el.getAttribute('aria-label'),
el.getAttribute('aria-expanded'), el.getAttribute('aria-selected'), el.getAttribute('aria-checked'),
el.getAttribute('aria-pressed'),
+ el.getAttribute('popover'), popoverOpen(el),
el.getAttribute('aria-hidden'), el.hasAttribute('open'), el.inert === true,
el.getAttribute('aria-disabled'), el.disabled === true, el.readOnly === true, el.checked === true, el.validity?.valid !== false, Math.round((rect.width || 0) / 8), Math.round((rect.height || 0) / 8),
Math.round(((rect.x || 0) + window.scrollX) / 8), Math.round(((rect.y || 0) + window.scrollY) / 8)]);
@@ -197,9 +200,35 @@
roots.add(root);
observer.observe(root, { childList: true, subtree: true, characterData: true, attributes: true, attributeOldValue: true,
attributeFilter: ['role', 'aria-label', 'aria-expanded', 'aria-selected', 'aria-checked', 'aria-pressed', 'aria-disabled',
- 'aria-hidden', 'hidden', 'disabled', 'readonly', 'checked', 'selected', 'open', 'inert', 'class', 'style'] });
+ 'aria-hidden', 'hidden', 'disabled', 'readonly', 'checked', 'selected', 'open', 'popover', 'inert', 'class', 'style'] });
+ listen(root, 'beforetoggle', event => {
+ const el = elementFor(event);
+ if (ignored(el) || !el.hasAttribute('popover') || !('popover' in el)) return;
+ const mark = { observer, oldState: event.oldState, newState: event.newState, notified: false,
+ agentUserAt: agentTurn && lastUserAt <= agentTurn.userAt ? agentTurn.userAt : undefined };
+ popoverTurns.set(el, mark);
+ // Check after page handlers can cancel opening, but before an action can
+ // dispatch in the next task. Retain exact attribution for the later toggle.
+ queueMicrotask(() => {
+ if (!active || observer !== mark.observer || popoverTurns.get(el) !== mark || event.defaultPrevented
+ || popoverOpen(el) !== (mark.newState === 'open')) return;
+ mark.notified = true;
+ onMutations([{ type: 'popover', target: el, stateChanged: mark.oldState !== mark.newState, agentUserAt: mark.agentUserAt }]);
+ });
+ });
+ listen(root, 'toggle', event => {
+ const el = elementFor(event);
+ if (ignored(el) || !el.hasAttribute('popover') || !('popover' in el)
+ || popoverOpen(el) !== (event.newState === 'open')) return;
+ const mark = popoverTurns.get(el);
+ if (mark?.observer === observer && mark.newState === event.newState && mark.notified) return;
+ onMutations([{ type: 'popover', target: el, stateChanged: event.oldState !== event.newState }]);
+ });
seed(root, budget);
}
+ function popoverOpen(el) {
+ return el.hasAttribute('popover') && 'popover' in el && el.matches(':popover-open');
+ }
function subtreeChanged(record, el) {
const changedNodes = [...record.addedNodes, ...record.removedNodes];
const meaningful = node => {
@@ -225,10 +254,10 @@
function onMutations(records) {
if (!active) return;
let changed = false, source = 'page', target = '';
- const noteChange = el => {
+ const noteChange = (el, agentUserAt) => {
// Attribute the marked input/write's synchronous handlers to that dispatch.
// Later DOM writes stay observable, including writes on the same target.
- if (agentTurn && lastUserAt <= agentTurn.userAt) return;
+ if ((Number.isFinite(agentUserAt) && lastUserAt <= agentUserAt) || (agentTurn && lastUserAt <= agentTurn.userAt)) return;
changed = true;
target ||= targetName(el);
if (userTurn || (Date.now() - lastUserAt < 1500 && related(lastUserTarget, el))) source = 'user';
@@ -236,7 +265,7 @@
};
const changes = [...records];
for (const record of records) {
- if (record.type !== 'attributes' || !['class', 'style', 'hidden', 'aria-hidden', 'open', 'inert'].includes(record.attributeName)) continue;
+ if (record.type !== 'popover' && (record.type !== 'attributes' || !['class', 'style', 'hidden', 'aria-hidden', 'open', 'inert'].includes(record.attributeName))) continue;
if (ignored(record.target)) continue;
if (record.target.getAnimations?.().some(animation => animation.playState === 'running')) continue;
const interactive = record.target.querySelectorAll?.('button,a,input,textarea,select,[role],[contenteditable]') || [];
@@ -244,13 +273,13 @@
// A bounded layout sample cannot prove that inherited visibility left a
// large subtree unchanged. Invalidate conservatively on an actual state
// change, before the measurement cap can omit a late affected descendant.
- if (all.length > 100 && record.oldValue !== record.target.getAttribute(record.attributeName)) noteChange(record.target);
+ if (all.length > 100 && (record.type === 'popover' || record.oldValue !== record.target.getAttribute(record.attributeName))) noteChange(record.target, record.agentUserAt);
const descendants = new Set([
...Array.prototype.slice.call(interactive, 0, 100),
...Array.prototype.slice.call(all, 0, 100),
]);
for (const el of descendants)
- changes.push({ type: 'layout', target: el });
+ changes.push({ type: 'layout', target: el, agentUserAt: record.agentUserAt });
}
let measured = 0;
const seedBudget = { remaining: 600 };
@@ -260,7 +289,8 @@
if (record.type === 'attributes' && ['class', 'style'].includes(record.attributeName)
&& el.getAnimations?.().some(animation => animation.playState === 'running')) continue;
if (++measured > 300) break;
- let identityChanged = record.type === 'shadow' && (visible(el) || signatures.get(el)?.startsWith('[true'));
+ let identityChanged = (record.type === 'popover' && record.stateChanged)
+ || (record.type === 'shadow' && (visible(el) || signatures.get(el)?.startsWith('[true')));
if (record.type === 'childList') {
identityChanged = subtreeChanged(record, el);
for (const node of record.addedNodes) {
@@ -276,7 +306,7 @@
const next = signature(el), previous = signatures.get(el);
signatures.set(el, next);
if (!identityChanged && (next === previous || (!visible(el) && !previous?.startsWith('[true')))) continue;
- noteChange(el);
+ noteChange(el, record.agentUserAt);
}
if (!changed) return;
revision++; publishRevision();
@@ -355,7 +385,7 @@
});
for (const name of ['pointerup', 'pointercancel']) listen(document, name, event => {
if (!pointerHeld || !event.isTrusted) return;
- pointerHeld = false; interact('activity', elementFor(event), { interacting: composing });
+ pointerHeld = false; interact('activity', elementFor(event), { interacting: composing, completeGesture: true });
});
listen(document, 'click', event => {
const el = elementFor(event);
@@ -382,7 +412,7 @@
if (!event.isTrusted || expected('input', el, event)) return;
// Key names identify scrolling and focus movement locally, never transmitted.
if (editable(el)) interact('activity', el);
- else if (['Tab', 'ArrowUp', 'ArrowDown', 'PageUp', 'PageDown', 'Home', 'End', ' '].includes(event.key)) interact('activity', el);
+ else if (['Tab', 'Escape', 'ArrowUp', 'ArrowDown', 'PageUp', 'PageDown', 'Home', 'End', ' '].includes(event.key)) interact('activity', el);
});
for (const name of ['wheel', 'touchmove']) listen(document, name, event => {
const el = elementFor(event);
@@ -441,7 +471,7 @@
clearTimeout(domTimer); clearTimeout(scrollTimer); domTimer = null; scrollTimer = null; unreported = 0; pendingDOM = null; lastFeedbackDelivery = Promise.resolve();
listeners.splice(0).forEach(remove => remove());
operations.clear(); localOperation = null; agentTurn = null;
- roots = new WeakSet(); signatures = new WeakMap(); textSignatures = new WeakMap();
+ roots = new WeakSet(); signatures = new WeakMap(); textSignatures = new WeakMap(); popoverTurns = new WeakMap();
}
async function requestState() {
const generation = ++requestGeneration;
diff --git a/src/firefox/src/content/page-monitor.js b/src/firefox/src/content/page-monitor.js
index dded97dd4..b946ddb9a 100644
--- a/src/firefox/src/content/page-monitor.js
+++ b/src/firefox/src/content/page-monitor.js
@@ -16,6 +16,7 @@
const nativeTargets = new Set();
let signatures = new WeakMap();
let textSignatures = new WeakMap();
+ let popoverTurns = new WeakMap();
let roots = new WeakSet();
let active = false, disposed = false, runToken = '', seq = 0, revision = 0;
let observer = null, domTimer = null, scrollTimer = null, lastUserAt = 0;
@@ -75,9 +76,10 @@
return delivery;
} catch { stop(); }
};
- const interact = (kind, el, extra = {}) => {
- if (!active || ignored(el)) return;
- lastUserAt = Date.now(); lastUserTarget = el; revision++;
+ const interact = (kind, el, { completeGesture = false, ...extra } = {}) => {
+ const isIgnored = ignored(el);
+ if (!active || (isIgnored && !completeGesture)) return;
+ lastUserAt = Date.now(); lastUserTarget = isIgnored ? null : el; revision++;
const marker = {}; userTurn = marker;
setTimeout(() => { if (userTurn === marker) userTurn = null; }, 0);
send({ kind, source: 'user', target: targetName(el), interacting: pointerHeld || composing, ...extra });
@@ -180,6 +182,7 @@
return JSON.stringify([shown, content, el.children.length + (el.shadowRoot?.children.length || 0), el.getAttribute('role'), el.getAttribute('aria-label'),
el.getAttribute('aria-expanded'), el.getAttribute('aria-selected'), el.getAttribute('aria-checked'),
el.getAttribute('aria-pressed'),
+ el.getAttribute('popover'), popoverOpen(el),
el.getAttribute('aria-hidden'), el.hasAttribute('open'), el.inert === true,
el.getAttribute('aria-disabled'), el.disabled === true, el.readOnly === true, el.checked === true, el.validity?.valid !== false, Math.round((rect.width || 0) / 8), Math.round((rect.height || 0) / 8),
Math.round(((rect.x || 0) + window.scrollX) / 8), Math.round(((rect.y || 0) + window.scrollY) / 8)]);
@@ -197,9 +200,35 @@
roots.add(root);
observer.observe(root, { childList: true, subtree: true, characterData: true, attributes: true, attributeOldValue: true,
attributeFilter: ['role', 'aria-label', 'aria-expanded', 'aria-selected', 'aria-checked', 'aria-pressed', 'aria-disabled',
- 'aria-hidden', 'hidden', 'disabled', 'readonly', 'checked', 'selected', 'open', 'inert', 'class', 'style'] });
+ 'aria-hidden', 'hidden', 'disabled', 'readonly', 'checked', 'selected', 'open', 'popover', 'inert', 'class', 'style'] });
+ listen(root, 'beforetoggle', event => {
+ const el = elementFor(event);
+ if (ignored(el) || !el.hasAttribute('popover') || !('popover' in el)) return;
+ const mark = { observer, oldState: event.oldState, newState: event.newState, notified: false,
+ agentUserAt: agentTurn && lastUserAt <= agentTurn.userAt ? agentTurn.userAt : undefined };
+ popoverTurns.set(el, mark);
+ // Check after page handlers can cancel opening, but before an action can
+ // dispatch in the next task. Retain exact attribution for the later toggle.
+ queueMicrotask(() => {
+ if (!active || observer !== mark.observer || popoverTurns.get(el) !== mark || event.defaultPrevented
+ || popoverOpen(el) !== (mark.newState === 'open')) return;
+ mark.notified = true;
+ onMutations([{ type: 'popover', target: el, stateChanged: mark.oldState !== mark.newState, agentUserAt: mark.agentUserAt }]);
+ });
+ });
+ listen(root, 'toggle', event => {
+ const el = elementFor(event);
+ if (ignored(el) || !el.hasAttribute('popover') || !('popover' in el)
+ || popoverOpen(el) !== (event.newState === 'open')) return;
+ const mark = popoverTurns.get(el);
+ if (mark?.observer === observer && mark.newState === event.newState && mark.notified) return;
+ onMutations([{ type: 'popover', target: el, stateChanged: event.oldState !== event.newState }]);
+ });
seed(root, budget);
}
+ function popoverOpen(el) {
+ return el.hasAttribute('popover') && 'popover' in el && el.matches(':popover-open');
+ }
function subtreeChanged(record, el) {
const changedNodes = [...record.addedNodes, ...record.removedNodes];
const meaningful = node => {
@@ -225,10 +254,10 @@
function onMutations(records) {
if (!active) return;
let changed = false, source = 'page', target = '';
- const noteChange = el => {
+ const noteChange = (el, agentUserAt) => {
// Attribute the marked input/write's synchronous handlers to that dispatch.
// Later DOM writes stay observable, including writes on the same target.
- if (agentTurn && lastUserAt <= agentTurn.userAt) return;
+ if ((Number.isFinite(agentUserAt) && lastUserAt <= agentUserAt) || (agentTurn && lastUserAt <= agentTurn.userAt)) return;
changed = true;
target ||= targetName(el);
if (userTurn || (Date.now() - lastUserAt < 1500 && related(lastUserTarget, el))) source = 'user';
@@ -236,7 +265,7 @@
};
const changes = [...records];
for (const record of records) {
- if (record.type !== 'attributes' || !['class', 'style', 'hidden', 'aria-hidden', 'open', 'inert'].includes(record.attributeName)) continue;
+ if (record.type !== 'popover' && (record.type !== 'attributes' || !['class', 'style', 'hidden', 'aria-hidden', 'open', 'inert'].includes(record.attributeName))) continue;
if (ignored(record.target)) continue;
if (record.target.getAnimations?.().some(animation => animation.playState === 'running')) continue;
const interactive = record.target.querySelectorAll?.('button,a,input,textarea,select,[role],[contenteditable]') || [];
@@ -244,13 +273,13 @@
// A bounded layout sample cannot prove that inherited visibility left a
// large subtree unchanged. Invalidate conservatively on an actual state
// change, before the measurement cap can omit a late affected descendant.
- if (all.length > 100 && record.oldValue !== record.target.getAttribute(record.attributeName)) noteChange(record.target);
+ if (all.length > 100 && (record.type === 'popover' || record.oldValue !== record.target.getAttribute(record.attributeName))) noteChange(record.target, record.agentUserAt);
const descendants = new Set([
...Array.prototype.slice.call(interactive, 0, 100),
...Array.prototype.slice.call(all, 0, 100),
]);
for (const el of descendants)
- changes.push({ type: 'layout', target: el });
+ changes.push({ type: 'layout', target: el, agentUserAt: record.agentUserAt });
}
let measured = 0;
const seedBudget = { remaining: 600 };
@@ -260,7 +289,8 @@
if (record.type === 'attributes' && ['class', 'style'].includes(record.attributeName)
&& el.getAnimations?.().some(animation => animation.playState === 'running')) continue;
if (++measured > 300) break;
- let identityChanged = record.type === 'shadow' && (visible(el) || signatures.get(el)?.startsWith('[true'));
+ let identityChanged = (record.type === 'popover' && record.stateChanged)
+ || (record.type === 'shadow' && (visible(el) || signatures.get(el)?.startsWith('[true')));
if (record.type === 'childList') {
identityChanged = subtreeChanged(record, el);
for (const node of record.addedNodes) {
@@ -276,7 +306,7 @@
const next = signature(el), previous = signatures.get(el);
signatures.set(el, next);
if (!identityChanged && (next === previous || (!visible(el) && !previous?.startsWith('[true')))) continue;
- noteChange(el);
+ noteChange(el, record.agentUserAt);
}
if (!changed) return;
revision++; publishRevision();
@@ -355,7 +385,7 @@
});
for (const name of ['pointerup', 'pointercancel']) listen(document, name, event => {
if (!pointerHeld || !event.isTrusted) return;
- pointerHeld = false; interact('activity', elementFor(event), { interacting: composing });
+ pointerHeld = false; interact('activity', elementFor(event), { interacting: composing, completeGesture: true });
});
listen(document, 'click', event => {
const el = elementFor(event);
@@ -382,7 +412,7 @@
if (!event.isTrusted || expected('input', el, event)) return;
// Key names identify scrolling and focus movement locally, never transmitted.
if (editable(el)) interact('activity', el);
- else if (['Tab', 'ArrowUp', 'ArrowDown', 'PageUp', 'PageDown', 'Home', 'End', ' '].includes(event.key)) interact('activity', el);
+ else if (['Tab', 'Escape', 'ArrowUp', 'ArrowDown', 'PageUp', 'PageDown', 'Home', 'End', ' '].includes(event.key)) interact('activity', el);
});
for (const name of ['wheel', 'touchmove']) listen(document, name, event => {
const el = elementFor(event);
@@ -441,7 +471,7 @@
clearTimeout(domTimer); clearTimeout(scrollTimer); domTimer = null; scrollTimer = null; unreported = 0; pendingDOM = null; lastFeedbackDelivery = Promise.resolve();
listeners.splice(0).forEach(remove => remove());
operations.clear(); localOperation = null; agentTurn = null;
- roots = new WeakSet(); signatures = new WeakMap(); textSignatures = new WeakMap();
+ roots = new WeakSet(); signatures = new WeakMap(); textSignatures = new WeakMap(); popoverTurns = new WeakMap();
}
async function requestState() {
const generation = ++requestGeneration;
diff --git a/test/page-monitor-ui.mjs b/test/page-monitor-ui.mjs
index 7caad8b04..771be9428 100644
--- a/test/page-monitor-ui.mjs
+++ b/test/page-monitor-ui.mjs
@@ -404,6 +404,105 @@ test('Firefox native preparation keeps same-target user edits and sends no stale
});
for (const [build, engine] of [['chrome', chromium], ['firefox', firefox]]) {
+ test(`${build}: a pointer gesture ending on owned UI releases the background idle gate`, async () => {
+ const savedChrome = globalThis.chrome, savedBrowser = globalThis.browser, tab = 945;
+ const host = Object.assign({ isRunning: () => true, _checkAbort: () => false, _runAbortSignal: () => null,
+ _throwIfAborted: () => {}, _pageFeedbackIdleMs: 20 }, pageFeedbackMethods);
+ globalThis.chrome = { runtime: {}, tabs: { get: async () => ({ url: 'https://monitor.test/start' }), sendMessage: async () => ({ ready: true }) } };
+ delete globalThis.browser;
+ let browser;
+ try {
+ await host._beginPageFeedbackRun(tab, 'interactive');
+ const state = await fixture(engine, build, { runToken: host._pageFeedbackRuns.get(tab).token });
+ browser = state.browser; const { page } = state;
+ const documentToken = await page.evaluate(() => document.documentElement.getAttribute('data-webbrain-page-revision').split(':')[0]);
+ const sender = { tab: { id: tab }, frameId: 0 }; host.pageMonitorState(sender, documentToken);
+ await page.exposeFunction('feedbackToHost', feedback => host.observePageFeedback(sender, feedback));
+ await page.evaluate(() => {
+ const original = chrome.runtime.sendMessage;
+ chrome.runtime.sendMessage = async message => {
+ const response = await original(message);
+ return message.action === 'page_feedback' ? await feedbackToHost(message.feedback) : response;
+ };
+ const ui = document.createElement('div'); ui.id = 'owned-capture';
+ ui.style.cssText = 'position:fixed;top:440px;left:20px;width:200px;height:80px;background:red';
+ __wbPageMonitor.registerDecoration(ui); document.body.append(ui);
+ document.getElementById('human').addEventListener('pointerdown', event => ui.setPointerCapture(event.pointerId));
+ feedback = [];
+ });
+ const button = await page.locator('#human').boundingBox();
+ await page.mouse.move(button.x + button.width / 2, button.y + button.height / 2); await page.mouse.down();
+ await page.waitForFunction(() => feedback.some(event => event.interacting === true));
+ assert.ok(host._pageFeedbackRuns.get(tab).gestures.has(0));
+ await page.mouse.move(100, 480); await page.mouse.up();
+ await page.waitForFunction(() => feedback.some(event => event.kind === 'activity' && event.interacting === false), null, { timeout: 1000 });
+ assert.equal(host._pageFeedbackRuns.get(tab).gestures.size, 0);
+ assert.ok(!JSON.stringify(await page.evaluate(() => feedback)).includes('owned-capture'), 'Owned UI must remain absent from event targets');
+ await host._waitForPageFeedbackIdle(tab);
+ } finally { host._finishPageFeedbackRun(tab); await browser?.close(); globalThis.chrome = savedChrome; globalThis.browser = savedBrowser; }
+ });
+
+ test(`${build}: popover transitions fence actions in light/shadow DOM without agent feedback loops`, async () => {
+ const { browser, page } = await fixture(engine, build);
+ try {
+ await page.evaluate(() => {
+ const popup = document.createElement('div'); popup.id = 'light-popup'; popup.popover = 'auto'; popup.innerHTML = '<button>Popup target</button>';
+ document.body.prepend(popup);
+ const host = document.createElement('div'); host.id = 'popup-host'; document.body.prepend(host);
+ host.attachShadow({ mode: 'open' }).innerHTML = '<div id="shadow-popup" popover><button>Shadow target</button></div>';
+ window.popups = [popup, host.shadowRoot.querySelector('[popover]')];
+ const filler = document.createElement('div'); filler.style.display = 'none'; filler.innerHTML = '<span>Outside signature budget</span>'.repeat(650);
+ document.body.prepend(filler);
+ monitorEnabled = false; deliver('page_monitor_state'); monitorEnabled = true; deliver('page_monitor_state');
+ });
+ await page.waitForTimeout(200);
+ for (const index of [0, 1]) {
+ await page.evaluate(index => {
+ monitorEnabled = false; deliver('page_monitor_state'); popups[index].showPopover();
+ monitorEnabled = true; deliver('page_monitor_state');
+ }, index);
+ await page.waitForTimeout(200);
+ const initialClose = await page.evaluate(async index => {
+ feedback = []; const finish = __wbPageMonitor.beginContentAction('click', { selector: '#agent', _bidiPrepare: true });
+ popups[index].hidePopover(); await Promise.resolve();
+ try { __wbPageMonitor.beforeLocalDispatch(); return null; } catch (error) { return error.code; } finally { finish(); }
+ }, index);
+ assert.equal(initialClose, 'page_feedback_pending', 'Closing an initially open unseeded popover must invalidate actions');
+ await page.waitForFunction(() => feedback.some(event => event.kind === 'dom'), null, { timeout: 1000 });
+ for (const open of [true, false]) {
+ const code = await page.evaluate(async ({ index, open }) => {
+ feedback = []; const finish = __wbPageMonitor.beginContentAction('click', { selector: '#agent', _bidiPrepare: true });
+ popups[index][open ? 'showPopover' : 'hidePopover'](); await Promise.resolve();
+ try { __wbPageMonitor.beforeLocalDispatch(); return null; } catch (error) { return error.code; } finally { finish(); }
+ }, { index, open });
+ assert.equal(code, 'page_feedback_pending');
+ await page.waitForFunction(() => feedback.some(event => event.kind === 'dom'), null, { timeout: 1000 });
+ }
+ await page.evaluate(index => {
+ feedback = []; const finish = __wbPageMonitor.beginContentAction('execute_js');
+ try { __wbPageMonitor.beforeLocalDispatch(); popups[index].showPopover(); } finally { finish(); }
+ }, index);
+ await page.waitForTimeout(220);
+ assert.deepEqual(await page.evaluate(() => feedback), [], 'An agent-opened popover must not feed back during the later toggle task');
+ await page.evaluate(index => { popups[index].querySelector('button').focus(); feedback = []; }, index);
+ await page.keyboard.press('Escape');
+ await page.waitForFunction(index => !popups[index].matches(':popover-open') && feedback.some(event => event.kind === 'dom'), index, { timeout: 1000 });
+ assert.ok((await page.evaluate(() => feedback)).some(event => event.source === 'user' && event.kind === 'activity'));
+ await page.waitForTimeout(200);
+ const cancelled = await page.evaluate(async index => {
+ feedback = []; popups[index].addEventListener('beforetoggle', event => event.preventDefault(), { once: true });
+ const finish = __wbPageMonitor.beginContentAction('click', { selector: '#agent', _bidiPrepare: true });
+ popups[index].showPopover(); await Promise.resolve();
+ try { __wbPageMonitor.beforeLocalDispatch({ preparation: true }); return true; } catch { return false; } finally { finish(); }
+ }, index);
+ assert.equal(cancelled, true, 'A canceled opening must not invalidate the unchanged page');
+ await page.waitForTimeout(220); assert.deepEqual(await page.evaluate(() => feedback), []);
+ }
+ await page.evaluate(() => { monitorEnabled = false; deliver('page_monitor_state'); feedback = []; popups[0].showPopover(); });
+ await page.waitForTimeout(200); assert.deepEqual(await page.evaluate(() => feedback), []);
+ } finally { await browser.close(); }
+ });
+
test(`${build}: related data/blob frames receive monitor and MAIN shadow hook`, async () => {
const { browser, page } = await fixture(engine, build, { omitEmptyFrameMonitor: true });
try {