Open-source AI browser agent for Chrome and Firefox (monorepo) ðŸ§
JavaScript ai-agentai-agentsai-toolsbrowser-aibrowser-automationbrowser-extensionchrome-aichrome-devtoolschrome-extensionchrome-extensionsfirefox-addonfirefox-addonsfirefox-extensionfirefox-extensionsgemmagemma4minimaxoffline-aioffline-llmqwen
docs(newtab): round-85 review — the handoff module contract says Act is sent immediately
Claude4c1c3a699663
diff --git a/src/chrome/src/ui/newtab-handoff.js b/src/chrome/src/ui/newtab-handoff.jsindex 07d3a5b2c..6087ca599 100644--- a/src/chrome/src/ui/newtab-handoff.js+++ b/src/chrome/src/ui/newtab-handoff.js@@ -5,18 +5,20 @@* (`wbNewtabHandoff:<tabId>`, so two submissions can never overwrite each other)* and opens this panel from its own click handler. The panel claims the record* only if it is fresh and addressed to the tab it is showing:- * - Ask: the task is filled in and sent (Ask is read-only). If a run is already- * active in that tab it is queued behind it, exactly like pressing Send then.- * If the panel declines to send (plan review pending, state refresh, ...) the- * text stays in the composer for the user to send.- * If the composer already holds a different draft (the user's own, or an- * unconfirmed Act task) nothing is overwritten, the mode is left as it is, and- * nothing is sent: the task is added below the draft for the user to review- * and send.- * - Act: the task is filled in and the panel switches to Act, but nothing is- * sent. Act always needs the user's own Enter in the panel.+ * - Ask and Act: the task is filled in and sent straight away, pinned to the mode the+ * user chose in the new tab (`__mode`), so automatic mode selection cannot change it.+ * Act therefore starts acting without a further Enter (the new tab warns about this).+ * Act is first checked for eligibility (`ensureActMode`: selected-text scope, Ask-only+ * in-browser providers); if it is blocked the text is left in the composer, unsent, and+ * the mode is untouched. Plan before Act still applies when it is enabled.+ * If a run is already active in that tab the task is queued behind it, with its pinned+ * mode, exactly like pressing Send then. If the panel declines to send (plan review+ * pending, state refresh, ...) the text stays in the composer for the user to send.+ * If the composer already holds a different draft (the user's own, or an unsent task)+ * nothing is overwritten, the mode is left as it is, and nothing is sent: the task is+ * added below the draft for the user to review and send.*- * A second hand-off is held back while an earlier Ask is still being sent (its text+ * A second hand-off is held back while an earlier task is still being sent (its text* is still sitting in the composer): filling the composer again would make that* send see a changed draft and drop it.*diff --git a/src/firefox/src/ui/newtab-handoff.js b/src/firefox/src/ui/newtab-handoff.jsindex 07d3a5b2c..6087ca599 100644--- a/src/firefox/src/ui/newtab-handoff.js+++ b/src/firefox/src/ui/newtab-handoff.js@@ -5,18 +5,20 @@* (`wbNewtabHandoff:<tabId>`, so two submissions can never overwrite each other)* and opens this panel from its own click handler. The panel claims the record* only if it is fresh and addressed to the tab it is showing:- * - Ask: the task is filled in and sent (Ask is read-only). If a run is already- * active in that tab it is queued behind it, exactly like pressing Send then.- * If the panel declines to send (plan review pending, state refresh, ...) the- * text stays in the composer for the user to send.- * If the composer already holds a different draft (the user's own, or an- * unconfirmed Act task) nothing is overwritten, the mode is left as it is, and- * nothing is sent: the task is added below the draft for the user to review- * and send.- * - Act: the task is filled in and the panel switches to Act, but nothing is- * sent. Act always needs the user's own Enter in the panel.+ * - Ask and Act: the task is filled in and sent straight away, pinned to the mode the+ * user chose in the new tab (`__mode`), so automatic mode selection cannot change it.+ * Act therefore starts acting without a further Enter (the new tab warns about this).+ * Act is first checked for eligibility (`ensureActMode`: selected-text scope, Ask-only+ * in-browser providers); if it is blocked the text is left in the composer, unsent, and+ * the mode is untouched. Plan before Act still applies when it is enabled.+ * If a run is already active in that tab the task is queued behind it, with its pinned+ * mode, exactly like pressing Send then. If the panel declines to send (plan review+ * pending, state refresh, ...) the text stays in the composer for the user to send.+ * If the composer already holds a different draft (the user's own, or an unsent task)+ * nothing is overwritten, the mode is left as it is, and nothing is sent: the task is+ * added below the draft for the user to review and send.*- * A second hand-off is held back while an earlier Ask is still being sent (its text+ * A second hand-off is held back while an earlier task is still being sent (its text* is still sitting in the composer): filling the composer again would make that* send see a changed draft and drop it.*diff --git a/test/newtab.mjs b/test/newtab.mjsindex 2bc97b76e..936e90f38 100644--- a/test/newtab.mjs+++ b/test/newtab.mjs@@ -2695,3 +2695,9 @@ test('round-83: ensureActMode can answer eligibility without switching the panel// already in Act: the eligibility query still looks at the provider (WebGPU is Ask-only)assert.match(chrome, /if \(agentMode === 'act' && switchMode\) return true;\s*if \(await inBrowserProviderBlocksMode\(\)\) return false;/);});++test('round-85: the handoff module contract says Act is sent immediately', () => {+ const src = readFileSync(path.join(root, 'src', 'chrome', 'src/ui/newtab-handoff.js'), 'utf8');+ assert.doesNotMatch(src, /Act always needs the user's own Enter/);+ assert.match(src, /Ask and Act: the task is filled in and sent straight away/);+});