Open-source AI browser agent for Chrome and Firefox (monorepo) ðŸ§
JavaScript ai-agentai-agentsai-toolsbrowser-aibrowser-automationbrowser-extensionchrome-aichrome-devtoolschrome-extensionchrome-extensionsfirefox-addonfirefox-addonsfirefox-extensionfirefox-extensionsgemmagemma4minimaxoffline-aioffline-llmqwen
fix(sidepanel): label interrupted terminal steps as failed
Emre Sokullu549f1446b3e1
diff --git a/src/chrome/src/ui/sidepanel.js b/src/chrome/src/ui/sidepanel.jsindex 29546b363..b8c10210d 100644--- a/src/chrome/src/ui/sidepanel.js+++ b/src/chrome/src/ui/sidepanel.js@@ -10909,8 +10909,18 @@ function findLastActiveCompactStep(toolName = '') {// and clear the progress marker so future locale changes refresh the label.function restoreStepFriendlyLabel(step) {if (!step || !step.dataset?.tool) return;- if (isTerminalDoneTool(step.dataset.tool)) return;const label = step.querySelector('.step-label');+ if (isTerminalDoneTool(step.dataset.tool)) {+ const failed = step.querySelector('.step-icon')?.classList.contains('fail')+ || step.dataset.rejectedCompletion === 'true';+ const key = step.dataset.rejectedCompletion === 'true'+ ? 'sp.tool.done.rejected'+ : (failed ? 'sp.tool.done.failed' : 'sp.tool.done.completed');+ if (label) label.textContent = String(t(key)).trim();+ step.dataset.doneLabelKey = key;+ step.dataset.labelSource = 'done-terminal';+ return;+ }if (label) {let stepArgs = null;try {diff --git a/src/firefox/src/ui/sidepanel.js b/src/firefox/src/ui/sidepanel.jsindex 6352c2db3..014d902f2 100644--- a/src/firefox/src/ui/sidepanel.js+++ b/src/firefox/src/ui/sidepanel.js@@ -10519,8 +10519,18 @@ function findLastActiveCompactStep(toolName = '') {// and clear the progress marker so future locale changes refresh the label.function restoreStepFriendlyLabel(step) {if (!step || !step.dataset?.tool) return;- if (isTerminalDoneTool(step.dataset.tool)) return;const label = step.querySelector('.step-label');+ if (isTerminalDoneTool(step.dataset.tool)) {+ const failed = step.querySelector('.step-icon')?.classList.contains('fail')+ || step.dataset.rejectedCompletion === 'true';+ const key = step.dataset.rejectedCompletion === 'true'+ ? 'sp.tool.done.rejected'+ : (failed ? 'sp.tool.done.failed' : 'sp.tool.done.completed');+ if (label) label.textContent = String(t(key)).trim();+ step.dataset.doneLabelKey = key;+ step.dataset.labelSource = 'done-terminal';+ return;+ }if (label) {let stepArgs = null;try {diff --git a/test/run.js b/test/run.jsindex 6b54868b1..86b561791 100644--- a/test/run.js+++ b/test/run.js@@ -45077,6 +45077,7 @@ test('sidepanel friendlyToolLabel localizes get_accessibility_tree and actions aassert.match(panel, /const LABEL_ARG_KEYS =/, `${label}: step metadata must filter arguments to label-relevant keys`);assert.match(panel, /function isTerminalDoneTool\(name\)/, `${label}: done_json must share terminal completion handling`);assert.match(panel, /function restoreStepFriendlyLabel\(step\)/, `${label}: completed/failed steps must restore friendly label and clear progress marker`);+ assert.match(panel, /failed \? 'sp\.tool\.done\.failed' : 'sp\.tool\.done\.completed'/, `${label}: restoreStepFriendlyLabel must set terminal failure outcome for interrupted done steps`);assert.match(panel, /label\.textContent = friendlyToolLabel\(step\.dataset\.tool, stepArgs\);/, `${label}: completed steps must restore the friendly label after progress`);}});