Skip to content

Open-source AI browser agent for Chrome and Firefox (monorepo) 🧠

fix: consume rejected saves and reserve import headroom

Emre Sokullu7677c8a32b4b
diff --git a/test/workflow-editor.mjs b/test/workflow-editor.mjs
index 33ee239e3..cd2d4fe83 100644
--- a/test/workflow-editor.mjs
+++ b/test/workflow-editor.mjs
@@ -159,8 +159,16 @@ for (const [name, browserType] of Object.entries({ chromium, firefox })) {
test(`${name}: portable JSON byte limit is reported before export`, () => withEditor(async page => {
const oversized = { ...fixture, extra: { payload: 'x'.repeat(1024 * 1024) } };
await page.evaluate(value => editor.load(value), oversized);
- assert.ok((await page.evaluate(() => editor.validate())).some(issue => issue.includes('exceeds the importer 1 MiB file limit')));
+ assert.ok((await page.evaluate(() => editor.validate())).some(issue => issue.includes('importer 1 MiB file limit')));
assert.equal((name === 'chromium' ? importChromeWorkflow : importFirefoxWorkflow)(oversized).reason, 'workflow_too_large');
+
+ const nearLimit = { ...fixture, start: { origin: 'https://example.com', pathFamily: '/' }, steps: [{ id: 'step_1', tool: 'navigate', args: { url: 'https://example.com/' } }] };
+ const initialBytes = new TextEncoder().encode(JSON.stringify(nearLimit)).byteLength;
+ nearLimit.steps[0].args.url += 'a'.repeat(1024 * 1024 - 10 - initialBytes);
+ assert.equal(new TextEncoder().encode(JSON.stringify(nearLimit)).byteLength, 1024 * 1024 - 10);
+ assert.equal((name === 'chromium' ? importChromeWorkflow : importFirefoxWorkflow)(nearLimit).reason, 'workflow_too_large');
+ await page.evaluate(value => editor.load(value), nearLimit);
+ assert.ok((await page.evaluate(() => editor.validate())).some(issue => issue.includes('leave room for normalized metadata')));
}));
test(`${name}: offline file import, editing, preservation, export, embedding`, async () => {
@@ -244,12 +252,20 @@ for (const [name, browserType] of Object.entries({ chromium, firefox })) {
assert.equal(rejectedDownloads, 0);
assert.equal(await page.evaluate(() => editor.getValue().parameters[0].id), 'address');
assert.match(await page.getByRole('status').innerText(), /Parameter ids must use/);
+ assert.equal(await page.evaluate(() => editor.changeFailed), false);
+ const recoveredDownload = page.waitForEvent('download');
+ await page.getByRole('button', { name: 'Download JSON', exact: true }).click();
+ assert.equal((await recoveredDownload).suggestedFilename(), 'keyboard-name.json');
+ const beforeMouseReject = rejectedDownloads;
await val(page, ['parameters', 0, 'id']).fill('Invalid ID');
await page.getByRole('button', { name: 'Download JSON', exact: true }).click();
await page.waitForTimeout(100);
- assert.equal(rejectedDownloads, 0);
+ assert.equal(rejectedDownloads, beforeMouseReject);
assert.equal(await page.evaluate(() => editor.getValue().parameters[0].id), 'address');
assert.match(await page.getByRole('status').innerText(), /Parameter ids must use/);
+ const mouseRecovery = page.waitForEvent('download');
+ await page.getByRole('button', { name: 'Download JSON', exact: true }).click();
+ assert.equal((await mouseRecovery).suggestedFilename(), 'keyboard-name.json');
await page.setViewportSize({ width: 390, height: 844 });
await page.getByRole('button', { name: 'Workflow details', exact: true }).click();
assert.equal(await page.evaluate(() => document.documentElement.scrollWidth <= innerWidth), true);
diff --git a/web/workflow-editor/workflow-editor.js b/web/workflow-editor/workflow-editor.js
index 96398815b..1b39ef16f 100644
--- a/web/workflow-editor/workflow-editor.js
+++ b/web/workflow-editor/workflow-editor.js
@@ -11,6 +11,7 @@
const targetFields = { id: 12, fieldName: 9, label: 8, ariaLabel: 8, name: 7, href: 7, placeholder: 5, type: 3, role: 2 };
const targetRequired = new Set(['click_ax', 'set_checked', 'type_ax', 'set_field']);
const maxPortableBytes = 1024 * 1024;
+ const normalizationReserveBytes = 16 * 1024;
const defaults = { string: '', number: 0, boolean: false, null: null, object: {}, array: [] };
const at = (value, path) => path.reduce((node, key) => node[key], value);
const put = (value, key, next) => Object.defineProperty(value, key, { value: next, writable: true, enumerable: true, configurable: true });
@@ -118,7 +119,9 @@
if (targetRequired.has(step.tool) && !replayableTarget(step.target)) issues.push(`Step ${index + 1} needs a replayable target with a name, label, id, or other strong locator.`);
});
try {
- if (new TextEncoder().encode(JSON.stringify(value)).byteLength > maxPortableBytes) issues.push('Workflow JSON exceeds the importer 1 MiB file limit.');
+ if (new TextEncoder().encode(JSON.stringify(value)).byteLength > maxPortableBytes - normalizationReserveBytes) {
+ issues.push('Workflow JSON is too close to the importer 1 MiB file limit; leave room for normalized metadata.');
+ }
} catch { issues.push('Workflow JSON cannot be serialized.'); }
return [...new Set(issues)];
}
@@ -282,13 +285,13 @@
}
download() {
if (!this.value) return;
- if (this.changeFailed) return;
+ if (this.changeFailed) { this.changeFailed = false; return; }
const active = this.root.activeElement;
if (active?.matches('.filename')) this.filename = active.value.trim() || 'workflow.json';
// Keyboard save must include the text still focused in the form.
if (this.pendingField?.isConnected) {
this.pendingField.dispatchEvent(new Event('change', { bubbles: true }));
- if (this.changeFailed) return;
+ if (this.changeFailed) { this.changeFailed = false; return; }
}
this.attempt(() => {
const blob = new Blob([this.toJSON()], { type: 'application/json' });
@@ -333,6 +336,7 @@
if (this.pointerActive || this.deferRender) { this.needsRender = true; return; }
this.needsRender = false;
this.pendingField = null;
+ this.changeFailed = false;
this.renderPaths = new Set();
const focused = this.root.activeElement;
const focusLabel = focused?.matches('input,textarea,select') ? focused.getAttribute('aria-label') : null;