Skip to content

Open-source AI browser agent for Chrome and Firefox (monorepo) 🧠

fix(sidepanel): redact userinfo through final authority delimiter and decode params

Emre Sokullu79340dc929fc
diff --git a/src/chrome/src/ui/sidepanel.js b/src/chrome/src/ui/sidepanel.js
index 104422183..6d5e1e81a 100644
--- a/src/chrome/src/ui/sidepanel.js
+++ b/src/chrome/src/ui/sidepanel.js
@@ -2998,9 +2998,13 @@ const SENSITIVE_PARAM_WORDS_RE = /(?:^|[_-])(?:key|api[_-]?key|token|secret|pass
// kebab-case (x-amz-signature), and camelCase (authToken, sessionToken) names.
function redactUrlForLabel(url) {
return String(url || '')
- .replace(/^([a-z][a-z0-9+.-]*:\/\/)[^/\s@]+@/i, '$1')
+ .replace(/^([a-z][a-z0-9+.-]*:\/\/)(?:[^/?#\s]*@)+/i, '$1')
.replace(/([?&#])([^=&#\s]+)=([^&#\s]*)/g, (match, prefix, param) => {
- const norm = String(param || '').replace(/([a-z])([A-Z])/g, '$1_$2').toLowerCase();
+ let decoded = param;
+ try {
+ decoded = decodeURIComponent(param);
+ } catch {}
+ const norm = String(decoded || '').replace(/([a-z])([A-Z])/g, '$1_$2').toLowerCase();
return SENSITIVE_PARAM_WORDS_RE.test(norm) ? `${prefix}${param}=…` : match;
});
}
diff --git a/src/firefox/src/ui/sidepanel.js b/src/firefox/src/ui/sidepanel.js
index 92cfb3f02..9202ce6cd 100644
--- a/src/firefox/src/ui/sidepanel.js
+++ b/src/firefox/src/ui/sidepanel.js
@@ -2859,9 +2859,13 @@ const SENSITIVE_PARAM_WORDS_RE = /(?:^|[_-])(?:key|api[_-]?key|token|secret|pass
// kebab-case (x-amz-signature), and camelCase (authToken, sessionToken) names.
function redactUrlForLabel(url) {
return String(url || '')
- .replace(/^([a-z][a-z0-9+.-]*:\/\/)[^/\s@]+@/i, '$1')
+ .replace(/^([a-z][a-z0-9+.-]*:\/\/)(?:[^/?#\s]*@)+/i, '$1')
.replace(/([?&#])([^=&#\s]+)=([^&#\s]*)/g, (match, prefix, param) => {
- const norm = String(param || '').replace(/([a-z])([A-Z])/g, '$1_$2').toLowerCase();
+ let decoded = param;
+ try {
+ decoded = decodeURIComponent(param);
+ } catch {}
+ const norm = String(decoded || '').replace(/([a-z])([A-Z])/g, '$1_$2').toLowerCase();
return SENSITIVE_PARAM_WORDS_RE.test(norm) ? `${prefix}${param}=…` : match;
});
}
diff --git a/test/run.js b/test/run.js
index e9bf02f47..c17b2d384 100644
--- a/test/run.js
+++ b/test/run.js
@@ -45064,6 +45064,8 @@ test('sidepanel friendlyToolLabel localizes get_accessibility_tree and actions a
assert.match(panel, /refreshRenderedStepLabels\(\);/, `${label}: locale-change handler must refresh rendered step labels`);
assert.ok((panel.match(/refreshRenderedStepLabels\(\);/g) || []).length >= 4, `${label}: restored transcripts must refresh step labels on every restore path`);
assert.match(panel, /function redactUrlForLabel\(url\)/, `${label}: URL step labels must redact credentials`);
+ assert.match(panel, /\(\?:\[\^\/\?#\\s\]\*@\)\+/, `${label}: URL userinfo redaction must strip through final authority delimiter`);
+ assert.match(panel, /decodeURIComponent/, `${label}: URL credential redaction must decode parameter names`);
assert.match(panel, /SENSITIVE_PARAM_WORDS_RE/, `${label}: URL credential redaction must inspect sensitive parameter names`);
assert.match(panel, /signature\|sig/, `${label}: URL credential redaction must cover signatures`);
assert.match(panel, /redactUrlForLabel\(args\.url\)/, `${label}: fetch/research labels must redact URL credentials`);