Open-source AI browser agent for Chrome and Firefox (monorepo) ðŸ§
JavaScript ai-agentai-agentsai-toolsbrowser-aibrowser-automationbrowser-extensionchrome-aichrome-devtoolschrome-extensionchrome-extensionsfirefox-addonfirefox-addonsfirefox-extensionfirefox-extensionsgemmagemma4minimaxoffline-aioffline-llmqwen
fix: preserve scroll for visible fixed-surface controls
Barack Sokullu7a3714f09bf6
diff --git a/src/chrome/src/content/content.js b/src/chrome/src/content/content.jsindex 819880ddb..3fe5a527b 100644--- a/src/chrome/src/content/content.js+++ b/src/chrome/src/content/content.js@@ -418,6 +418,7 @@if (!el?.isConnected) return;try {const view = el.ownerDocument?.defaultView || window;+ if (_isAlreadyVisibleInFixedSurface(el, view)) return;const insets = _getViewportDockedInsets(view, el);// A viewport-only rect check misses elements clipped by a scrollable// ancestor even when their bounding box is inside the viewport.@@ -467,6 +468,16 @@}}+ function _isAlreadyVisibleInFixedSurface(el, view = window) {+ if (!_isFullyVisibleForInteraction(el, { top: 0, bottom: 0 })) return false;+ for (let node = el; node; node = _composedParent(node)) {+ if (node.nodeType !== Node.ELEMENT_NODE) continue;+ const position = view.getComputedStyle(node).position;+ if (position === 'fixed' || position === 'sticky') return true;+ }+ return false;+ }+function _isComposedAncestor(ancestor, node) {let cur = node;while (cur) {@@ -2043,7 +2054,8 @@if (topmost && !_isComposedAncestor(el, topmost) && !_isComposedAncestor(topmost, el)) {const floatingBar = _floatingTopBarRect(topmost);const bRect = floatingBar || topmost.getBoundingClientRect();- if ((floatingBar || bRect.top <= _getViewportDockedInsets(window, el).top + 10)+ if (!_isAlreadyVisibleInFixedSurface(el)+ && (floatingBar || bRect.top <= _getViewportDockedInsets(window, el).top + 10)&& bRect.bottom > r.top && bRect.bottom < window.innerHeight * 0.45) {window.scrollBy({ top: r.top - bRect.bottom - 20, behavior: 'instant' });r = el.getBoundingClientRect();@@ -8071,7 +8083,8 @@try {const floatingBar = _floatingTopBarRect(topmost);const bRect = floatingBar || topmost.getBoundingClientRect();- if ((floatingBar || bRect.top <= _getViewportDockedInsets(window, el).top + 10)+ if (!_isAlreadyVisibleInFixedSurface(el)+ && (floatingBar || bRect.top <= _getViewportDockedInsets(window, el).top + 10)&& bRect.bottom > r.top && bRect.bottom < vh * 0.45) {window.scrollBy({ top: r.top - bRect.bottom - 20, behavior: 'instant' });r = el.getBoundingClientRect();diff --git a/src/firefox/src/content/content.js b/src/firefox/src/content/content.jsindex a1d10065e..d01f19439 100644--- a/src/firefox/src/content/content.js+++ b/src/firefox/src/content/content.js@@ -677,6 +677,7 @@if (!el?.isConnected) return;try {const view = el.ownerDocument?.defaultView || window;+ if (_isAlreadyVisibleInFixedSurface(el, view)) return;const insets = _getViewportDockedInsets(view, el);// A viewport-only rect check misses elements clipped by a scrollable// ancestor even when their bounding box is inside the viewport.@@ -726,6 +727,16 @@}}+ function _isAlreadyVisibleInFixedSurface(el, view = window) {+ if (!_isFullyVisibleForInteraction(el, { top: 0, bottom: 0 })) return false;+ for (let node = el; node; node = _composedParent(node)) {+ if (node.nodeType !== Node.ELEMENT_NODE) continue;+ const position = view.getComputedStyle(node).position;+ if (position === 'fixed' || position === 'sticky') return true;+ }+ return false;+ }+function _isComposedAncestor(ancestor, node) {let cur = node;while (cur) {@@ -2342,7 +2353,8 @@if (topmost && !_hitTestMatchesTarget(el, topmost)) {const floatingBar = _floatingTopBarRect(topmost);const bRect = floatingBar || topmost.getBoundingClientRect();- if ((floatingBar || bRect.top <= _getViewportDockedInsets(window, el).top + 10)+ if (!_isAlreadyVisibleInFixedSurface(el)+ && (floatingBar || bRect.top <= _getViewportDockedInsets(window, el).top + 10)&& bRect.bottom > r.top && bRect.bottom < window.innerHeight * 0.45) {window.scrollBy({ top: r.top - bRect.bottom - 20, behavior: 'instant' });r = el.getBoundingClientRect();diff --git a/test/fixtures/run.mjs b/test/fixtures/run.mjsindex 6e0e23496..f4d08e816 100644--- a/test/fixtures/run.mjs+++ b/test/fixtures/run.mjs@@ -2386,6 +2386,58 @@ test('Chrome: controls inside docked bars keep the document scroll position', pafirefoxTest('Firefox: controls inside docked bars keep the document scroll position', page =>assertDockedControlsKeepScroll(page, 'firefox'));+async function assertFixedSideRailControlsKeepScroll(page, browserKind) {+ await setupContentHtml(page, `<!doctype html>+ <style>+ html { scroll-padding-top: 80px; }+ body { margin: 0; height: 1700px; }+ header { position: fixed; top: 0; width: 100%; height: 80px; z-index: 10; background: white; }+ #side { position: fixed; top: 0; left: 0; width: 220px; height: 100vh; z-index: 20; background: white; display: flex; flex-direction: column; align-items: flex-start; gap: 4px; padding: 8px; }+ </style>+ <header>Page header</header>+ <div id="side">+ <button id="rail-button" onclick="window.__railClicked = true">Rail action</button>+ <input id="rail-input" aria-label="Rail input">+ <input id="rail-check" type="checkbox" aria-label="Rail check">+ </div>+ `, browserKind);+ await page.evaluate(() => window.scrollTo(0, 300));+ const before = await page.evaluate(() => window.scrollY);+ const click = await call(page, 'click', { selector: '#rail-button' });+ const clicked = await page.evaluate(() => ({ clicked: window.__railClicked === true, scrollY: window.scrollY }));+ if (!click?.success || !clicked.clicked || Math.abs(clicked.scrollY - before) > 1) {+ throw new Error(`${browserKind}: fixed side-rail click scrolled the page: ${JSON.stringify({ before, click, clicked })}`);+ }+ const inputRef = await page.evaluate(() => window.__wb_ax_ref(document.getElementById('rail-input')));+ const typed = await call(page, 'type_ax', { ref_id: inputRef, text: 'Ada', clear: true });+ const inputState = await page.evaluate(() => ({+ value: document.getElementById('rail-input').value, scrollY: window.scrollY,+ }));+ if (!typed?.success || inputState.value !== 'Ada' || Math.abs(inputState.scrollY - before) > 1) {+ throw new Error(`${browserKind}: fixed side-rail input scrolled the page: ${JSON.stringify({ before, typed, inputState })}`);+ }+ const checkRef = await page.evaluate(() => window.__wb_ax_ref(document.getElementById('rail-check')));+ const checked = await call(page, 'set_checked', { ref_id: checkRef, checked: true });+ const checkState = await page.evaluate(() => ({+ checked: document.getElementById('rail-check').checked, scrollY: window.scrollY,+ }));+ if (!checked?.success || !checkState.checked || Math.abs(checkState.scrollY - before) > 1) {+ throw new Error(`${browserKind}: fixed side-rail checkbox scrolled the page: ${JSON.stringify({ before, checked, checkState })}`);+ }+ if (browserKind === 'chrome') {+ const resolved = await call(page, 'ax_resolve_rect', { ref_id: inputRef });+ const afterResolve = await page.evaluate(() => window.scrollY);+ if (!resolved?.success || Math.abs(afterResolve - before) > 1) {+ throw new Error(`Chrome fixed side-rail rect resolution scrolled the page: ${JSON.stringify({ before, resolved, afterResolve })}`);+ }+ }+}++test('Chrome: controls inside a fixed side rail keep document scroll position', page =>+ assertFixedSideRailControlsKeepScroll(page, 'chrome'));+firefoxTest('Firefox: controls inside a fixed side rail keep document scroll position', page =>+ assertFixedSideRailControlsKeepScroll(page, 'firefox'));+async function assertStackedDockedBars(page, browserKind) {await setupContentHtml(page, `<!doctype html><style>