Open-source AI browser agent for Chrome and Firefox (monorepo) ðŸ§
JavaScript ai-agentai-agentsai-toolsbrowser-aibrowser-automationbrowser-extensionchrome-aichrome-devtoolschrome-extensionchrome-extensionsfirefox-addonfirefox-addonsfirefox-extensionfirefox-extensionsgemmagemma4minimaxoffline-aioffline-llmqwen
fix(linkedin): recognize shadow modal content containers
16Miku7b393f597615
diff --git a/src/chrome/src/content/content.js b/src/chrome/src/content/content.jsindex f941d2257..8387e4be1 100644--- a/src/chrome/src/content/content.js+++ b/src/chrome/src/content/content.js@@ -5204,17 +5204,27 @@const heuristicModalSelector = '[data-overlay],.modal.show,.modal-overlay,.overlay,'+ '[class*="modal"][class*="open"],[class*="overlay"][class*="active"],'+ '[class*="DialogOverlay"],[class*="ModalOverlay"]';+ const dialogContentSelector = '[class*="DialogContent"],[class*="ModalContent"]';const composedModal = _composedClosestElement(link,- `dialog,[role="dialog"],[role="alertdialog"],${heuristicModalSelector}`,+ `dialog,[role="dialog"],[role="alertdialog"],${heuristicModalSelector},${dialogContentSelector}`,);const modal = composedModal|| (blockingModal && _isComposedAncestor(blockingModal, link) ? blockingModal : null);+ const contentHasVisibleOverlaySibling = (() => {+ if (!modal?.matches?.(dialogContentSelector)) return false;+ const parent = modal.parentElement || modal.parentNode;+ if (!parent) return false;+ return Array.from(parent.children).some((sibling) => sibling !== modal+ && sibling.matches?.('[class*="DialogOverlay"],[class*="ModalOverlay"]')+ && _hasVisibleBox(sibling, 100, 100));+ })();const modalIsBlocking = !!modal && (modal === blockingModal|| (modal.tagName === 'DIALOG' && modal.hasAttribute('open') && _isNativeBlockingDialog(modal))|| (/^(?:dialog|alertdialog)$/.test(modal.getAttribute?.('role') || '')&& modal.getAttribute?.('aria-modal') === 'true')+ || contentHasVisibleOverlaySibling|| (() => {if (!modal.matches?.(heuristicModalSelector)) return false;const rect = modal.getBoundingClientRect();diff --git a/src/firefox/src/content/content.js b/src/firefox/src/content/content.jsindex 35bc01cf9..ac0ef1437 100644--- a/src/firefox/src/content/content.js+++ b/src/firefox/src/content/content.js@@ -4367,17 +4367,27 @@const heuristicModalSelector = '[data-overlay],.modal.show,.modal-overlay,.overlay,'+ '[class*="modal"][class*="open"],[class*="overlay"][class*="active"],'+ '[class*="DialogOverlay"],[class*="ModalOverlay"]';+ const dialogContentSelector = '[class*="DialogContent"],[class*="ModalContent"]';const composedModal = _composedClosestElement(link,- `dialog,[role="dialog"],[role="alertdialog"],${heuristicModalSelector}`,+ `dialog,[role="dialog"],[role="alertdialog"],${heuristicModalSelector},${dialogContentSelector}`,);const modal = composedModal|| (blockingModal && _isComposedAncestor(blockingModal, link) ? blockingModal : null);+ const contentHasVisibleOverlaySibling = (() => {+ if (!modal?.matches?.(dialogContentSelector)) return false;+ const parent = modal.parentElement || modal.parentNode;+ if (!parent) return false;+ return Array.from(parent.children).some((sibling) => sibling !== modal+ && sibling.matches?.('[class*="DialogOverlay"],[class*="ModalOverlay"]')+ && _hasVisibleBox(sibling, 100, 100));+ })();const modalIsBlocking = !!modal && (modal === blockingModal|| (modal.tagName === 'DIALOG' && modal.hasAttribute('open') && _isNativeBlockingDialog(modal))|| (/^(?:dialog|alertdialog)$/.test(modal.getAttribute?.('role') || '')&& modal.getAttribute?.('aria-modal') === 'true')+ || contentHasVisibleOverlaySibling|| (() => {if (!modal.matches?.(heuristicModalSelector)) return false;const rect = modal.getBoundingClientRect();diff --git a/test/fixtures/message-recipient-navigation.mjs b/test/fixtures/message-recipient-navigation.mjsindex dddcc87b9..f24d79afe 100644--- a/test/fixtures/message-recipient-navigation.mjs+++ b/test/fixtures/message-recipient-navigation.mjs@@ -249,6 +249,53 @@ export function registerMessageRecipientNavigationFixtures({assert.equal(await guard('click_ax', args), null);});+ register(`${kind}: LinkedIn Contact info recognizes shadow-root overlay content siblings`, async (page) => {+ const { guard, probe } = await setup(page);+ for (const [index, contentClass] of ['DialogContent', 'ModalContent'].entries()) {+ const ref_id = await page.evaluate(({ contentClass, index }) => {+ history.replaceState(null, '', '/in/alice/overlay/contact-info/');+ document.querySelector('#chat').hidden = false;+ const host = document.createElement('div');+ host.id = `shadow-sibling-modal-host-${index}`;+ document.body.append(host);+ const shadow = host.attachShadow({ mode: 'open' });+ shadow.innerHTML = `+ <div class="DialogOverlay" style="position:fixed;inset:0;background:rgba(0,0,0,.5)"></div>+ <div class="${contentClass}" style="position:fixed;inset:40px;background:white">+ <a href="/in/alice/">linkedin.com/in/alice</a>+ <a id="sibling-modal-link" href="/safety/go/?url=https%3A%2F%2Fportfolio.example%2F"+ style="display:inline-block;padding:8px">Sibling modal link</a>+ </div>`;+ return window.__wb_ax_ref(shadow.querySelector('#sibling-modal-link'));+ }, { contentClass, index });+ const args = { ref_id };+ const result = await probe('click_ax', args);+ assert.equal(result.navigation, true, `${contentClass}: ${JSON.stringify(result)}`);+ assert.equal(await guard('click_ax', args), null);+ await page.evaluate((index) => {+ document.querySelector(`#shadow-sibling-modal-host-${index}`)?.remove();+ }, index);+ }+ const ref_id = await page.evaluate(() => {+ const host = document.createElement('div');+ host.id = 'shadow-content-without-overlay-host';+ document.body.append(host);+ const shadow = host.attachShadow({ mode: 'open' });+ shadow.innerHTML = `+ <div class="DialogContent" style="position:fixed;inset:40px;background:white">+ <a href="/in/alice/">linkedin.com/in/alice</a>+ <a id="content-without-overlay-link"+ href="/safety/go/?url=https%3A%2F%2Fportfolio.example%2F"+ style="display:inline-block;padding:8px">Unbacked content link</a>+ </div>`;+ return window.__wb_ax_ref(shadow.querySelector('#content-without-overlay-link'));+ });+ const result = await probe('click_ax', { ref_id });+ assert.equal(result.navigationBlocked, true, JSON.stringify(result));+ assert.equal(result.conclusive, false, JSON.stringify(result));+ assert.equal((await guard('click_ax', { ref_id }))?.noDispatch, true);+ });+register(`${kind}: LinkedIn non-blocking dialogs cannot claim Contact info redirects`, async (page) => {const { guard, probe } = await setup(page);await page.evaluate(() => {